From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F327F20896C for ; Fri, 21 Feb 2025 11:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740136494; cv=none; b=S3Oo3lW86DgBxN6T7j5gFcMoyeqTn+FvRmfml5r3G6xzcahPqRY0xjDFu2maj/W/ZTdpFYFr2syMemYiACeLIIm2gvNQIJ/JHE9VLUb0aDiErMthL+NFcc7OkjacV3MOJkcAZBMa9xFWevUkWt52fJUuuwtjfHJnaSWu9xGCQIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740136494; c=relaxed/simple; bh=FY8aLZoXalN/YxJze2UCbfOU4J3I0AwOWV2az/14RSY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RnwI3TahQSVqnC6opsVHraD1kPA0E79CNvPvjb9CEO/11b0cjGjQEDj9dXTzxn0A+tNc2f12YTMgXmfCQz4SNK4LMGM4CliaQofG4gvG/xD7H+vk2Y1bQxro3pIHnYbuyhFTFmuiEkUJ3PD2t5la/wP0nfAJMmOJbI6svNkHrD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vwq1uJit; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vwq1uJit" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ab7d8953b48so28884366b.2 for ; Fri, 21 Feb 2025 03:14:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740136491; x=1740741291; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ovhPZM4lamF/N7gru3ZKZte0ZyqiKzSMS3HZ49d1xIk=; b=Vwq1uJitcPYPRMDL2b2ThezAa4xYH74zsziNy7s06jZXBjj4RTI/CNcUq9+QtCTCPN +U9tR3OHTE+MTZOvXMf2OezbeerwOs4rWc6sMzk+a4XZJMMK8D3I/Zk/LsmnldPovVXI Tqcp8BOpQHCycZlMmiw1cmg/EpFq/Auo3wgnpF7v1KBKYreLHMIs0V3CO7z85PozpQ2t 1K+v8gq6KsWAetHK8i28XSb6LkxIodba4aJi532P+ZbMYTtRKg8g1tnlp5DFNDZ2Cy36 ShWDqBCiQ9hVqFNpez289GFa1B0xCktI5WwYLS3tXnU1QLZX6w83EIGRz34mAT2EoDWP MCWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740136491; x=1740741291; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ovhPZM4lamF/N7gru3ZKZte0ZyqiKzSMS3HZ49d1xIk=; b=DD0euMqtiKNVVJQ9gG1FEVyaf+cMyjW5QT3Ky/oyxnHMXc3MGXdq5M0Apkxd5WAFEe SSZUztlmJU+B25lp0p3gLq2DfCqxIbH+ilGZPGv9TCYOccBE/bGQ5KfGaoLHPKkFAqs9 hYm5Wlxk8oOtBI8A2r8WCQNjLzj8bdIA5JZB98fpaVA0U99fx6Yt/HybcdIRfIayXFq0 4hfJ4SRXmnNbEve9SRHvDbZf1mJSBlLy306BwSV/2tb7TcKwNs4+hRoSkClTti3uIJSq 9dJkVVx1TRN/x1s7C3ocInaSYruoIaUnJu/LOzmOPcpXdyRm570lTXKQU7S3VJ4QWRc6 HQ/Q== X-Forwarded-Encrypted: i=1; AJvYcCVB4/CWznC/RP2GjtpPIUSEJNGGMcHmER3JG/9yI3GTgOp8950roaNLJxDuc/g36Edu5STP8oNxY+/3@vger.kernel.org X-Gm-Message-State: AOJu0Yxl4DZEe3+sbo6pgMAwOT8SuRCmB+hTjOooFNU2Y6XYn7SvPtoR UKCwqfni2uf2zoEvv2xGfA0AWyZf7ZLhLK8wQZrrHA9L2sZf1tryQ0+D7j6r4LM= X-Gm-Gg: ASbGncsy66l44s7TbFbMt/7yoiDlivfYfWOrOdjsfKDr7Nw2Ls22fyRjkpF/Vti1yWU ZRMDDA4or2XGYGiTFMQe8PlpI1KAkOsXMJbIpbKrSY6cIjsY12nxktICkZjPayNkUGprsT3iT1e uyos9qC/5jB+QdUK7q/x2mhJGfdYxchGHHT3d+FCH9nlJJX4rjNjxacHfMzuEGhh80+RRBRKdf+ bol3c3oTS0zVJKm5/xY2PlbTlRqufvWuG6GS+s8mptZjvGSTp1Usd31rJgCDV8C6XtU21IBYtYP kuPpbQ6ZKIUcXCrNOT0Ft4JoGUfqK/jnhm5u+j1uDJUf8JHyxiJoQKhEcyygnvGzX70cg4zOtL4 L5XAg X-Google-Smtp-Source: AGHT+IExhCVZ6dclPidui8BX3t7w/euKXXQuZ68kuHuXRdrPfZzRBNlO1WRvy20ay5cYzBgVThLtKQ== X-Received: by 2002:a17:907:9713:b0:ab7:f92c:8ff9 with SMTP id a640c23a62f3a-abc099c6f28mr112558866b.1.1740136491127; Fri, 21 Feb 2025 03:14:51 -0800 (PST) Received: from [192.168.0.18] (78-11-220-99.static.ip.netia.com.pl. [78.11.220.99]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abbbe74100asm678855066b.95.2025.02.21.03.14.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2025 03:14:50 -0800 (PST) Message-ID: <1994b168-b6e5-48c7-925a-8ba13e64cce0@linaro.org> Date: Fri, 21 Feb 2025 12:14:49 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 12/16] drm/msm/dsi: Add support for SM8750 To: Dmitry Baryshkov Cc: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Jonathan Marek , Kuogee Hsieh , Neil Armstrong , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srini Kandagatla References: <20250217-b4-sm8750-display-v2-0-d201dcdda6a4@linaro.org> <20250217-b4-sm8750-display-v2-12-d201dcdda6a4@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/02/2025 20:05, Dmitry Baryshkov wrote: > On Mon, Feb 17, 2025 at 05:41:33PM +0100, Krzysztof Kozlowski wrote: >> Add support for DSI on Qualcomm SM8750 SoC with notable difference: >> >> DSI PHY PLLs, the parents of pixel and byte clocks, cannot be used as >> parents before DSI PHY is configured and the PLLs are prepared with >> initial rate is set. Therefore assigned-clock-parents are not working >> here and driver is responsible for reparenting clocks with proper >> procedure: see dsi_clk_init_6g_v2_9(). >> >> Part of the change is exactly the same as CLK_OPS_PARENT_ENABLE, however >> CLK_OPS_PARENT_ENABLE won't work here because assigned-clock-parents are >> executed way too early - before DSI PHY is configured. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> SM8750 DSI PHY also needs Dmitry's patch: >> https://patchwork.freedesktop.org/patch/542000/?series=119177&rev=1 >> (or some other way of correct early setting of the DSI PHY PLL rate) >> --- >> drivers/gpu/drm/msm/dsi/dsi.h | 2 + >> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 25 ++++++++++++ >> drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + >> drivers/gpu/drm/msm/dsi/dsi_host.c | 80 ++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 108 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h >> index 87496db203d6c7582eadcb74e94eb56a219df292..93c028a122f3a59b1632da76472e0a3e781c6ae8 100644 >> --- a/drivers/gpu/drm/msm/dsi/dsi.h >> +++ b/drivers/gpu/drm/msm/dsi/dsi.h >> @@ -98,6 +98,7 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi); >> int msm_dsi_runtime_suspend(struct device *dev); >> int msm_dsi_runtime_resume(struct device *dev); >> int dsi_link_clk_set_rate_6g(struct msm_dsi_host *msm_host); >> +int dsi_link_clk_set_rate_6g_v2_9(struct msm_dsi_host *msm_host); >> int dsi_link_clk_set_rate_v2(struct msm_dsi_host *msm_host); >> int dsi_link_clk_enable_6g(struct msm_dsi_host *msm_host); >> int dsi_link_clk_enable_v2(struct msm_dsi_host *msm_host); >> @@ -115,6 +116,7 @@ int dsi_dma_base_get_6g(struct msm_dsi_host *msm_host, uint64_t *iova); >> int dsi_dma_base_get_v2(struct msm_dsi_host *msm_host, uint64_t *iova); >> int dsi_clk_init_v2(struct msm_dsi_host *msm_host); >> int dsi_clk_init_6g_v2(struct msm_dsi_host *msm_host); >> +int dsi_clk_init_6g_v2_9(struct msm_dsi_host *msm_host); >> int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_bonded_dsi); >> int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_bonded_dsi); >> void msm_dsi_host_snapshot(struct msm_disp_state *disp_state, struct mipi_dsi_host *host); >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c >> index 7754dcec33d06e3d6eb8a9d55e53f24af073adb9..e2a8d6fcc45b6c207a3018ea7c8744fcf34dabd2 100644 >> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c >> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c >> @@ -205,6 +205,17 @@ static const struct msm_dsi_config sm8650_dsi_cfg = { >> }, >> }; >> >> +static const struct msm_dsi_config sm8750_dsi_cfg = { > > Can we use sm8650_dsi_cfg instead? What is the difference? Yeah, I'll changeit. I think I was looking at this even and could not find differences. Best regards, Krzysztof