From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37F2B216E2C; Tue, 4 Feb 2025 19:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738696379; cv=none; b=J641xsr3nui9sVPBvx/p4s1LWXIt3s7m2djQXAHQ3IokWiVfgEyTooJYO2le8+6mQbqZP2Kq95fq4YoSCbl/bgNMqfIQyYBRGm6g7irkAyx5VzhPLSswxzlhwLRRnXWjxLBzEQa4VYlP0PjxxuETzchd5QBorQWiwvAYbljke18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738696379; c=relaxed/simple; bh=FCIkZ0zHX1EVPvEVggmjenYOAR1uVCfUxfqVrxA7GlQ=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=rPNn02bYsnzw1PJZy7iCkOwmySB0M3HqENEvpmvFgRICsNvU4TkrlBSs1z2j7NxJOiabNjG/yvdwg+dkeYhJNSdtfspzzt0TGm+YFq0ejyrfo4+zrQZ91zQy3BVNA56wn9j1XM0Ds2FvqFsgA1ZD8ZpVSIMBmVFPCT4XPfPRIhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=jq6MlJpZ; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="jq6MlJpZ" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 7129B25A3E; Tue, 4 Feb 2025 20:12:53 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id lB-3S3gQlaZ0; Tue, 4 Feb 2025 20:12:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1738696369; bh=FCIkZ0zHX1EVPvEVggmjenYOAR1uVCfUxfqVrxA7GlQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=jq6MlJpZr8ft6w8g/+vvrwXEZuTgbHJNoelhxvy2jRHZBaxB/RriKpGrZGYciN+lB 4kptKc8R7mBa0eu+SANMw1Ws3ko/kEErBqqQCNiiafl3wsFpSgZFq2+sr4F5tJuxTL AjYmZsaFUE2qHmmR+FlfmQRHqERU82uOUiONH5pExNbXlqFctIiHW+FD2pSWzGgQOV +3gCqtlAFxfDe29JcAXdPm8Q94XFial1JGh5y5lGE1OE4sSM7Bf7kUGiQ6WmnhRq5B VHGh59zuo8PJ8LedxF02Ew/7R2TqRyscloKMlf7gwYgHpwfLukJtkiT10i4ZHhvP7C Po9P8WFmeqIeg== Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 04 Feb 2025 19:12:48 +0000 From: Kaustabh Chakraborty To: Ivaylo Ivanov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Sergey Lisov , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Kaustabh Chakraborty Subject: Re: [PATCH v2 2/5] arm64: dts: exynos: add initial devicetree support for exynos7870 In-Reply-To: <00aa901b-5de9-4b72-a157-c54ad29df458@gmail.com> References: <20250204-exynos7870-v2-0-56313165ef0c@disroot.org> <20250204-exynos7870-v2-2-56313165ef0c@disroot.org> <00aa901b-5de9-4b72-a157-c54ad29df458@gmail.com> Message-ID: <199646ca71487cd6d2593c9b8bd7fa69@disroot.org> X-Sender: kauschluss@disroot.org Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On 2025-02-04 18:22, Ivaylo Ivanov wrote: > On 2/3/25 22:46, Kaustabh Chakraborty wrote: >> Exynos7870 is an arm64 SoC manufactured by Samsung and announced in >> 2016. It is present in multiple mid-range Samsung phones and tablets. >> >> Add basic devicetree support for the SoC, which includes CMUs, pin >> controllers, I2C, UART, DW-MMC, and USB-DRD. >> >> Co-developed-by: Sergey Lisov >> Signed-off-by: Sergey Lisov >> Signed-off-by: Kaustabh Chakraborty >> --- >> arch/arm64/boot/dts/exynos/exynos7870-pinctrl.dtsi | 1035 ++++++++++++++++++++ >> arch/arm64/boot/dts/exynos/exynos7870.dtsi | 722 ++++++++++++++ >> 2 files changed, 1757 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos7870-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7870-pinctrl.dtsi >> new file mode 100644 >> index 0000000000000000000000000000000000000000..28ff409c4fdc5f766d92617ea2df7be2112c28d1 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos7870-pinctrl.dtsi >> @@ -0,0 +1,1035 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Samsung Exynos7870 SoC pin-mux and pin-config device tree source >> + * >> + * Copyright (c) 2015 Samsung Electronics Co., Ltd. >> + */ >> + >> +#include >> +#include "exynos-pinctrl.h" >> + >> +&pinctrl0 { > > I haven't had enough time to look deeper, but these are my 2 cents: > > > Can you label them according to their block name rather than numbers? > For example, pinctrl_abox (make sure to keep them alphabetically sorted > as well). Can do. The rationale behind keeping it numeric was that the names were kind of misleading in some cases. > >> + etc0: etc0-gpio-bank { >> + gpio-controller; ... >> diff --git a/arch/arm64/boot/dts/exynos/exynos7870.dtsi b/arch/arm64/boot/dts/exynos/exynos7870.dtsi >> new file mode 100644 >> index 0000000000000000000000000000000000000000..11129e37fc86ebaee01684ed6841c932dd6cbc8a >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos7870.dtsi >> @@ -0,0 +1,722 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Samsung Exynos7870 SoC device tree source >> + * >> + * Copyright (c) 2015 Samsung Electronics Co., Ltd. >> + */ >> + >> +#include >> +#include >> +#include >> + ... >> + >> + reboot-mode { >> + compatible = "syscon-reboot-mode"; >> + offset = <0x080c>; >> + mode-bootloader = ; >> + mode-download = ; >> + mode-recovery = ; >> + }; >> + }; >> + ... >> + >> +#include "exynos7870-pinctrl.dtsi" >> +#include "arm/samsung/exynos-syscon-restart.dtsi" > > Didn't this already include a reboot node? Yes, I believe you've confused it with the *reboot-mode* node as defined above. > > Best regards, > Ivaylo > >>