From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
Eddie James <eajames@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: interrupt-controller: aspeed: add AST2700 SCU IC compatibles
Date: Mon, 4 Aug 2025 09:32:38 +0200 [thread overview]
Message-ID: <19b91a3b-a330-41d5-ba45-39279185a2d1@kernel.org> (raw)
In-Reply-To: <20250804053445.1482749-2-ryan_chen@aspeedtech.com>
On 04/08/2025 07:34, Ryan Chen wrote:
> - Add "aspeed,ast2700-scu-ic0,1,2,3" to the compatible
> list in aspeed,ast2500-scu-ic.yaml.
> - Document support for AST27XX SCU interrupt controllers.
We see that from the diff. Explain the differences between them. Also,
do not use lists - it seems you are mixing two independent tasks in one
commit.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-04 7:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 5:34 [PATCH 0/2] irqchip: Add support for Aspeed AST2700 SCU interrupt controller Ryan Chen
2025-08-04 5:34 ` [PATCH 1/2] dt-bindings: interrupt-controller: aspeed: add AST2700 SCU IC compatibles Ryan Chen
2025-08-04 7:32 ` Krzysztof Kozlowski [this message]
2025-08-05 1:39 ` Ryan Chen
2025-08-04 5:34 ` [PATCH 2/2] irqchip/aspeed-scu-ic: Add support for AST2700 SCU interrupt controllers Ryan Chen
2025-08-05 7:50 ` Thomas Gleixner
2025-08-06 6:43 ` Ryan Chen
2025-08-05 15:39 ` Rob Herring
2025-08-06 7:14 ` Ryan Chen
2025-08-06 13:41 ` Eddie James
2025-08-06 14:44 ` Thomas Gleixner
2025-08-07 0:23 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19b91a3b-a330-41d5-ba45-39279185a2d1@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).