From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2DFC4332F for ; Thu, 15 Dec 2022 10:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbiLOKjS convert rfc822-to-8bit (ORCPT ); Thu, 15 Dec 2022 05:39:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbiLOKjR (ORCPT ); Thu, 15 Dec 2022 05:39:17 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7B382C10A for ; Thu, 15 Dec 2022 02:39:15 -0800 (PST) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5ldl-0002Ha-Ud; Thu, 15 Dec 2022 11:39:02 +0100 Message-ID: <19bd825fa0df76e7b1223e34f934acadd32d6cdf.camel@pengutronix.de> Subject: Re: [PATCH v1] arm64: dts: verdin-imx8mp: add pcie support From: Lucas Stach To: Marcel Ziswiler , linux-arm-kernel@lists.infradead.org Cc: Shawn Guo , NXP Linux Team , Richard Zhu , Marcel Ziswiler , Fabio Estevam , Krzysztof Kozlowski , Laurent Pinchart , Max Krummenacher , Pengutronix Kernel Team , Philippe Schenker , Rob Herring , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 15 Dec 2022 11:38:58 +0100 In-Reply-To: <20221214061354.174072-1-marcel@ziswiler.com> References: <20221214061354.174072-1-marcel@ziswiler.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marcel, Am Mittwoch, dem 14.12.2022 um 07:13 +0100 schrieb Marcel Ziswiler: > From: Marcel Ziswiler > > Add PCIe support on the Verdin iMX8M Plus. > > Signed-off-by: Marcel Ziswiler > > --- > This has successfully been tested with Lucas' imx8mp-hsio-blk-ctrl high > performance PLL clock exposure patch set [1] a later version thereof > hopefully may land together with my humble patch. Thanks! > > [1] https://lore.kernel.org/all/20221213160112.1900410-1-l.stach@pengutronix.de/ > > .../dts/freescale/imx8mp-verdin-dahlia.dtsi | 9 +++++++- > .../boot/dts/freescale/imx8mp-verdin.dtsi | 22 ++++++++++++++++++- > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi > index 80db1ad7c230..56b0e4b865c9 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi > @@ -67,7 +67,14 @@ &i2c4 { > /* TODO: Audio Codec */ > }; > > -/* TODO: Verdin PCIE_1 */ > +/* Verdin PCIE_1 */ > +&pcie { > + status = "okay"; > +}; > + > +&pcie_phy { > + status = "okay"; > +}; > > /* Verdin PWM_1 */ > &pwm1 { > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > index 6a1890a4b5d8..f3a46f4caf49 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > @@ -749,7 +749,27 @@ eeprom_carrier_board: eeprom@57 { > }; > }; > > -/* TODO: Verdin PCIE_1 */ > +/* Verdin PCIE_1 */ > +&pcie { > + assigned-clocks = <&clk IMX8MP_CLK_PCIE_AUX>; > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_50M>; > + assigned-clock-rates = <10000000>; > + clocks = <&clk IMX8MP_CLK_HSIO_ROOT>, > + <&clk IMX8MP_CLK_PCIE_ROOT>, > + <&clk IMX8MP_CLK_HSIO_AXI>; > + clock-names = "pcie", "pcie_aux", "pcie_bus"; Now that I see this, I realize that those clocks and assignments could move into imx8mp.dtsi. I doubt that anyone would want to configure those clocks in a different way. The real difference between boards is the PCIe PHY reference clock and those differences are fully contained in the PHY node. Regards, Lucas > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pcie>; > + /* PCIE_1_RESET# (SODIMM 244) */ > + reset-gpio = <&gpio4 19 GPIO_ACTIVE_LOW>; > +}; > + > +&pcie_phy { > + clocks = <&hsio_blk_ctrl>; > + clock-names = "ref"; > + fsl,clkreq-unsupported; > + fsl,refclk-pad-mode = ; > +}; > > /* Verdin PWM_1 */ > &pwm1 {