From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF442C61DA4 for ; Wed, 15 Mar 2023 07:11:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbjCOHLO (ORCPT ); Wed, 15 Mar 2023 03:11:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbjCOHLN (ORCPT ); Wed, 15 Mar 2023 03:11:13 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01F843C34 for ; Wed, 15 Mar 2023 00:11:11 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id x13so24294078edd.1 for ; Wed, 15 Mar 2023 00:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678864270; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RJKjy9eK5wZQcLG5fFeMeaK9idc1WueAlGl5cn4lHVQ=; b=Bsyq91aeeTKsmlxTlYJI010C+B/lkrmiPlzr++t5RiGJkiL9FWgJQAMu4ndc0dD+qt bEyp1MWTUlzNQHtaC2+56g8+iWouWBuRidMKrm2RUOdt6+3iAfCmPd6IY+SP59Fp+coY oZkjnHSaUlA6DtLSvwYNivKPiKWBC8j52WMFZiitR7bz62y11hQ1c2IrhCXVGnLV1NwZ zQHiswP6WArtrzrbxtmHYCe5SCUCGS9tYVy6SGZMoBXzxjg62E/GdCHaqDufA0ieDEM5 EOKs7EC6GXQNpkpvS50aAVqarob3qGI1wwL8dt7TT5vv9io2zPkKrG01Hwg9AmHHoxb8 iqBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678864270; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RJKjy9eK5wZQcLG5fFeMeaK9idc1WueAlGl5cn4lHVQ=; b=2bFlX+5gWFxbFV+tBHHrbqFd9X5W0/jlP+aESc+vt9wA9NrlfTlbULAZBIfIZstxbU frIpCpYwbt710Omj89y5xFoj2/my4RCmzbeI29cdhqIub0/sOM2PGq/VqGgKqW9ejBqO dtDx22qbArSjtR36JPBbDdE79T08cv48gArJat3rOdERqms3S4gDRhvWzU+6y84LuRaZ Y39QPHeFtRLssFbXBUQgsjuFVl2NrNjTk3nU8weWORxjnEvB16qWMRBwXUQxlHRwjXSs GCMSYOZvznPnt2NFPPsmO7qLoPYu3bGEICAmsxmzABoYStlqbFoLUQx3UEOeUXhJZjBq PRvg== X-Gm-Message-State: AO0yUKVX5V/Ha6ch3SLTR397RJLrtogP8OxwvxlB3hPpFcPspcNPdk0m CJMfnVVh2tnBFYy9ccducWnshA== X-Google-Smtp-Source: AK7set/qDWN5EGtvyO4q718AHYQ/mq+PNb2Tfe4xtM7aMrCVi4QxJZNgnoNyQ52prNArRS2/pT1mwg== X-Received: by 2002:a05:6402:453:b0:4ea:a9b0:a518 with SMTP id p19-20020a056402045300b004eaa9b0a518mr1200057edw.17.1678864270104; Wed, 15 Mar 2023 00:11:10 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:940e:8615:37dc:c2bd? ([2a02:810d:15c0:828:940e:8615:37dc:c2bd]) by smtp.gmail.com with ESMTPSA id u14-20020a50a40e000000b004bbb691a334sm1960301edb.2.2023.03.15.00.11.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 00:11:09 -0700 (PDT) Message-ID: <19ca470e-8219-5ba9-3de6-f4560278f87b@linaro.org> Date: Wed, 15 Mar 2023 08:11:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] p54spi: convert to devicetree Content-Language: en-US To: Arnd Bergmann , Arnd Bergmann , Christian Lamparter , Kalle Valo Cc: Linus Walleij , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , Linux-OMAP , Tony Lindgren , Aaro Koskinen , Felipe Balbi , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Russell King , Dmitry Torokhov , Johannes Berg , linux-wireless@vger.kernel.org, Netdev , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230314163201.955689-1-arnd@kernel.org> <4ac809d2-3924-3839-479f-0b4be9f18a1f@linaro.org> <57c42604-38b0-61ce-2fc4-2284fbb9d708@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/03/2023 07:50, Arnd Bergmann wrote: > On Wed, Mar 15, 2023, at 07:32, Krzysztof Kozlowski wrote: >> On 14/03/2023 22:40, Arnd Bergmann wrote: >> >>>>> + >>>>> + power-gpios: >>>> >>>> If this is GPIO driving some power pin, then it should be >>>> "powerdown-gpios" (like in /bindings/gpio/gpio-consumer-common.yaml) >>> >>> As far as I can tell, it's the opposite: the gpio turns the power on >>> in 'high' state. I could make it GPIO_ACTIVE_LOW and call it powerdown, >>> if you think that's better, but I don't think that is how it was >>> meant. >> >> Whether this is active low or high, I think does not matter. If this is >> pin responsible to control the power, then we use the name >> "powerdown-gpios". Effectively powerup GPIO is the same as powerdown, >> just reversed. > > Ok, so should I make this GPIO_ACTIVE_LOW and adapt the patch to > call it powerdown in both the code and dt for consistency? If you have schematics (or datasheet) then this should reflect truth. If not, then judging by the old code it is something like powerdown, so yes - ACTIVE_LOW and reverse values in the code. Best regards, Krzysztof