From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3ACAC10F1D for ; Tue, 13 Dec 2022 13:21:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235234AbiLMNVO (ORCPT ); Tue, 13 Dec 2022 08:21:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiLMNVN (ORCPT ); Tue, 13 Dec 2022 08:21:13 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 643E2FCE5; Tue, 13 Dec 2022 05:21:12 -0800 (PST) Received: from [192.168.1.15] (91-154-32-225.elisa-laajakaista.fi [91.154.32.225]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 41F018B; Tue, 13 Dec 2022 14:21:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1670937669; bh=J8LpYqesZR71o1mfqqbbqBb8mV6mO1WIhuskeZSPO7U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nuzelpkFyIYwuQS/FdTOY1tFYIwpCPfk+3A4ijmloq++FLsTAOre3GqXyyqcpaiwE LCpyx5gPujWoZWY8SoK6iQSkGoPlq8xfqWWJc6fJCSK/V7CZta45MeDj5+DN8nBK9F iVvqN5DxTNTw71mzPsVVLHMjO/Tj6uUU056MG2Oc= Message-ID: <19cc7331-97e8-7a4c-b032-fee600d0c40f@ideasonboard.com> Date: Tue, 13 Dec 2022 15:21:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v5 3/8] dt-bindings: media: add bindings for TI DS90UB913 Content-Language: en-US To: Laurent Pinchart Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Wolfram Sang , Luca Ceresoli , Andy Shevchenko , Matti Vaittinen , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Sakari Ailus , Michael Tretter , Shawn Tu , Hans Verkuil , Mike Pagano , =?UTF-8?Q?Krzysztof_Ha=c5=82asa?= , Marek Vasut References: <20221208104006.316606-1-tomi.valkeinen@ideasonboard.com> <20221208104006.316606-4-tomi.valkeinen@ideasonboard.com> From: Tomi Valkeinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/12/2022 19:13, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Thu, Dec 08, 2022 at 12:40:01PM +0200, Tomi Valkeinen wrote: >> Add DT bindings for TI DS90UB913 FPDLink-3 Serializer. >> >> Signed-off-by: Tomi Valkeinen >> --- >> .../bindings/media/i2c/ti,ds90ub913.yaml | 121 ++++++++++++++++++ >> 1 file changed, 121 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml >> new file mode 100644 >> index 000000000000..3a5b34c6bb64 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml >> @@ -0,0 +1,121 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/i2c/ti,ds90ub913.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments DS90UB913 FPD-Link 3 Serializer > > I think TI consistently writes it "FPD-Link III". If you rename it, > please do so through the whole series. Indeed, good point. >> + >> +maintainers: >> + - Tomi Valkeinen >> + >> +description: >> + The TI DS90UB913 is an FPD-Link 3 video serializer for parallel video. >> + >> +properties: >> + compatible: >> + enum: >> + - ti,ds90ub913a-q1 > > Is the -q1 suffix needed, are there other variants ? I'm not sure, but I couldn't see at a quick glance. I don't know what the -q1 means. Even if many of the FPD-Link devices have -q1, there are models without -q1, like DS90CF366. Oh, all those non-q1s seem to be from Catalog, and -q1 versions from Automotive. But the -q1 seems to be part of the model name, so... Maybe it's better to keep it. https://www.ti.com/interface/high-speed-serdes/fpd-link-serdes/products.html >> + >> + '#gpio-cells': >> + const: 2 >> + >> + gpio-controller: true >> + >> + clocks: >> + maxItems: 1 >> + description: >> + Reference clock connected to the CLKIN pin. >> + >> + clock-names: >> + items: >> + - const: clkin >> + >> + '#clock-cells': >> + const: 0 >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: CSI-2 input port >> + >> + properties: >> + endpoint: >> + $ref: /schemas/media/video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + unevaluatedProperties: false >> + description: FPD-Link 3 output port > > I'd add > > required: > - port@0 > - port@1 Ok. Tomi