From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE077C54EBC for ; Tue, 10 Jan 2023 11:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232203AbjAJLO0 (ORCPT ); Tue, 10 Jan 2023 06:14:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238376AbjAJLNv (ORCPT ); Tue, 10 Jan 2023 06:13:51 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8CA9140BF for ; Tue, 10 Jan 2023 03:12:44 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id ay12-20020a05600c1e0c00b003d9ea12bafcso6139437wmb.3 for ; Tue, 10 Jan 2023 03:12:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3hWpYN6LpdI1bCNJeRuTYWRUAN/AJkpmmZGPLEqRg/A=; b=ggzET2pFF0LAlCsnjkRPjrVBQh4GA9P7gvS4q2pAnysqwkV/BZL0XaHZSuXSjWIttf ouYFXLLs7FaR9MuoVscbACK5FIPwDzInS5JO1lVyaa6q00IMm5Ih1Sr73a20S93yeaFi QVCeR1RyJH/eyVF6MgACzYUXHP/S5RRxwj14lTK/A6+DNB3fK3fKaWFbBYU0sWGtsIKK U0vwZDx6nI+pkpUwAJS5lBYdvHUCp6GyRyrjtlxH8stGwvDvDvKPUId8RWYJqnNge8uI b3UO0qEjkXN2Bcs/bxPcG2oJ64A9Rrrk2vcwK1vWkZkFX1WSKMNUDsoYyYXNl4ggSvLx 8UaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3hWpYN6LpdI1bCNJeRuTYWRUAN/AJkpmmZGPLEqRg/A=; b=d/FvOiLvnTE5fHUwHFHFfVo042oKMl5RRhfzAsWM1NidsZSatd1iKcqutkCBPv94JG qtAIlT8lo+TZ9HyYBYY0N903lf3mtm3eTH7+XvFG8LwVbLi9VQabcramCOAay9oDgqnR oGcmZUjyYaFjDwxpTSYA840pgQP6W16JBrj4bJfI7hG2YCow7xkP4EarC2Yl19Q2Qs8q 1rfIXdjxJffoHk5CbrwnMIAD4DlPIEWHDP9sbr9S7O/BM4eR6rlUFTm/bLbtLHDk1k3R siuvmZD6MeYeQer70t8I6wEqP6bKGgyqUUJC8//FiIBoQtCamUIalvL9CWFKlGRHdraW HVZw== X-Gm-Message-State: AFqh2kqh4VPIYsE+N151fVAQXhhsiRYR/aFsVr6oIPrCQVNPCUen7y2P bbnq4B9bRN+KuJmG6LgPC16T6w== X-Google-Smtp-Source: AMrXdXu6Vhwt0UN5RdB31tzzwSXtsoLlL+SluQw2JS6tb6gr/rteWJ0GTc9JEC4wg6KwQw/9Eb/jtw== X-Received: by 2002:a05:600c:1d03:b0:3d3:4aa6:4fe6 with SMTP id l3-20020a05600c1d0300b003d34aa64fe6mr48092613wms.3.1673349163374; Tue, 10 Jan 2023 03:12:43 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id az28-20020a05600c601c00b003cf57329221sm18894302wmb.14.2023.01.10.03.12.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 03:12:42 -0800 (PST) Message-ID: <19e61226-c0b9-657d-c36f-38067c6b01a7@linaro.org> Date: Tue, 10 Jan 2023 12:12:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/8] arm64: dts: qcom: sc7280: audioreach: Update VA/RX/TX macro clock nodes Content-Language: en-US To: Srinivasa Rao Mandadapu , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org, dianders@chromium.org, swboyd@chromium.org, judyhsiao@chromium.org, konrad.dybcio@linaro.org, mka@chromium.org References: <1672925875-2107-1-git-send-email-quic_srivasam@quicinc.com> <1672925875-2107-5-git-send-email-quic_srivasam@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1672925875-2107-5-git-send-email-quic_srivasam@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/01/2023 14:37, Srinivasa Rao Mandadapu wrote: > Update VA, RX and TX macro and lpass_tlmm clock properties and > enable them. > > Signed-off-by: Srinivasa Rao Mandadapu > Tested-by: Mohammad Rafi Shaik > --- > .../qcom/sc7280-herobrine-audioreach-wcd9385.dtsi | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi > index e1fe56c..8c55753 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi > @@ -8,6 +8,10 @@ > > #include > > +/delete-node/ &lpass_rx_macro; > +/delete-node/ &lpass_tx_macro; > +/delete-node/ &lpass_va_macro; > + > /{ > /* BOARD-SPECIFIC TOP LEVEL NODES */ > sound: sound { > @@ -107,3 +111,61 @@ > }; > }; > }; > + > +&soc { > + lpass_rx_macro: codec@3200000 { These should be properties of DTSI. The SoC either has them or not. It's not conditional or dual-setup... > + compatible = "qcom,sc7280-lpass-rx-macro"; > + reg = <0 0x03200000 0 0x1000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&lpass_rx_swr_clk>, <&lpass_rx_swr_data>; > + > + clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&lpass_va_macro>; > + > + clock-names = "mclk", "npl", "macro", "dcodec", "fsgen"; > + > + #clock-cells = <0>; > + #sound-dai-cells = <1>; > + }; /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: codec@3370000: clock-names: 'oneOf' conditional failed, one must be fixed: ['mclk', 'macro', 'dcodec'] is too long 'core' was expected From schema: /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: codec@3370000: Unevaluated properties are not allowed ('clock-names' was unexpected) From schema: /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: audio@3987000: clocks: [[218, 4], [221, 12], [221, 11], [221, 6], [221, 8], [223, 8], [223, 5], [223, 6], [223, 7], [218, 10]] is too long From schema: /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: audio@3987000: clock-names: 'oneOf' conditional failed, one must be fixed: ['aon_cc_audio_hm_h', 'audio_cc_ext_mclk0', 'core_cc_sysnoc_mport_core', 'core_cc_ext_if0_ibit', 'core_cc_ext_if1_ibit', 'audio_cc_codec_mem', 'audio_cc_codec_mem0', 'audio_cc_codec_mem1', 'audio_cc_codec_mem2', 'aon_cc_va_mem0'] is too long 'core_cc_sysnoc_mport_core' was expected 'audio_cc_codec_mem' was expected 'audio_cc_codec_mem0' was expected 'audio_cc_codec_mem1' was expected 'audio_cc_codec_mem2' was expected 'aon_cc_va_mem0' was expected From schema: /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml I posted recently several fixes, so some of the warnings might be skipped. But I think you did not test this at all... > + > + lpass_tx_macro: codec@3220000 { > + compatible = "qcom,sc7280-lpass-tx-macro"; > + reg = <0 0x03220000 0 0x1000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&lpass_tx_swr_clk>, <&lpass_tx_swr_data>; > + > + clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&lpass_va_macro>; > + > + clock-names = "mclk", "npl", "macro", "dcodec", "fsgen"; > + > + #clock-cells = <0>; > + #sound-dai-cells = <1>; > + Drop blank line > + }; > + > + lpass_va_macro: codec@3370000 { > + compatible = "qcom,sc7280-lpass-va-macro"; > + reg = <0 0x03370000 0 0x1000>; > + > + pinctrl-0 = <&lpass_dmic01_clk>, <&lpass_dmic01_data>; > + pinctrl-names = "default"; > + > + clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > + > + clock-names = "mclk", "macro", "dcodec"; > + > + #clock-cells = <0>; > + #sound-dai-cells = <1>; > + }; > +}; Best regards, Krzysztof