[PATCH 0/2] device tree support for ST M48T86

[PATCH 0/2] device tree support for ST M48T86

[Nikita Shubin via B4 Relay]

Add device tree support for ST M48T86.

The reason it can't go to trivial-rtc.yaml, is that it has 2 registers
instead of a single one. The registers are 1 byte wide.

Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
---
Nikita Shubin (2):
      dt-bindings: rtc: Add ST M48T86
      rtc: m48t86: add DT support for m48t86

 .../devicetree/bindings/rtc/st,m48t86.yaml         | 38 ++++++++++++++++++++++
 drivers/rtc/rtc-m48t86.c                           |  8 +++++
 2 files changed, 46 insertions(+)
---
base-commit: 89bf6209cad66214d3774dac86b6bbf2aec6a30d
change-id: 20230823-m48t86_device_tree-a72eaa294798

Best regards,
-- 
Nikita Shubin <nikita.shubin@maquefel.me>

[PATCH 1/2] dt-bindings: rtc: Add ST M48T86

[Nikita Shubin via B4 Relay]

From: Nikita Shubin <nikita.shubin@maquefel.me>

Add YAML bindings for ST M48T86 / Dallas DS12887 RTC.

Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
---
 .../devicetree/bindings/rtc/st,m48t86.yaml         | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/Documentation/devicetree/bindings/rtc/st,m48t86.yaml b/Documentation/devicetree/bindings/rtc/st,m48t86.yaml
new file mode 100644
index 000000000000..e3e12fa23380
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/st,m48t86.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/st,m48t86.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ST M48T86 / Dallas DS12887 RTC with SRAM
+
+maintainers:
+  - Alexandre Belloni <alexandre.belloni@bootlin.com>
+
+allOf:
+  - $ref: rtc.yaml
+
+properties:
+  compatible:
+    enum:
+      - st,m48t86
+
+  reg:
+    items:
+      - description: index register
+      - description: data register
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    rtc@10800000 {
+      compatible = "st,m48t86";
+      reg = <0x10800000 0x1>, <0x11700000 0x1>;
+    };
+
+...

-- 
2.39.2

[PATCH 2/2] rtc: m48t86: add DT support for m48t86

[Nikita Shubin via B4 Relay]

From: Nikita Shubin <nikita.shubin@maquefel.me>

Add OF ID match table.

Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
---
 drivers/rtc/rtc-m48t86.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/rtc/rtc-m48t86.c b/drivers/rtc/rtc-m48t86.c
index 481c9525b1dd..dd4a62e2d39c 100644
--- a/drivers/rtc/rtc-m48t86.c
+++ b/drivers/rtc/rtc-m48t86.c
@@ -11,6 +11,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/rtc.h>
 #include <linux/platform_device.h>
 #include <linux/bcd.h>
@@ -269,9 +270,16 @@ static int m48t86_rtc_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id m48t86_rtc_of_ids[] = {
+	{ .compatible = "st,m48t86" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, m48t86_rtc_of_ids);
+
 static struct platform_driver m48t86_rtc_platform_driver = {
 	.driver		= {
 		.name	= "rtc-m48t86",
+		.of_match_table = m48t86_rtc_of_ids,
 	},
 	.probe		= m48t86_rtc_probe,
 };

-- 
2.39.2

Re: [PATCH 2/2] rtc: m48t86: add DT support for m48t86

[Krzysztof Kozlowski]

On 23/08/2023 11:03, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <nikita.shubin@maquefel.me>
> 
> Add OF ID match table.
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

How did these appear? It's v1, so it is a bit confusing.

> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>

> 

Best regards,
Krzysztof

Re: [PATCH 2/2] rtc: m48t86: add DT support for m48t86

[Nikita Shubin]

Hello Krzysztof!

On Wed, 2023-08-23 at 12:14 +0200, Krzysztof Kozlowski wrote:
> On 23/08/2023 11:03, Nikita Shubin via B4 Relay wrote:
> > From: Nikita Shubin <nikita.shubin@maquefel.me>
> > 
> > Add OF ID match table.
> > 
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> How did these appear? It's v1, so it is a bit confusing.

Indeed this is from "ep93xx device tree conversion" series, you asked
to submit these part as a separate.

I don't know the rules for tags in such cases, sorry. It's discouraged
to use tags given elsewhere ?

> 
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> 
> > 
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 2/2] rtc: m48t86: add DT support for m48t86

[Krzysztof Kozlowski]

On 23/08/2023 12:20, Nikita Shubin wrote:
> Hello Krzysztof!
> 
> On Wed, 2023-08-23 at 12:14 +0200, Krzysztof Kozlowski wrote:
>> On 23/08/2023 11:03, Nikita Shubin via B4 Relay wrote:
>>> From: Nikita Shubin <nikita.shubin@maquefel.me>
>>>
>>> Add OF ID match table.
>>>
>>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> How did these appear? It's v1, so it is a bit confusing.
> 
> Indeed this is from "ep93xx device tree conversion" series, you asked
> to submit these part as a separate.
> 
> I don't know the rules for tags in such cases, sorry. It's discouraged
> to use tags given elsewhere ?

Ah, no, it's okay, but this patchset should have some history (e.g.
continuing versioning and changelog) or references to previous lore
submission with explanation.

Best regards,
Krzysztof