From mboxrd@z Thu Jan 1 00:00:00 1970 From: Segher Boessenkool Subject: Re: [PATCH 5/5] of/address: restrict 'no-ranges' kludge to powerpc Date: Tue, 15 Jun 2010 18:23:06 +0200 Message-ID: <1C7A9067-DDE6-47D3-AC78-FDC081354519@kernel.crashing.org> References: <20100608140917.25879.67745.stgit@angua> <20100608141018.25879.44413.stgit@angua> <1276152275.1962.61.camel@pasglop> Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset="us-ascii"; Format="flowed"; DelSp="yes" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1276152275.1962.61.camel@pasglop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Benjamin Herrenschmidt Cc: Stephen Rothwell , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org >> Certain Apple machines don't use the ranges property correctly, >> but the >> workaround should not be applied on other architectures. This patch >> disables the workaround for non-powerpc architectures. > > I'm half tempted to add it to the quirk list (which should really be > made generic) so I can disable it on more 'modern' powerpc as well. Oh please oh please oh please yes do. OTOH, it would be even better to just fix up the device tree in the early platform code. Quirks are for broken hardware; software, we can fix. Segher