From: "Huan He" <hehuan1@eswincomputing.com>
To: linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, p.zabel@pengutronix.de,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
pinkesh.vaghela@einfochips.com, luyulin@eswincomputing.com
Subject: Re: [PATCH v2 0/2] Add driver support for ESWIN EIC7700 PVT controller
Date: Wed, 11 Feb 2026 17:55:47 +0800 (GMT+08:00) [thread overview]
Message-ID: <1a08e50a.362b.19c4c20db59.Coremail.hehuan1@eswincomputing.com> (raw)
In-Reply-To: <20260128101400.859-1-hehuan1@eswincomputing.com>
>
> Add support for the ESWIN EIC7700 PVT (Process, Voltage, Temperature)
> sensor
>
> Features:
> The driver supports monitoring of process, voltage and temperature
> parameters through the hardware monitoring subsystem. It provides an
> access to the sampled Temperature and Voltage.
>
> Test:
> Tested this patch on the SiFive HiFive Premier P550 (which uses the ESWIN
> EIC7700 SoC).
>
> Updates:
>
> Changes in v2:
> - Update eswin,eic7700-pvt.yaml
> - Reference the hwmon-common.yaml file
> - Remove the clock-names and reset-names properties
> - Move additionalProperties: false after the required block
> - Remove one example node to avoid redundancy
> - Update eic7700-pvt.c and eic7700-pvt.h
> - Remove unused sensor macros (PVT_SENSOR_FIRST, PVT_SENSOR_LAST,
> PVT_SENSORS_NUM)
> - Drop the unnecessary hwmon-sysfs.h header
> - Replace dynamic sensor info allocation with a static array and unify
> sensor labels
> - Remove unused hwmon_temp_type attribute
> - Eliminate redundant validation checks
> - Remove mutex and related locking, relying on hwmon core
> serialization
> - Replace per-sensor caches and completions with a single data cache
> and completion object
> - Remove pvt->sensor tracking. ISR no longer depends on the currently
> selected sensor
> - Move devm_add_action() registration after init_completion() for
> safer cleanup, and update cleanup function (pvt_clear_data)
> - Replace devm_reset_control_get_optional_exclusive() with
> devm_reset_control_get_exclusive_deasserted()
> - Replace eic7700_pvt_remove() with eic7700_pvt_disable_pm_runtime()
> and move it after PM runtime enable to avoid resource leaks on probe
> failure and remove clock disable and reset assert from
> eic7700_pvt_disable_pm_runtime() as it is already handled by devm_*
> framework
> - Remove redundant clock presence check in runtime_resume
>
Hi Krzysztof, Guenter, all,
The v1 patch received reviews and comments from Krzysztof and Guenter.
The v2 patch incorporates changes based on those comments and has received
feedback from Conor.
I'm not sure if there has been time to review the updated v2 yet. Should I
wait for further feedback, or is any action needed from my side?
Best regards,
Huan He
> - Link to v1: https://lore.kernel.org/all/20260109090718.442-1-hehuan1@eswincomputing.com/
>
next prev parent reply other threads:[~2026-02-11 9:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 10:14 [PATCH v2 0/2] Add driver support for ESWIN EIC7700 PVT controller hehuan1
2026-01-28 10:16 ` [PATCH v2 1/2] dt-bindings: hwmon: Add Eswin EIC7700 PVT sensor hehuan1
2026-01-28 17:51 ` Conor Dooley
2026-01-29 3:06 ` Huan He
2026-01-29 16:42 ` Conor Dooley
2026-01-30 2:00 ` Huan He
2026-01-30 17:04 ` Conor Dooley
2026-01-28 10:17 ` [PATCH v2 2/2] hwmon: Add Eswin EIC7700 PVT sensor driver hehuan1
2026-02-11 9:55 ` Huan He [this message]
2026-02-11 11:05 ` [PATCH v2 0/2] Add driver support for ESWIN EIC7700 PVT controller Krzysztof Kozlowski
2026-02-12 4:24 ` Huan He
2026-02-12 6:05 ` Guenter Roeck
2026-02-14 6:48 ` Huan He
2026-03-05 11:12 ` Huan He
2026-03-05 14:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a08e50a.362b.19c4c20db59.Coremail.hehuan1@eswincomputing.com \
--to=hehuan1@eswincomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luyulin@eswincomputing.com \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox