From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Lucas Stach <l.stach@pengutronix.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Paul Elder <paul.elder@ideasonboard.com>,
Marek Vasut <marex@denx.de>, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example
Date: Wed, 11 May 2022 10:03:58 +0800 [thread overview]
Message-ID: <1a0e0d2c-2c80-0de4-d670-937e66fe3511@oss.nxp.com> (raw)
In-Reply-To: <20220510200543.13482-1-laurent.pinchart@ideasonboard.com>
On 2022/5/11 4:05, Laurent Pinchart wrote:
> The DT example incorrectly names the ISP power domain "isp1" instead of
> "isp". This causes a validation failure:
>
> Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected
> From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
>
> Fix it.
>
> Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> Shawn, this fixes an issue in linux-next, could you please apply the
> patch to your imx/bindings branch for v5.19 ?
> ---
> .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> index 21d3ee486295..b246d8386ba4 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> @@ -88,7 +88,7 @@ examples:
> <&mediamix_pd>, <&ispdwp_pd>, <&ispdwp_pd>,
> <&mipi_phy2_pd>;
> power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi",
> - "mipi-csi2", "lcdif2", "isp1", "dwe", "mipi-dsi2";
> + "mipi-csi2", "lcdif2", "isp", "dwe", "mipi-dsi2";
> clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>,
> <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
> <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>,
>
next prev parent reply other threads:[~2022-05-11 2:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 20:05 [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example Laurent Pinchart
2022-05-11 2:03 ` Peng Fan (OSS) [this message]
2022-05-12 14:19 ` Krzysztof Kozlowski
2022-05-16 7:31 ` paul.elder
2022-05-16 15:11 ` Rob Herring
2022-05-23 16:11 ` Rob Herring
2022-05-31 13:56 ` Rob Herring
2022-05-31 21:02 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a0e0d2c-2c80-0de4-d670-937e66fe3511@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=paul.elder@ideasonboard.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).