From: Krzysztof Kozlowski <krzk@kernel.org>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: vgxy61: Fix driver name
Date: Tue, 11 Jun 2024 08:47:15 +0200 [thread overview]
Message-ID: <1a13587c-28c1-4074-8b0f-7f663b308b65@kernel.org> (raw)
In-Reply-To: <20240610150815.228790-2-benjamin.mugnier@foss.st.com>
On 10/06/2024 17:08, Benjamin Mugnier wrote:
> From 'st-vgxy61' to 'vgxy61'.
> Align with other drivers to not use the vendor prefix.
> Also the vendor prefix is already mentioned in the device tree
> compatible string, being 'st,vgxy61', and does not need to be expressed twice.
What bindings have anything to do with driver name?
I think I made it clear last time.
>
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
> .../media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml} | 6 +++---
> Documentation/userspace-api/media/drivers/index.rst | 2 +-
> .../media/drivers/{st-vgxy61.rst => vgxy61.rst} | 0
> MAINTAINERS | 8 ++++----
> drivers/media/i2c/Kconfig | 2 +-
> drivers/media/i2c/Makefile | 2 +-
> drivers/media/i2c/{st-vgxy61.c => vgxy61.c} | 2 +-
> 7 files changed, 11 insertions(+), 11 deletions(-)
> rename Documentation/devicetree/bindings/media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml} (95%)
> rename Documentation/userspace-api/media/drivers/{st-vgxy61.rst => vgxy61.rst} (100%)
> rename drivers/media/i2c/{st-vgxy61.c => vgxy61.c} (99%)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
> similarity index 95%
> rename from Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> rename to Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
> index 8c28848b226a..4e4c2c7ad168 100644
> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
> @@ -2,7 +2,7 @@
> # Copyright (c) 2022 STMicroelectronics SA.
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/media/i2c/st,st-vgxy61.yaml#
> +$id: http://devicetree.org/schemas/media/i2c/st,vgxy61.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: STMicroelectronics VGxy61 HDR Global Shutter Sensor Family
> @@ -23,7 +23,7 @@ description: |-
>
> properties:
> compatible:
> - const: st,st-vgxy61
> + const: st,vgxy61
Why? No. NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-11 6:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 15:08 [PATCH 0/3] media: vgxy61: Remove vendor prefix from driver name Benjamin Mugnier
2024-06-10 15:08 ` [PATCH 1/3] media: vgxy61: Fix " Benjamin Mugnier
2024-06-11 6:47 ` Krzysztof Kozlowski [this message]
2024-06-10 15:08 ` [PATCH 2/3] media: vgxy61: Add legacy compatible string Benjamin Mugnier
2024-06-11 6:47 ` Krzysztof Kozlowski
2024-06-11 8:19 ` Sakari Ailus
2024-06-11 8:38 ` Krzysztof Kozlowski
2024-06-11 11:57 ` Benjamin Mugnier
2024-06-11 12:17 ` Krzysztof Kozlowski
2024-06-11 13:07 ` Benjamin Mugnier
2024-06-11 20:54 ` Krzysztof Kozlowski
2024-06-10 15:08 ` [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS() Benjamin Mugnier
2024-06-11 6:48 ` Krzysztof Kozlowski
2024-06-11 8:21 ` Sakari Ailus
2024-06-11 11:57 ` Benjamin Mugnier
2024-06-11 13:11 ` Sakari Ailus
2024-06-11 13:13 ` Benjamin Mugnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a13587c-28c1-4074-8b0f-7f663b308b65@kernel.org \
--to=krzk@kernel.org \
--cc=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).