From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96779C77B7A for ; Wed, 31 May 2023 06:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234122AbjEaGtR (ORCPT ); Wed, 31 May 2023 02:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbjEaGtQ (ORCPT ); Wed, 31 May 2023 02:49:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B8C5113; Tue, 30 May 2023 23:49:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1802A63712; Wed, 31 May 2023 06:49:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8659C433D2; Wed, 31 May 2023 06:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685515754; bh=1xNhr76unyrARJPcBdufPMM+HTaMSKo+HbDxKvgS8VY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sGHmBP1+fOScMQIcsdweRl8DEw6ejOyqY0bMgCSc+wCyV42XqSXjh2CbphayB6TsA Xr9WBVzm9/Uwc/+2UsTfNl2MlDeU0hz3wQk1Ej7cVU6GX6oKPQPXUKtqKTk+F/4Guk ufkKgnBfoYjUu51V3IEGyvrtJzZAAO5r1uLCdGkv7TKIOv/Ls+QMZyC+JPtL/TnFQR JHauymoXMVvCyjs2HUbssxDeWtyiyH9SAZxJUqudcSsjwXpjNR87JhRbRX8XHqaZAv lRuwqGLtT3a3ppRPlsa7XsrJhIXfCRk8cK339m7thzZv3uPK6Xo3Rds+CXKd88Wz1C xiEw19rKx5VTQ== Message-ID: <1a267380-c39d-d3a7-9287-61ba632480c3@kernel.org> Date: Wed, 31 May 2023 08:49:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/3] dt-bindings: rtc: Add Mstar SSD20xD RTC devicetree bindings documentation To: Daniel Palmer Cc: Romain Perier , Alessandro Zummo , Alexandre Belloni , Rob Herring , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230517144144.365631-1-romain.perier@gmail.com> <20230517144144.365631-3-romain.perier@gmail.com> <669d7b79-71a6-e1f9-8d7a-71c4b64de28d@kernel.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/05/2023 01:12, Daniel Palmer wrote: > Hi Krzysztof, > > On Tue, 30 May 2023 at 17:01, Krzysztof Kozlowski wrote: >>> This is >>> exactly the case for rtc-msc313e and it was not an issue. >> >> So that was my question - can it be anything else? There is literally no >> description of the hardware... Neither in commit msg nor in description: >> field in bindings. > > This RTC block is a block inside of the SSD201/SSD202D (they are the But what is SSD201? > same die with different memory attached) and is only found there. > The documentation we have for this is literally one page in a PDF that > says "RTC registers". > It could be an IP block licensed from somewhere and technically have a > better name but right now all we know is this RTC block is the one in > that chip and that chip is the first known instance of it. > > Say we manage to get the ethernet mainlined at some point: That's a > lot easier as we know already it's a hacked up version of the cadence > macb so the compatible can be "macb something". > >>>> What about interrupt line? >>> >>> There is currently no interrupt right now, we have not yet the irqchip >>> code for handling the alarm irq of this rtc block. >> >> So you are going to change the hardware and add the interrupt line? We >> do not talk about drivers, but hardware. Whether your driver handles it >> or not, matters less. >> >> Describe the hardware, not the current implementation of one driver. > > We don't really know how the interrupt is wired up in the hardware properly yet. OK Best regards, Krzysztof