From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E851C761A6 for ; Tue, 28 Mar 2023 09:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232715AbjC1J65 (ORCPT ); Tue, 28 Mar 2023 05:58:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232467AbjC1J6x (ORCPT ); Tue, 28 Mar 2023 05:58:53 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 179C06A58; Tue, 28 Mar 2023 02:58:51 -0700 (PDT) Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32S9shk6000530; Tue, 28 Mar 2023 11:58:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=WgobufBoN42IEs5ZSFVLsVL/P0UO9CKmIaFyDWY7oXg=; b=MQ81+Hk16ObyxQLguF2YIAmUZGFebM8Y/yfQSIKptWESFOrzK0jRQ4cuXeWNK/2zauil MEyIEY09orvrN4ffckmH0CQuf9Y9hJzdot2q7W36lGCYzHEdh7fnNJUwwK38C1PmQIDH mllTyAVPxcpIU61E/xOOJdjZYr8dN8zhK4cwDD97VWIHWV0CGeJE+G6eIW4mrXmtDTUo Cv0YDODhnr7MVPUYuBMuNfz5Z9r+JzyA9zg0sFfadFlzSU9oB1PRjHHW241jZCObxAKf kp8M2UWpcAM92bJN9TkyXf8Av6i9Aunhtm2ZggVqLjtnd3FU7S15PmIU4I4sOxugmw8I RQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3pkvs4rnts-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Mar 2023 11:58:37 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6C79A10002A; Tue, 28 Mar 2023 11:58:36 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 65723211F1E; Tue, 28 Mar 2023 11:58:36 +0200 (CEST) Received: from [10.201.21.93] (10.201.21.93) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Tue, 28 Mar 2023 11:58:35 +0200 Message-ID: <1a2d16c8-8c16-5fcc-7906-7b454a81922f@foss.st.com> Date: Tue, 28 Mar 2023 11:58:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1] ARM: dts: stm32: prtt1c: Add PoDL PSE regulator nodes Content-Language: en-US To: Oleksij Rempel , Maxime Coquelin , Rob Herring , Krzysztof Kozlowski , =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= CC: , , , , , References: <20230323123242.3763673-1-o.rempel@pengutronix.de> From: Alexandre TORGUE In-Reply-To: <20230323123242.3763673-1-o.rempel@pengutronix.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.21.93] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-27_02,2023-02-09_01 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Oleksij On 3/23/23 13:32, Oleksij Rempel wrote: > This commit introduces Power over Data Line (PoDL) Power Source > Equipment (PSE) regulator nodes to the PRTT1C devicetree. The addition > of these nodes enables support for PoDL in PRTT1C devices, allowing > power delivery and data transmission over a single twisted pair. > > The new PoDL PSE regulator nodes provide voltage capability information > of the current board design, which can be used as a hint for system > administrators when configuring and managing power settings. This > update enhances the versatility and simplifies the power management of > PRTT1C devices while ensuring compatibility with connected Powered > Devices (PDs). > > After applying this patch, the power delivery can be controlled from > user space with a patched [1] ethtool version using the following commands: > ethtool --set-pse t1l2 podl-pse-admin-control enable > to enable power delivery, and > ethtool --show-pse t1l2 > to display the PoDL PSE settings. > > By integrating PoDL PSE support into the PRTT1C devicetree, users can > benefit from streamlined power and data connections in their > deployments, improving overall system efficiency and reducing cabling > complexity. > > [1] https://lore.kernel.org/all/20230317093024.1051999-1-o.rempel@pengutronix.de/ > > Signed-off-by: Oleksij Rempel > --- Please, fix the introduction of those new yaml validation errors: arch/arm/boot/dts/stm32mp151a-prtt1c.dtb: ethernet-pse-1: $nodename:0: 'ethernet-pse-1' does not match '^ethernet-pse(@.*)?$' From schema: /Documentation/devicetree/bindings/net/pse-pd/podl-pse-regulator.yaml arch/arm/boot/dts/stm32mp151a-prtt1c.dtb: ethernet-pse-2: $nodename:0: 'ethernet-pse-2' does not match '^ethernet-pse(@.*)?$' From schema: /local/home/frq08678/STLINUX/kernel/my-kernel/stm32/Documentation/devicetree/bindings/net/pse-pd/podl-pse-regulator.yaml Thanks Alex > arch/arm/boot/dts/stm32mp151a-prtt1c.dts | 32 ++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32mp151a-prtt1c.dts b/arch/arm/boot/dts/stm32mp151a-prtt1c.dts > index 58bb05a8c685..ca0d3329cfd7 100644 > --- a/arch/arm/boot/dts/stm32mp151a-prtt1c.dts > +++ b/arch/arm/boot/dts/stm32mp151a-prtt1c.dts > @@ -23,6 +23,18 @@ clock_sja1105: clock-sja1105 { > clock-frequency = <25000000>; > }; > > + pse_t1l1: ethernet-pse-1 { > + compatible = "podl-pse-regulator"; > + pse-supply = <®_t1l1>; > + #pse-cells = <0>; > + }; > + > + pse_t1l2: ethernet-pse-2 { > + compatible = "podl-pse-regulator"; > + pse-supply = <®_t1l2>; > + #pse-cells = <0>; > + }; > + > mdio0: mdio { > compatible = "virtual,mdio-gpio"; > #address-cells = <1>; > @@ -32,6 +44,24 @@ mdio0: mdio { > > }; > > + reg_t1l1: regulator-pse-t1l1 { > + compatible = "regulator-fixed"; > + regulator-name = "pse-t1l1"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + gpio = <&gpiog 13 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + reg_t1l2: regulator-pse-t1l2 { > + compatible = "regulator-fixed"; > + regulator-name = "pse-t1l2"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + gpio = <&gpiog 14 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > wifi_pwrseq: wifi-pwrseq { > compatible = "mmc-pwrseq-simple"; > reset-gpios = <&gpiod 8 GPIO_ACTIVE_LOW>; > @@ -92,6 +122,7 @@ t1l1_phy: ethernet-phy@7 { > reset-gpios = <&gpiog 12 GPIO_ACTIVE_LOW>; > reset-assert-us = <10>; > reset-deassert-us = <35>; > + pses = <&pse_t1l1>; > }; > > /* TI DP83TD510E */ > @@ -102,6 +133,7 @@ t1l2_phy: ethernet-phy@10 { > reset-gpios = <&gpiog 11 GPIO_ACTIVE_LOW>; > reset-assert-us = <10>; > reset-deassert-us = <35>; > + pses = <&pse_t1l2>; > }; > > /* Micrel KSZ9031 */