From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4241D1B3F22 for ; Mon, 9 Sep 2024 13:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725888047; cv=none; b=UGMERQWngKbE7lsQSCcoLnl70E5Xcv9gfisVBsaRlyIgPPg0Gs/qb+h47tr1Qwu+n8dfURLPj3CHUWrHgzFIBEK2VJL7jUU9QiATXvovl74Rj8iaWjjjRo6j8tIz7PbR1fi6cCXxoRp4kzb6RrAas7j8CB5eL1CD+VaEiZzgweo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725888047; c=relaxed/simple; bh=funbdZ7K3B2+UFHyR9wWdMOsW0n+5ztnXHtMLhU8ypQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UIO5dB67ZZZvNRijB5d05YyzilXtwZ4wEkeLLcUbVotfqs/3YPsgolXRZcrRTNL2AVUCg2MGz8zXdXw+V9jm3PPGcqDKNN3hlp4Xl7e1XINgiEn7cbpoZzT/cGT31BfG5kDpRgfZ0WAYINhvP94ilKTx6dfpOTmgkzO+BFKIFmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=vQ4ch1Lw; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="vQ4ch1Lw" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4582face04dso7789151cf.1 for ; Mon, 09 Sep 2024 06:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725888044; x=1726492844; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=funbdZ7K3B2+UFHyR9wWdMOsW0n+5ztnXHtMLhU8ypQ=; b=vQ4ch1LwwodgsYVcX4Vsry9p0aCs6yTDzTXyez9m3eF/rODZieVAp1Zin/LiPcTRS6 bga+CdEVhJjD816afCmx47qnl32WwDjWlX9zgemRPveasSPO6HrlP9HOAtd8j+70NbF/ vhnU3RKQAFfHdOSD29/GgGJh0nneqkJJ2a18sa4lbPhipWS3VSVFUURHCqFTxdHGnLJZ WYPVZq1KthfXvroRS3EBeKG4UU+jimMLgqttRkyF4jq4CL9CaCo/oRLJtjNfJZJVEgrh x9kiG9IU3D95EFTYs+V8Gh9ypX1UKjxcTPlf7LJISMf/JkA9dPVoVSK7hqUODgjl2i77 Xk7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725888044; x=1726492844; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=funbdZ7K3B2+UFHyR9wWdMOsW0n+5ztnXHtMLhU8ypQ=; b=iYrQ8HQLUcQZ28vycX1rdmfKxMvWsogH/hlV6Vp0x6vkm6SI6tJvsHIbQwrahaiWzm vD3T0/uaVD/xZIK60eTo8V4VpN+rZH0rquv9CEg/uT3PTe3Px53ASGLrOVX7+P/tS6+x vpXsPBN2YdpcEGjMQ3YHY1AYB3VwAoVoSa7v16tuheoMrZMY6uNogPFVZ4hk722jq5Hs +mbSn1/AuxK2Ukv7Lt84Ys+xETqUrESMEIkVBhOjCPyz9uAu49EOx9FX0G4+2vMumJKG 0w/RoR4rQT5udGEpttAD0/7RDVHYTi5cgSBTEZUtpfPIXapeFdmDto2PLOTFfAdvvQj0 xsrA== X-Forwarded-Encrypted: i=1; AJvYcCWMlE+aGY88mFga2yBB/F/57HVNVyafZUn34Tsylyy8MXJqPhNTyW7y+BVNXZRssH1QnZ7yE/A4N/vn@vger.kernel.org X-Gm-Message-State: AOJu0YzOmM6FOIlPl98EQYMmkwsj7LPyB4Nl2ES/iycAsmNedKC8TCPH AnqFWxjZNYwo5GCMZifHPfW6TVm8pkyzciXeaHXMACKFxDbE9z9L+BwMw38pgDM= X-Google-Smtp-Source: AGHT+IHUG75g9oGUnKbTzwMVD6YxVdew6Qh2TdgFpABqIP1nWkZsjBLY2UDr9LgWMYU21eDVdnM9XQ== X-Received: by 2002:a05:622a:178b:b0:446:54f5:3181 with SMTP id d75a77b69052e-457f8c63a2cmr308591541cf.24.1725888043915; Mon, 09 Sep 2024 06:20:43 -0700 (PDT) Received: from [192.168.40.12] (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45822e6152asm20205051cf.4.2024.09.09.06.20.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2024 06:20:43 -0700 (PDT) Message-ID: <1a3e9f90-b5f9-4c12-9ec9-a61f14604b64@baylibre.com> Date: Mon, 9 Sep 2024 09:20:40 -0400 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] iio: adc: ad7625: add driver To: Jonathan Cameron Cc: Lars-Peter Clausen , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , David Lechner , Uwe Kleine-Konig , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20240904-ad7625_r1-v4-0-78bc7dfb2b35@baylibre.com> <20240904-ad7625_r1-v4-2-78bc7dfb2b35@baylibre.com> <20240908125905.19852719@jic23-huawei> Content-Language: en-US From: Trevor Gamblin In-Reply-To: <20240908125905.19852719@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-09-08 07:59, Jonathan Cameron wrote: > On Wed, 04 Sep 2024 15:14:19 -0400 > Trevor Gamblin wrote: > >> Add a driver for the AD762x and AD796x family of ADCs. These are >> pin-compatible devices using an LVDS interface for data transfer, >> capable of sampling at rates of 6 (AD7625), 10 (AD7626), and 5 >> (AD7960/AD7961) MSPS, respectively. They also feature multiple voltage >> reference options based on the configuration of the EN1/EN0 pins, which >> can be set in the devicetree. >> >> Signed-off-by: Trevor Gamblin > I took another look and LGTM (subject to the other review responses) Thank you. I'll have a v5 for review shortly to address those. > > > Jonathan