From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Adamski <krzysztof.adamski@nokia.com>,
Jean Delvare <jdelvare@suse.com>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 09/10] hwmon: (tmp421) ignore non-channel related DT nodes
Date: Tue, 12 Oct 2021 07:44:25 -0700 [thread overview]
Message-ID: <1a45d1fe-f387-333b-bf73-dfe2b3faadf4@roeck-us.net> (raw)
In-Reply-To: <8835efd6cc7ce6791056b7fbce92a16f72d63598.1634029538.git.krzysztof.adamski@nokia.com>
On 10/12/21 2:30 AM, Krzysztof Adamski wrote:
> In case the DT contains some nodes not describing the input channels,
> ignore them instead of exiting with error.
>
> Signed-off-by: Krzysztof Adamski <krzysztof.adamski@nokia.com>
For my reference:
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/tmp421.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
> index 133eca1f2650..d44112fe2a14 100644
> --- a/drivers/hwmon/tmp421.c
> +++ b/drivers/hwmon/tmp421.c
> @@ -411,6 +411,9 @@ static int tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *d
> int err;
>
> for_each_child_of_node(np, child) {
> + if (strcmp(child->name, "channel"))
> + continue;
> +
> err = tmp421_probe_child_from_dt(client, child, data);
> if (err)
> return err;
>
next prev parent reply other threads:[~2021-10-12 14:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 9:14 [PATCH v4 00/10] Add per channel properies support in tmp421 Krzysztof Adamski
2021-10-12 9:14 ` [PATCH v4 01/10] dt-bindings: hwmon: add missing tmp421 binding Krzysztof Adamski
2021-10-12 9:26 ` [PATCH v4 02/10] hwmon: (tmp421) introduce a channel struct Krzysztof Adamski
2021-10-12 14:25 ` Guenter Roeck
2021-10-12 9:27 ` [PATCH v4 03/10] hwmon: (tmp421) add support for defining labels from DT Krzysztof Adamski
2021-10-12 14:30 ` Guenter Roeck
2021-10-12 9:27 ` [PATCH v4 04/10] hwmon: (tmp421) support disabling channels " Krzysztof Adamski
2021-10-12 14:32 ` Guenter Roeck
2021-10-12 9:28 ` [PATCH v4 05/10] hwmon: (tmp421) support specifying n-factor via DT Krzysztof Adamski
2021-10-12 14:34 ` Guenter Roeck
2021-10-12 9:29 ` [PATCH v4 06/10] hwmon: (tmp421) really disable channels Krzysztof Adamski
2021-10-12 14:37 ` Guenter Roeck
2021-10-12 18:01 ` kernel test robot
2021-10-13 8:36 ` Dan Carpenter
2021-10-13 18:50 ` kernel test robot
2021-10-12 9:29 ` [PATCH v4 07/10] hwmon: (tmp421) support HWMON_T_ENABLE Krzysztof Adamski
2021-10-12 14:43 ` Guenter Roeck
2021-10-12 9:30 ` [PATCH v4 08/10] hwmon: (tmp421) update documentation Krzysztof Adamski
2021-10-12 14:43 ` Guenter Roeck
2021-10-12 9:30 ` [PATCH v4 09/10] hwmon: (tmp421) ignore non-channel related DT nodes Krzysztof Adamski
2021-10-12 14:44 ` Guenter Roeck [this message]
2021-10-12 9:30 ` [PATCH v4 10/10] dt-bindings: hwmon: allow specifying channels for tmp421 Krzysztof Adamski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a45d1fe-f387-333b-bf73-dfe2b3faadf4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.adamski@nokia.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).