From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BD5B17B50F; Thu, 3 Oct 2024 12:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727958683; cv=none; b=OO8UDyW8OMVzqmtqG2lZ4+MyVlkaY6//uA62GnOVrJPsQN2k2htPoKWb7TPKnh+Y1VUy703ib4z4RUzQJ0/ZWu9J/DdtlUKULXRFR4OqRqffxERXvZ2nv6iazAP38vuOuwj/yivhXnWbEwiwr7i2vOh1spWvcbgZx9mQk3BxaRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727958683; c=relaxed/simple; bh=sBx43VYE9QJ8TXOR3GfhsMFFV3mHcQGwhJaH6FV7LO4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X4uoFwn56po42rk3kEKQi/dPNaxb6ZA3AAEumUGVnBJG6pndmYOfPy6jNoXM7U2U4sglvJz5CTzvSAbU7I4uFnZGr5hw2IszonY+u3qlljfFQUOLS3EV1StSavLhLdxCXno9zDOJISeHDwHLcOrWizfMIiu0yuzQJRUB9b9TnXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BhorNhrS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BhorNhrS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8848AC4CECE; Thu, 3 Oct 2024 12:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727958683; bh=sBx43VYE9QJ8TXOR3GfhsMFFV3mHcQGwhJaH6FV7LO4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BhorNhrSIRLNF7NHkfPCsrafjVomnhEPRKwZEppSEk/wNzV2+4J5xfpD/GI6gYG/3 hse2HBCl4qGIdIBztHE432fhNKuk6C8ZpFfyOeTQoGUe1WzrtwIuPf92XGgJU7N0+O ulznWTyZoNReY2pPunSdo2KH5nbi4enqcE6xEzb0SRgUanIPcZb42hmllCpr4C0zdH vVstLeSyW4hkVhgYuzNlygm4xHmga+QIi4Qea9NYV1pryn7de8FJeJUCVbibfcf8ej K7cpqKiSoG/7FejDX6GCoNr31XP8P+xJNFwgy33jhzek7gtWKIAfVrFpq9W+nfAowk hTz/4MORa1FRg== Message-ID: <1a4e5aa6-2308-41de-94e7-0077cb265b6d@kernel.org> Date: Thu, 3 Oct 2024 14:31:17 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] media: dt-bindings: Add OmniVision OV08X40 To: Sakari Ailus , Bryan O'Donoghue Cc: Jason Chen , Mauro Carvalho Chehab , Sergey Senozhatsky , Hans Verkuil , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20241002-b4-master-24-11-25-ov08x40-v3-0-483bcdcf8886@linaro.org> <20241002-b4-master-24-11-25-ov08x40-v3-2-483bcdcf8886@linaro.org> <8554d372-18cb-4351-a5ab-894be09c613b@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 03/10/2024 14:17, Sakari Ailus wrote: > Hi Bryan, Krzysztof, > > On Thu, Oct 03, 2024 at 12:54:41PM +0100, Bryan O'Donoghue wrote: >> On 03/10/2024 11:17, Krzysztof Kozlowski wrote: >>> On 03/10/2024 10:38, Bryan O'Donoghue wrote: >>>> On 03/10/2024 09:33, Bryan O'Donoghue wrote: >>>>> On 03/10/2024 09:29, Krzysztof Kozlowski wrote: >>>>>> On Wed, Oct 02, 2024 at 02:58:44PM +0100, Bryan O'Donoghue wrote: >>>>>>> +        properties: >>>>>>> +          data-lanes: >>>>>>> +            oneOf: >>>>>>> +              - items: >>>>>>> +                  - const: 1 >>>>>>> +                  - const: 2 >>>>>>> +              - items: >>>>>>> +                  - const: 1 >>>>>>> +                  - const: 2 >>>>>>> +                  - const: 3 >>>>>>> +                  - const: 4 >>>>>>> + >>>>>>> +          link-frequencies: true >>>>>> >>>>>> Not much changed here and you did not continued discussion about it. >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>>> >>>>> >>>>> Ah my mistake, I didn't read the bit at the bottom of your email >>>> >>>> I'll do this >>>> >>>> Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml >>>> >>>> data-lanes: >>>> description: >>>> This property is for lane reordering between the THP7312 >>>> and the SoC. The sensor supports either two-lane, or >>>> four-lane operation. >>>> If this property is omitted four-lane operation is >>>> assumed. For two-lane operation the property must be >>>> set to <1 2>. >>>> minItems: 2 >>>> maxItems: 4 >>>> items: >>>> maximum: 4 >>>> >>>> This captures what I'm after. >>> >>> I commented on link-frequencies. >>> >>> Best regards, >>> Krzysztof >>> >> >> Ah I understand you. >> >> You're saying the link-frequencies we have in >> Documentation/devicetree/bindings/media/i2c/* are redundant absent hardware >> specific link frequencies being enumerated. >> >> I'll either enumerate the acceptable set or drop this. > > link-frequencies should remain mandatory in bindings, whether there are > hardware specific limits in bindings or not. > Yep and my comment was not under required field. Why all this discussion is taken out of context? No wonder everyone interprets it differently. Best regards, Krzysztof