From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D914CC4332F for ; Wed, 2 Nov 2022 21:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231320AbiKBVLk (ORCPT ); Wed, 2 Nov 2022 17:11:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231278AbiKBVLk (ORCPT ); Wed, 2 Nov 2022 17:11:40 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 909A5DFBF for ; Wed, 2 Nov 2022 14:11:38 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id x18so1576511qki.4 for ; Wed, 02 Nov 2022 14:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SMdd6W9zqTykplxA9atF92tm5CBcUP1U7yvf5vUxJ94=; b=qB3heRMEENXq8LFOVv7rITGt3zC5JeYlR5KthvYqttf4k6cy+wq7eT+G5PU0Y1gk+T hIDyJ8EDJGC4oefNczl6sxRZJYwkHx7zYy0szk3EL69mVeSGtEEgYnxqWp1eJAqGUtDD FzvCzCNYtJKaplARHRsXpCDCC/UuQgXbAqcA45tzUMB+KOnfLMBtdvJCUfKBMUfT+F1r C6yUhosIbNAemIdWXHBCwCI1WMUJo/j4cJyUvfJvPQZrBI1zf/cBQehcdITcpYrDiyeD L6tOkEedAVUpFSq63IEZskKrZ/HwskotE8pb/OT0LprAO9P7dw5nUXd7C51ynN90uOQQ cqMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SMdd6W9zqTykplxA9atF92tm5CBcUP1U7yvf5vUxJ94=; b=58fdroRijUsvx5LPTcDsMvwVEjewsYr5dULSdwjlaKg9cpNK0kWTRqOQOJTnARqvR+ oDHqj0bbEsziWIHKX93N2uHD+WwIgE1lUqKQ6S3CXPr1y6YZrvcWq15aamBWBNS5tRKR Dtb/8Lz46zJtXlyr38HWq9nMKkaqNGY6PwuL8oIJMDVw3zytz8NEzToKGClvf8Krbitp DbjDlSW1xyDuQsSxFUyHj+PAQdePLAsya+3zMcfVTgn/s4pCXAljt9CMFRlFn9sj8plE wrviDAg6kk84isTydi4YL+L975rZMi6jjEMU4q/NxMQ2ZT5aDv8ko2PlI26hBsL0wlzi fdGw== X-Gm-Message-State: ACrzQf2/ZclSJ5P0V7F9akcSVJiwjZ51wh8iU0ezEhmbJLmrtgLt9Bag heGvXtgnihQGNBdMRG13I3pocg== X-Google-Smtp-Source: AMsMyM6Wkzj6KTSaNv+AilpDqn1fSqGn/N2Li1l/svMXz1ljJSNXtiq4HeywPXe80VDgV4C1XUmDFQ== X-Received: by 2002:a37:ef05:0:b0:6fa:630:2b4f with SMTP id j5-20020a37ef05000000b006fa06302b4fmr19416018qkk.41.1667423497764; Wed, 02 Nov 2022 14:11:37 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:28d9:4790:bc16:cc93? ([2601:586:5000:570:28d9:4790:bc16:cc93]) by smtp.gmail.com with ESMTPSA id h10-20020ac846ca000000b0039853b7b771sm7139821qto.80.2022.11.02.14.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 14:11:37 -0700 (PDT) Message-ID: <1a7fd1fd-4f0d-bec3-ddd5-7c6a99a2ab01@linaro.org> Date: Wed, 2 Nov 2022 17:11:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v3 1/3] dt-bindings: interconnect: Remove required reg field Content-Language: en-US To: Melody Olvera , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski Cc: Odelu Kukatla , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221026190520.4004264-1-quic_molvera@quicinc.com> <20221026190520.4004264-2-quic_molvera@quicinc.com> <64d0e5ef-fd36-6f25-2c39-00e8e1346af7@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <64d0e5ef-fd36-6f25-2c39-00e8e1346af7@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/10/2022 19:29, Melody Olvera wrote: > > > On 10/27/2022 8:29 AM, Krzysztof Kozlowski wrote: >> On 26/10/2022 15:05, Melody Olvera wrote: >>> Many of the *-virt compatible devices do not have a reg field >>> so remove it as required from the bindings. >> and some virt have it... This should be probably separate binding or if >> the list is small - allOf:if:then. > I attempted this; however I'm still seeing failures in dtb_check. I've added this > to the binding; does this look correct? >  allOf: >    - $ref: qcom,rpmh-common.yaml# > +  - if: > +      properties: > +        compatible: > +          contains: > +            enum: > +              - qcom,qdu1000-clk-virt > +              - qcom,qdu1000-mc-virt > + > +    then: > +      required: > +        - compatible No, because we talk about reg, not compatible. You should not require reg instead for some compatibles... but then the schema is getting complicated. It's difficult to give you recommendation because I do not know what are all these "virt" interconnects. Why some have unit address, why some do not? Best regards, Krzysztof