Re: [PATCH v2 08/10] drm/bridge: imx8mp-hdmi-tx: add an hdmi-connector when missing using a DT overlay at boot time

Liu Ying
2026-04-02T04:04:57Z

Hi Luca,

On Mon, Mar 30, 2026 at 09:25:49PM +0200, Luca Ceresoli wrote:

[...]

> Changes in v2:
> - don't apply the overlay if the SoC is not i.MX8MP
> - build unconditionally, but depend on DRM_IMX_LCDIF
> - remove useless error check
> - add missing cleanup.h and init.h includes, remove unneeded includes
> - avoid dtc warnings on overlay
> - fix typo in Kconfig help text
> - not added the Tested-bys because the code has changed
> - split the 'plat_data->output_port = 1' line to a separate patch

v2 also changes commit mesg.

[...]

> +static int __init imx8mp_hdmi_tx_connector_fixup_init(void)

[...]

> + return of_overlay_fdt_apply(dtbo_start, dtbo_size, &ovcs_id, NULL);

Kernel doc of of_overlay_fdt_apply() says:

* On error return, the changeset may be partially applied. This is especially
* likely if an OF_OVERLAY_POST_APPLY notifier returns an error. In this case
* the caller should call of_overlay_remove() with the value in *@ret_ovcs_id.

Need a bailout?

--
Regards,
Liu Ying