Re: [PATCH v2 04/10] drm/mxsfb/lcdif: lcdif_attach_bridge: move iteration-specific variables declaration inside loop

Liu Ying
2026-04-02T03:56:36Z

On Mon, Mar 30, 2026 at 09:25:45PM +0200, Luca Ceresoli wrote:
> The bridge and ret variables are per-iteration variables, whose values
> don't have to be carried to the next iteration or be used after the loop
> end. Move their declaration inside the loop scope as a cleanup and to make
> code clearer.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> ---
>
> This patch is new in v2
> ---
> drivers/gpu/drm/mxsfb/lcdif_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Nit: change subject to:
drm/mxsfb/lcdif: move iteration-specific variables declaration inside loop in lcdif_attach_bridge

Reviewed-by: Liu Ying <victor.liu@nxp.com>

--
Regards,
Liu Ying