From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ninad Naik <ninadnaik07@gmail.com>
Cc: lee@kernel.org, pavel@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
simon.guinot@sequanux.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
me@brighamcampbell.com, linux-kernel-mentees@lists.linux.dev,
skhan@linuxfoundation.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3] dt-bindings: leds: lacie,ns2-leds: Convert to DT schema
Date: Tue, 28 Jul 2026 11:57:35 +0200 [thread overview]
Message-ID: <1a96515b-5f6a-4f0d-81d3-2640f7a3b7c8@kernel.org> (raw)
In-Reply-To: <b004a0f5-1dcd-4d40-84c7-33108eb20395@gmail.com>
On 28/07/2026 10:37, Ninad Naik wrote:
>
> On 28/07/26 1:24 pm, Krzysztof Kozlowski wrote:
>> On Fri, Jul 24, 2026 at 09:53:32PM +0530, Ninad Naik wrote:
>>> Convert lacie,ns2-leds to DT schema.
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/r/202607231542.6ovJrInT-lkp@intel.com/
>> Drop both. You need to read that report again.
> Sorry, I missed the line which says not to include the tags in a new
> version of the same patch. Will remove.
>>
>>> Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
>>> ---
>>> Changes in v3:
>>> - Add optional property num-modes to the schema.
>> Missing rest of the changelog.
>>
>> What happened here?
>>
>> Rest looks good, so with dropping incorrect tags (really, please read
>> the email you received):
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Should I carry over this tag in v4?
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here ('b4 trailers -u ...'). However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for tags received on the version they apply.
Full context and explanation:
https://elixir.bootlin.com/linux/v6.15/source/Documentation/process/submitting-patches.rst#L591
Best regards,
Krzysztof
prev parent reply other threads:[~2026-07-28 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 16:23 [PATCH v3] dt-bindings: leds: lacie,ns2-leds: Convert to DT schema Ninad Naik
2026-07-24 16:36 ` sashiko-bot
2026-07-28 7:54 ` Krzysztof Kozlowski
2026-07-28 8:37 ` Ninad Naik
2026-07-28 9:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a96515b-5f6a-4f0d-81d3-2640f7a3b7c8@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkp@intel.com \
--cc=me@brighamcampbell.com \
--cc=ninadnaik07@gmail.com \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=simon.guinot@sequanux.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox