From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
nfraprado@collabora.com, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev, mingyuan.ma@mediatek.com,
yf.wang@mediatek.com, libo.kang@mediatek.com,
Yunfei Dong <yunfei.dong@mediatek.com>,
kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>,
chengci.xu@mediatek.com, youlin.pei@mediatek.com,
anan.sun@mediatek.com
Subject: Re: [PATCH 07/10] iommu/mediatek: Add a gap for the iova regions
Date: Mon, 16 Jan 2023 10:46:16 +0100 [thread overview]
Message-ID: <1a9a09d5-58e2-badc-6d1c-fe2008c305f9@collabora.com> (raw)
In-Reply-To: <20230113060133.9394-8-yong.wu@mediatek.com>
Il 13/01/23 07:01, Yong Wu ha scritto:
> Currenly masters can not indicate its special dma-ranges. Prepare
> for vcodec. some vcodec end address is address + size, if our size
> is 4G, the end address may be 0x2_0000_0000. and the
> register is u32, then it may get zero. thus add a gap(8M) for
> all the regions.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
I definitely agree on the fact that we do *need* this series... but this
particular commit looks like a hack.
I'm not convinced: I have a hunch that this one will sooner or later backfire
on us and break things again... at the same time, I'm not sure how to do this
properly at this point (I didn't do any research, anyway).
Ideas?
Regards,
Angelo
next prev parent reply other threads:[~2023-01-16 9:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 6:01 [PATCH 00/10] Adjust the dma-ranges for MTK IOMMU Yong Wu
2023-01-13 6:01 ` [PATCH 01/10] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property Yong Wu
2023-01-13 8:25 ` Krzysztof Kozlowski
2023-01-16 8:01 ` Yong Wu (吴勇)
2023-01-16 8:06 ` Krzysztof Kozlowski
2023-01-16 9:16 ` Yong Wu (吴勇)
2023-01-17 10:44 ` Krzysztof Kozlowski
2023-01-16 9:47 ` AngeloGioacchino Del Regno
2023-01-13 6:01 ` [PATCH 02/10] dt-bindings: media: mediatek,jpeg: " Yong Wu
2023-01-16 9:47 ` AngeloGioacchino Del Regno
2023-01-13 6:01 ` [PATCH 03/10] iommu/mediatek: Get regionid from larb/port id Yong Wu
2023-01-13 6:01 ` [PATCH 04/10] iommu/mediatek: mt8195: Add larb_region_msk Yong Wu
2023-01-13 6:01 ` [PATCH 05/10] iommu/mediatek: mt8186: add larb_region_msk Yong Wu
2023-01-13 6:01 ` [PATCH 06/10] iommu/mediatek: mt8192: " Yong Wu
2023-01-13 6:01 ` [PATCH 07/10] iommu/mediatek: Add a gap for the iova regions Yong Wu
2023-01-16 9:46 ` AngeloGioacchino Del Regno [this message]
2023-01-17 2:53 ` Yong Wu (吴勇)
2023-02-14 5:33 ` Yong Wu (吴勇)
2023-01-13 6:01 ` [PATCH 08/10] arm64: dts: mt8195: Add dma-ranges for the parent "soc" node Yong Wu
2023-01-16 9:47 ` AngeloGioacchino Del Regno
2023-01-13 6:01 ` [PATCH 09/10] arm64: dts: mt8195: Remove the unnecessary dma-ranges Yong Wu
2023-01-16 9:47 ` AngeloGioacchino Del Regno
2023-01-13 6:01 ` [PATCH 10/10] arm64: dts: mt8186: Add dma-ranges for the parent "soc" node Yong Wu
2023-01-16 9:47 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a9a09d5-58e2-badc-6d1c-fe2008c305f9@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=anan.sun@mediatek.com \
--cc=chengci.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyrie.wu@mediatek.corp-partner.google.com \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mingyuan.ma@mediatek.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).