From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C081F3D88F7 for ; Tue, 1 Sep 2026 01:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788227575; cv=none; b=WBCzXpTQkly9E3ITrlLVN3RhXXzNShlIzxwlimm5jtGuR7LbVXKyndaU1mltw/nRLJSkDV8muy6Enw/KT9Js1x7hgDG5gDQ1qezZdU4UgoqaR+tdtpRKA/A1STtcT0YYe8YTQBP1Xktqnb70Epp59B4d6PFcLAYYuqPHo5ptMOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788227575; c=relaxed/simple; bh=VUwZU7jWoZ6qeQcd5+n/BQiIogXblzniZHsikRu0mN8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fk6+ulC4LOW72ocrZtH6ojqzkDv1201Y+Db5YUfVl9WdkzwjgAVI4vLjKSa4cK+PYBy2a/aFsm7QsjizIdKkzCq2HapIYQVIT6RspneAUU0B30YyCHvHo+EmAXU/vTUD1jT5dsAGcpsW+7xDc/tH1g/N/kwc1jxzB3uXJ22rGOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F4UdnJWs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I5h82XV+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F4UdnJWs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I5h82XV+" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6810ofMQ1139598 for ; Tue, 1 Sep 2026 01:52:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HthPli1doBJ3r78ciQ2kNfx7Zf0urz5E+Lq2coHiadY=; b=F4UdnJWse8Wo6ew5 R6u37rQSAUg0/2vPiAvQmwnmK1KhIW53x4xtnPG4+5WSClh3+na15cFmAu9ury3+ xosxq2M7PmHFyCdM1y7+n1ECcoFD/RGSz1COfySCRBYZvMV7fIfChLZpCX+pJqLc Tolh1S/6n3lpjDrL+PUlugd7UArkgzjn5ytAFvb3pCWAaW4KKC+GbKHjIyatalV9 QDhvPnF4yr7XSO26LKCjt8r76FqU75HLHWLvMOkSafg632ZvVAVpRXYNihYdYxLJ cm5k0rRs9PD9b0afbIrEO90UqVgdO8LcY6h2pRVuvvfwi0fMdeJQrVTF7OIO5VaP eStxPA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gd6h947bc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 01 Sep 2026 01:52:17 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38f97b3f853so7173579a91.3 for ; Mon, 31 Aug 2026 18:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788227537; x=1788832337; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=HthPli1doBJ3r78ciQ2kNfx7Zf0urz5E+Lq2coHiadY=; b=I5h82XV+5FkrQJrGanJ9O4nMA/a4fLbkrC6fVQ3Ay7yfKIHuA+syE1CUbqnSh1v3JU Lrza5TR++Pr2U9o+IaOY8mUeC/gbMmeBwVZOqHg+Zee7uJqr3W0VTt2kj9bZGD0T92BA uYeOFBWYAwgqdHy7o5jkrfoMCctsSrKIWq/XpN7lsC4eFKyPy1zDlS0pN3aIiiX6T2XA /RVSeYQTi6YJypH26Cn+MPeDlKEzh5rwFW15qQNGQf1scG1z+E5hFFEVTvp1eDsI2wQK av6zgFKx7a0wWRHn06MdCGoaxDegHM4xXO2vxE0fUWjFynpGiudEEhNzQlCNM13ZI0Va pt0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788227537; x=1788832337; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HthPli1doBJ3r78ciQ2kNfx7Zf0urz5E+Lq2coHiadY=; b=EuEYaH0R4CcXTAc6rCWCQTETl40ZnenuicvdDzksxKUAfrZpTYpBAUrnRXebolRC4j qLqeuhWMMpHLgAT4ltA97+GizC8+6UAo9XBvqpJ2RbZUlleWbJHzH1K39B+cDyG6bvdi YeX7O5fGVZ/r3beKYONFTz/RzFTpm/o0O+yWRsmRzvJYzvY1A0/AAxDsmSb5kSyMDW0D Dicc3HajTWeKV7KLK4pNlYPogQJ2geBGFVRjClg1LljfSlzhEhJ0B7ItcuCyB0yxjp6z W81h+dJpE8y3f+LJLGnShdsrzRUfDBX5uzf3acpxBYBsZHDP2sAfh3ZVmN9zrlDzFu6+ 3gJg== X-Forwarded-Encrypted: i=1; AKwUvBweVa1Wzd/vl7MK515qUtd1B0reE2+3VCuMWUjWTS2UCiGDjdIqJkTS3v3KAokQAJRYmVRE3Luqug1E@vger.kernel.org X-Gm-Message-State: AFuF++mahgixSuKGeXgLvMv45VZQrg0xCTA8mq30avVCUwxuczZFWjgZ 6ftKSgc8+2J6rEnqYEXymLrlDdjhfAWxXnW0b5nX4idy1uY2Pq0bVK5qgm9/z+AfZ1AspoqX/Hj jrxdBKP4EJ3HRSZo8I5wPFzoNvD3utEqDWEz49nI2DzLhvAZILZywSQ9DjcNnDCVz X-Gm-Gg: AYBFou0OUx5led2D9hje1SM7/9gIOU/ThVhU8A52K5KjGA91M43/5DtGHc6onbT/i+8 vosoFmWgfQIRgwT/Rb1DlK+utsLx6LlnN0YKBL0Tm/X/Fp4LM/HAS6TpKf1GVVOOwUqXscl7MKL vV2+vvMi/SyeR88tt1bvfZm/PhNQSllrAqX+b4EOhowwy+qK3B8Zzx8NXYJ9RYFKPgAE7QkvGZM 83ledQPZwD98zuxaKgaFeENQQaGklWfFq2GKiIhRwpDpVJddg2rZ8fhp38s2E6j2uoWG2jN4b1z 1GFY7QOowhuchEkTn1xtNXcxOuE5svZYgbUP1b7hsBjRtin1Gch4Hi3mUn6mhi/DJ5oYb+ncC5F 0/Vl+Tk4SAYkP8Z8WIII6AJrIxbw9zw2vjroOKK0LUDFz/Ix7ujPtfqzJbdm54tcVUCaSzhRY X-Received: by 2002:a17:90b:184d:b0:398:9c00:29ed with SMTP id 98e67ed59e1d1-3989c003c3cmr33405061a91.21.1788227536776; Mon, 31 Aug 2026 18:52:16 -0700 (PDT) X-Received: by 2002:a17:90b:184d:b0:398:9c00:29ed with SMTP id 98e67ed59e1d1-3989c003c3cmr33404983a91.21.1788227536255; Mon, 31 Aug 2026 18:52:16 -0700 (PDT) Received: from [10.133.33.22] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3990bcf8079sm2709695a91.1.2026.08.31.18.52.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Aug 2026 18:52:15 -0700 (PDT) Message-ID: <1a9f2e1d-163d-46bd-ab40-03491786b962@oss.qualcomm.com> Date: Tue, 1 Sep 2026 09:52:11 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] wifi: ath12k: support calibration-variant from device tree To: Jeff Johnson , Andrew LaMarche , Johannes Berg , Jeff Johnson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, Ernest Van Hoecke References: <20260630133001.1426824-1-andrewjlamarche@gmail.com> <9e22e5ec-70b3-4ec9-ae75-295fc13a23a7@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <9e22e5ec-70b3-4ec9-ae75-295fc13a23a7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=W6UIkxWk c=1 sm=1 tr=0 ts=6a962fd1 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=Ggg6OIdO8VovxE8tBwMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: PCg4vpSQuZld12gK8d7wHhWkJyYN7Q_n X-Proofpoint-GUID: PCg4vpSQuZld12gK8d7wHhWkJyYN7Q_n X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAxMDAxNCBTYWx0ZWRfX/+Li8efsBTVm CEgM1g4X9p2yAh6EF1Mu/AhrGumB5jz9hWpxiB8VByli5shJmG/SyA2X2uCE3aV1nvwIYUBhUor qcALPR4FogprO5bgje6qTKJQwSf7QeA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAxMDAxNCBTYWx0ZWRfX7+LVDEf/Pqea gRkN9QW4UCXKIpTjvlHvR+HJKrBxv0b+sk54IeM8SNPgns+/1IfaZM/nP7fLLeCe9YZz8mK9EH9 nuFNdxJ6xxWCa4ZR/gM1/Y+Pz9fInCul5SUZ1MLrRzXe6Lb+Kov4jMl+TrDcAD1ozwjEB3kz5wl feQx2f+PR9KH0+SDNR0wLTBLxYDqd2qFCzTnUS9HbnUh72cx0C11iXwwUdZXpDHjAgUCQ5/MZW3 ohYOYjy0ztwUeumByb9IRiml1pbnnUqIV6V6XbA0lJyX9104tFtsgxjabCSbCvYXKJmhBDgov8d 6DNRPiUV1bkkpvDBVCYsiRPquAOCW4aHMrXU2aU5cXPiqjl2EtanzeSiWcMSuuRQEQse99vq3cu LTQ/pb4dNgmhGo0thM07GjlwA3v7rJ5xxGEyC0zfDoE+9xEx3gVgVfxf0P5+dtOBNOVYARyaH0Y Q2aiQE8pBgSHYAeRlpw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-01_01,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1011 phishscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609010014 On 9/1/2026 4:09 AM, Jeff Johnson wrote: > On 6/30/2026 6:30 AM, Andrew LaMarche wrote: >> +int ath12k_core_check_dt(struct ath12k_base *ab) >> +{ >> + size_t max_len = sizeof(ab->qmi.target.bdf_ext); >> + const char *variant = NULL; >> + struct device_node *node; >> + >> + node = ab->dev->of_node; >> + if (!node) >> + return -ENOENT; >> + >> + of_property_read_string(node, "qcom,calibration-variant", > > I've fixed the following in the pending branch: > ● checkpatch.pl: 126: CHECK: Alignment should match open parenthesis > >> + &variant); >> + if (!variant) >> + return -ENODATA; >> + >> + if (strscpy(ab->qmi.target.bdf_ext, variant, max_len) < 0) >> + ath12k_dbg(ab, ATH12K_DBG_BOOT, >> + "bdf variant string is longer than the buffer can accommodate (variant: %s)\n", variant); > > Also: > ● checkpatch.pl: 132: WARNING: line length of 121 exceeds 100 columns > ● checkpatch.pl: 132: CHECK: Alignment should match open parenthesis > > https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?id=c9d2d0d1c4a0faaba5f57e3c3350707db9f4f3f3 looks good to me. > >> + >> + return 0; >> +} >> + >