Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux@divinehawk.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Mathias Nyman <mathias.nyman@intel.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: xhci: add xhci-no-soft-retry-quirk
Date: Fri, 28 Aug 2026 14:39:51 +0200	[thread overview]
Message-ID: <1aa6d82a-0d35-45a4-9ebd-1c3d8929e611@kernel.org> (raw)
In-Reply-To: <20260828-xhci-no-soft-retry-v1-1-b9c264b56601@divinehawk.com>

On 28/08/2026 14:37, Matt Eaton via B4 Relay wrote:
> From: Matt Eaton <linux@divinehawk.com>
> 
> Document the xhci-no-soft-retry-quirk property, added in the
> following patch.
> 
> snps,dwc3-common.yaml refs usb-xhci.yaml for every dr_mode other than
> peripheral, so a host-mode dwc3 node inherits it and dt_binding_check
> accepts it there.

I do not understand how this sentence is relevant. Please describe the
hardware needing this.


> 
> Signed-off-by: Matt Eaton <linux@divinehawk.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.yaml b/Documentation/devicetree/bindings/usb/usb-xhci.yaml
> index 4238ae896ef6..5d67a41658f7 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.yaml
> @@ -25,6 +25,10 @@ properties:
>      description: Set if the controller has broken port disable mechanism
>      type: boolean
>  
> +  xhci-no-soft-retry-quirk:
> +    description: Set if the controller cannot perform xHCI Soft Retry correctly

Why isn't this implied by compatible? Looks like controller's property.


Best regards,
Krzysztof

  reply	other threads:[~2026-08-28 12:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 12:37 [PATCH 0/2] usb: xhci: add xhci-no-soft-retry-quirk Matt Eaton via B4 Relay
2026-08-28 12:37 ` [PATCH 1/2] dt-bindings: " Matt Eaton via B4 Relay
2026-08-28 12:39   ` Krzysztof Kozlowski [this message]
2026-08-28 13:18     ` Matt Eaton
2026-08-28 13:53       ` Krzysztof Kozlowski
2026-08-28 16:07         ` Matt Eaton
2026-08-28 17:50           ` Krishna Kurapati
2026-08-28 12:37 ` [PATCH 2/2] usb: xhci-plat: add xhci-no-soft-retry-quirk device property Matt Eaton via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1aa6d82a-0d35-45a4-9ebd-1c3d8929e611@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@divinehawk.com \
    --cc=mathias.nyman@intel.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox