From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>,
Conor Dooley <conor@kernel.org>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Walker Chen <walker.chen@starfivetech.com>,
Hal Feng <hal.feng@starfivetech.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, vkoul@kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support
Date: Thu, 4 May 2023 09:26:24 +0200 [thread overview]
Message-ID: <1ac26c1a-1726-515d-6598-849a07ed0b86@linaro.org> (raw)
In-Reply-To: <ea5b5534-8fc2-7c84-a011-c1b42c6ed7a0@starfivetech.com>
On 04/05/2023 09:20, Changhuang Liang wrote:
>
>
> On 2023/5/4 15:04, Krzysztof Kozlowski wrote:
>> On 04/05/2023 08:53, Changhuang Liang wrote:
>>>>> };
>>>>> };
>>>>>
>>>>> Add a "regmap" property which is phandle. And it can keep the present child-node
>>>>> structure. This is more consistent with our soc design.
>>>>
>>>> Adding property from child to parent does not make any sense. Didn't you
>>>> already receive comment on this?
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>> Krzysztof,
>>>
>>> I am confused about what to do next. How to add this power-controller's
>>> node in device tree?
>>>
>>
>> You just move power-domain-cells up.
>>
>> Best regards,
>> Krzysztof
>>
>
> Like this?
>
> aon_syscon: syscon@17010000 {
> compatible = "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu";
> reg = <0x0 0x17010000 0x0 0x1000>;
> #power-domain-cells = <1>;
> };
>
> If right? I will tell the syscon patch's owner delete the "simple-mfd" in aon_syscon node.
Yes, but your compatibles are now wrong. Just compatible =
"starfive,jh7110-aon-syscon", "syscon".
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-04 7:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 3:56 [RESEND v2 0/6] Add JH7110 AON PMU support Changhuang Liang
2023-04-19 3:56 ` [RESEND v2 1/6] dt-bindings: power: " Changhuang Liang
2023-04-19 18:29 ` Conor Dooley
2023-04-20 7:00 ` Changhuang Liang
2023-04-24 16:52 ` Conor Dooley
2023-04-25 3:41 ` Changhuang Liang
2023-04-25 6:59 ` Conor Dooley
2023-04-25 7:57 ` Changhuang Liang
2023-04-25 8:19 ` Krzysztof Kozlowski
2023-04-25 9:18 ` Changhuang Liang
2023-04-25 9:35 ` Conor Dooley
2023-04-25 12:26 ` Changhuang Liang
2023-04-25 16:56 ` Conor Dooley
2023-04-26 2:11 ` Changhuang Liang
2023-05-04 1:34 ` Changhuang Liang
2023-05-04 6:13 ` Krzysztof Kozlowski
2023-05-04 6:53 ` Changhuang Liang
2023-05-04 7:04 ` Krzysztof Kozlowski
2023-05-04 7:20 ` Changhuang Liang
2023-05-04 7:26 ` Krzysztof Kozlowski [this message]
2023-05-04 8:43 ` Changhuang Liang
2023-05-04 9:36 ` Krzysztof Kozlowski
2023-05-04 9:48 ` Changhuang Liang
2023-05-04 9:57 ` Conor Dooley
2023-05-05 1:29 ` Changhuang Liang
2023-05-05 12:38 ` Conor Dooley
2023-05-06 1:45 ` Changhuang Liang
2023-05-06 6:31 ` Krzysztof Kozlowski
2023-05-06 7:00 ` Changhuang Liang
2023-05-06 10:17 ` Conor Dooley
2023-05-06 12:26 ` Changhuang Liang
2023-05-06 12:29 ` Conor Dooley
2023-05-07 4:00 ` Changhuang Liang
2023-04-19 19:46 ` Krzysztof Kozlowski
2023-04-20 7:40 ` Changhuang Liang
2023-04-19 3:56 ` [RESEND v2 2/6] soc: starfive: Replace SOC_STARFIVE with ARCH_STARFIVE Changhuang Liang
2023-04-19 3:56 ` [RESEND v2 3/6] soc: starfive: Modify ioremap to regmap Changhuang Liang
2023-04-19 17:29 ` Conor Dooley
2023-04-20 6:03 ` Changhuang Liang
2023-04-19 3:56 ` [RESEND v2 4/6] soc: starfive: Extract JH7110 pmu private operations Changhuang Liang
2023-04-19 17:47 ` Conor Dooley
2023-04-21 3:27 ` Changhuang Liang
2023-04-21 6:57 ` Conor Dooley
2023-04-21 7:47 ` Changhuang Liang
2023-04-19 3:56 ` [RESEND v2 5/6] soc: starfive: Add JH7110 AON PMU support Changhuang Liang
2023-05-06 13:58 ` Shengyu Qu
2023-05-06 14:05 ` Conor Dooley
2023-05-06 14:07 ` Shengyu Qu
2023-05-06 14:12 ` Conor Dooley
2023-04-19 3:56 ` [RESEND v2 6/6] riscv: dts: starfive: jh7110: Add AON PMU node Changhuang Liang
2023-04-19 6:23 ` [RESEND v2 0/6] Add JH7110 AON PMU support Conor Dooley
2023-04-19 6:57 ` Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ac26c1a-1726-515d-6598-849a07ed0b86@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=changhuang.liang@starfivetech.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hal.feng@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=walker.chen@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).