From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D163FB060 for ; Mon, 6 Jul 2026 18:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783361501; cv=none; b=nVCRSlK29orilmn8fKwq3JJjiKxC8T9b/NB6woNXEDFCdvKRKQTCUj18Pf0bA67ZasuGZioxnzWHPiizbhf9Y0Y4KFfSA7aN2UobPY3+brErKNT+rxdtn6e4UYTmnoDWjbnsYTkkBH4K4No4nVZO5KoqWoqlXPCNWoR/ir++GHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783361501; c=relaxed/simple; bh=U4koz++ZA06ISm8vxFqnVpmFyDBe9iaAT7D7rWX0oR8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eO4sDJ3w/lc0JUEyTTN33mbNYA/xLDTSBXAltCDdfXTAbk7pBZpsl99FULKnbH+GupKvWqsnLwoAct836boCRzP6QwWw9oSiqmf4BMlsQm6GhaxKNomNKQIB2IoXeiW3gFme1CGoZ132MYYiTkpvltfPV7Ph+pdcZMzHy5VaYbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oyAoY2mD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OApJb2F8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oyAoY2mD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OApJb2F8" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666FFBx2900863 for ; Mon, 6 Jul 2026 18:11:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AdPbV9YRxG+cQo4afaZFPHUjWAQxmA2bvmATYgT6CTo=; b=oyAoY2mDnXL/VX8Z EBod0XnqCv7UgO1YwDq1XxWWC5SMRyo0RZF/U1lU6Igva/NONMIpSecUBdw+9xKC ujlK2eyCwPYcM5RE+IBvDP0AbFpbH6LsMftZY+CXk9Opnw9K+npEdRFjnLD2GlzH a8eHyq/q3yCaR//x8mS3bEGHi4Tykxv4CkT68rJoCiv6yf6Su9Nx4lGy0kFJimhd peP4f+JzySIWAQjy2gXu+DmbElL3DsGAEUO+fGeTfyRhnwQwsDy4fC4C3dgK6Vju 5dW/qVhBTz40Qr2iPGQvhBnLe70lCcQ5BaaNikIIXQxrTVr85EByRRBhYRKM1Bxy WcUULw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f87q7jwjf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 18:11:38 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e82060977so10212385a.1 for ; Mon, 06 Jul 2026 11:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783361498; x=1783966298; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AdPbV9YRxG+cQo4afaZFPHUjWAQxmA2bvmATYgT6CTo=; b=OApJb2F8bKGFA/EkasjNmPflbo5Zu2uz1eaeQX1/Y8XsgeBsnD+KCv7uOJ+eBBv4ZL LbRyHxyeVB3TlahzLDpaCpx+Fgm4h0Wp8Wv4SlLA20isbtJnhyPwzIOxbF1RgA+OR2zt QVPgvCQXdozjwWaVaLHZEcNsc0J01vK2CzCB2q68OXAIIXlaXM2qyBWEWrXC/368dnD0 fTK2BcUNFekO1JuWlYAV7ZA5nSFbgsZhPc+3vRvXoQPJxfiwARjA2bmHUB3WAJYbgtyR 6VgKw9w8GDixskyx71VLYCXHWFozePEscrru7a5BehTJJsJzSr5EldtcT8KcJycy2OzZ N/bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783361498; x=1783966298; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AdPbV9YRxG+cQo4afaZFPHUjWAQxmA2bvmATYgT6CTo=; b=BxeqRWl2r+8EaCoSrG6p3TxeEq6KAuSyJZs/JKFovkxEGdmuw0Drjxhy7kY5i7Z3K/ Q6s+HxmSf8xnwHgacVRhlxfcu5b/0/lE4Z0Sw1YUrWUUHuSWmXRi/Nc4a1bLK75umX+s vwmMdLI2nTuzdWBFJK8COQDrgQxzkueiYKFINvD0BMbSfHgWFw+7Hk1B9/9yMFOGJYT2 n/dLWUkKC3+9e/HpEfnle8jQxuQlALqCwM8IcyuDuPxceh3GBYD3Ox88ahVxvy2DzqnU Vh/m3XMfHTgEXH7jjrRKAATNA8HpJX2C0YQXdK5dyUT0+42sppyTTcAotKdjNxFmpHcz jDOQ== X-Forwarded-Encrypted: i=1; AHgh+RpRkRmxjKpzVlyc+P5qXEDC/2J+c9q5sh5RVOkJ0fqnFl5b26TjyUI8Uhe5a4TWf7k4JIFCalU6q5aM@vger.kernel.org X-Gm-Message-State: AOJu0YwCt8felFKeTbgnHRoijcsQKPNbHFj40LtsdymV6L19OtIaC9gd iy+Vjw0YPULwRxa4SLEs2vLEKWIKr0fmNVly/DyH+2bm0oPW1iuFg5ZQ/x0hxgATdbZ95wduXkE P6dxcqz1CrqALg2ociS28oY7O0wJaS7ijLmiCwf682h/RLzRxrcuXfziT1UqczHCg X-Gm-Gg: AfdE7cmUlHxxyjQgiPxVtVVAB7kRthZTX9fobxnf+Tfy6fSJnSS5eGQchqQqgXTAEpt /wN9NbFAO9WO1CK0m4rgVV9m1rAHjEsRvWATB4rnWF1bcE2azuulWhxGRzobbIPBLLZPXSwctA4 3EHQODUeLq3iVmisbMPcTZHrny0FXfHpi2scrM+NniJBirAr+qpmryuwkDD9dwPBGCVeeRfrWHU QKN6qj5DIAMfJeJTE4QMPxLjs/PtTDDTboe2ix96AsCcOSSBpK8S4eDTzYlyTRp5yLvrPWMQ9Bp KkW8Qp2RuvInDhoRsd16OTNVwegVYzqVO2g6M22edJeYOvzvwujaqoBBwZ0N1wXBP5onieIg2Iu soigXs7cSihmkZmm3RPOSveVUW/jjWWLyC+sHWnpFt8YCcUeg5HUD5CyTJs+Irf7cWvceUdksPQ == X-Received: by 2002:a05:620a:3944:b0:929:7356:2e51 with SMTP id af79cd13be357-92e8b29ea49mr2107013185a.11.1783361498250; Mon, 06 Jul 2026 11:11:38 -0700 (PDT) X-Received: by 2002:a05:620a:3944:b0:929:7356:2e51 with SMTP id af79cd13be357-92e8b29ea49mr2107006285a.11.1783361497659; Mon, 06 Jul 2026 11:11:37 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:7d20:e20f:a77f:4ef7? ([2a05:6e02:1041:c10:7d20:e20f:a77f:4ef7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d8f1sm26585575f8f.3.2026.07.06.11.11.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 11:11:36 -0700 (PDT) Message-ID: <1aca8d60-8e39-4532-9095-a5260bba76ac@oss.qualcomm.com> Date: Mon, 6 Jul 2026 20:11:35 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/10] dt-bindings: firmware: qcom: tmd: add TMD device type constants To: Dmitry Baryshkov Cc: Gaurav Kohli , Konrad Dybcio , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <20260703-qmi-tmd-v4-0-3882189c1f83@oss.qualcomm.com> <20260703-qmi-tmd-v4-1-3882189c1f83@oss.qualcomm.com> <977711ef-c1fb-4735-b82a-4ca2f4797f51@oss.qualcomm.com> <8ad14017-bce7-485e-9677-9cbf8ecb2742@oss.qualcomm.com> <10a346d8-fbb1-4142-a650-507c3917b8f6@oss.qualcomm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE4MyBTYWx0ZWRfX5B28uIHJuNCx 6iOoCSB4gvBJCgsg6Tphkce4CrcCBDEosi/HpvQYJz3iC5PejGPBzAg/fOk1Nkay7o8raLipjMh GmwBL8W2z+57LmA1BuVDYxNcTWeuEAQlps9onRZ0SUIKlcQ702VFS2U+x8lzS/jLdcpje1qUiIn JxUQPynHn6x0hMUCMKLQ2RgXuZ/NC+AJg5ii+zQAonoP0gJcgDGPO+awp4gV5h2J0xiY5fhiopt ILSUE4qJYI3n8bRV8ryBz25tVjfq9O/jMHFiBgWJGDMgLDJBMW/Vzfp41UyvCKgl4oG3xPBrIN9 3nKYdJK0xbjrzhZXwAJCCcZr8Ibxzb9fiYmQ33vuRTaeCoLY+RLS839cSuhM13kQ7BrFJSS5HvM qyUdPKY6IIx8xHZImOUHTA9Z9FK2K5GB3BXBy7aPax6RBUzE/PhQANYecFkRDGY4xhepnYshtOv zNuQuEzShiQLCsWAhzg== X-Proofpoint-ORIG-GUID: 9cwbDCZmmxKTZzg9_fECQFN1n_qi6McP X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE4MyBTYWx0ZWRfX74X4Dnxdg4wj r15FOBbNpGLgCXkhULL7xUR/JvqfeQ1f5oxqrTfCXG58PyESzB2JNAgg5g92tOURANcG41PP5fw 25OQ2iAYL2dlJuBtLDBXgkHWtJFZF6I= X-Proofpoint-GUID: 9cwbDCZmmxKTZzg9_fECQFN1n_qi6McP X-Authority-Analysis: v=2.4 cv=f9N4wuyM c=1 sm=1 tr=0 ts=6a4befda cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=Q9Cl1ItI0dfYaDPAyAEA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_02,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060183 On 7/6/26 19:47, Dmitry Baryshkov wrote: > On Mon, Jul 06, 2026 at 07:03:18PM +0200, Daniel Lezcano wrote: >> On 7/3/26 17:42, Dmitry Baryshkov wrote: >>> On Fri, Jul 03, 2026 at 07:43:39PM +0530, Gaurav Kohli wrote: >>>> >>>> >>>> On 7/3/2026 1:23 PM, Konrad Dybcio wrote: >>>>> On 7/3/26 7:03 AM, Gaurav Kohli wrote: >>>>>> Add Device Tree binding constants for Qualcomm Thermal Mitigation >>>>>> Device (TMD) types used by remoteproc-backed thermal cooling devices. >>>>>> >>>>>> Qualcomm remote processors expose thermal mitigation endpoints >>>>>> through QMI. These endpoints can be registered with the thermal >>>>>> framework via the `#cooling-cells` property on the remoteproc node. >>>>>> >>>>>> The QMI TMD protocol identifies devices using string names (for example, >>>>>> "pa", "modem", and "cdsp_sw"), while the DT cooling-device binding with >>>>>> `#cooling-cells = <3>` requires numeric device id in the form: >>>>>> >>>>>> <&phandle device_id min_state max_state> >>>>>> >>>>>> Define common TMD device index constants shared across currently >>>>>> supported platforms. If a future target requires a different mapping, >>>>>> additional target-specific constants can be introduced while preserving >>>>>> existing DT ABI. >>>>>> >>>>>> Signed-off-by: Gaurav Kohli [ ... ] >>> Why are you using only those TMD devices? >>> >>>> More constants can be added as needed. >>> >>> Kodiak is one of the supported platforms. >> >> What would be the benefit of having more than thirteen cooling devices >> declared in the thermal framework and having only a couple of them mapped in >> a thermal zone ? >> >> I agree there are more TMDs but if they are unused for the moment, why do we >> need to add them ? Can we do that incrementally ? > > That's what I am trying to understand: why the implementation uses only > the selected two devices, if the modem on Kodiak supports others. How > can we find out, which TMDs to use on other devices. My understanding is that is an initial thermal setup. Gaurav will add them step by step while setting up all the thermal zones instead of sending a big patchset. And TBH, that will be much easier to review.