From: Adrian Hunter <adrian.hunter@intel.com>
To: Doug Brown <doug@schmorgal.com>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 8/8] dt-bindings: mmc: sdhci-pxa: add pxav1
Date: Wed, 11 Jan 2023 14:44:10 +0200 [thread overview]
Message-ID: <1acd4e02-93db-88bc-2230-e230214fe591@intel.com> (raw)
In-Reply-To: <20221229200411.295339-9-doug@schmorgal.com>
On 29/12/22 22:04, Doug Brown wrote:
> Add a compatible for the pxav1 controller in the PXA168, along with
> optional pinctrl properties to use for an errata workaround.
>
> Signed-off-by: Doug Brown <doug@schmorgal.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Doesn't apply cleanly anymore
> ---
> .../devicetree/bindings/mmc/sdhci-pxa.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> index 1c87f4218e18..09455f9fa8de 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> @@ -4,7 +4,7 @@
> $id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Marvell PXA SDHCI v2/v3 bindings
> +title: Marvell PXA SDHCI v1/v2/v3
>
> maintainers:
> - Ulf Hansson <ulf.hansson@linaro.org>
> @@ -34,6 +34,7 @@ allOf:
> properties:
> compatible:
> enum:
> + - mrvl,pxav1-mmc
> - mrvl,pxav2-mmc
> - mrvl,pxav3-mmc
> - marvell,armada-380-sdhci
> @@ -61,6 +62,22 @@ properties:
> - const: io
> - const: core
>
> + pinctrl-names:
> + description:
> + Optional for supporting PXA168 SDIO IRQ errata to switch CMD pin between
> + SDIO CMD and GPIO mode.
> + items:
> + - const: default
> + - const: state_cmd_gpio
> +
> + pinctrl-0:
> + description:
> + Should contain default pinctrl.
> +
> + pinctrl-1:
> + description:
> + Should switch CMD pin to GPIO mode as a high output.
> +
> mrvl,clk-delay-cycles:
> description: Specify a number of cycles to delay for tuning.
> $ref: /schemas/types.yaml#/definitions/uint32
next prev parent reply other threads:[~2023-01-11 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 20:04 [PATCH v3 0/8] mmc: sdhci-pxav2: Add support for PXA168 Doug Brown
2022-12-29 20:04 ` [PATCH v3 1/8] mmc: sdhci-pxav2: add initial support for PXA168 V1 controller Doug Brown
2022-12-29 20:04 ` [PATCH v3 2/8] mmc: sdhci-pxav2: enable CONFIG_MMC_SDHCI_IO_ACCESSORS Doug Brown
2022-12-29 20:04 ` [PATCH v3 3/8] mmc: sdhci-pxav2: add register workaround for PXA168 silicon bug Doug Brown
2022-12-29 20:04 ` [PATCH v3 4/8] mmc: sdhci-pxav2: change clock name to match DT bindings Doug Brown
2022-12-29 20:04 ` [PATCH v3 5/8] mmc: sdhci-pxav2: add optional core clock Doug Brown
2022-12-29 20:04 ` [PATCH v3 6/8] mmc: sdhci-pxav2: add SDIO card IRQ workaround for PXA168 V1 controller Doug Brown
2022-12-29 20:04 ` [PATCH v3 7/8] mmc: sdhci-pxav2: add optional pinctrl for SDIO IRQ workaround Doug Brown
2022-12-29 20:04 ` [PATCH v3 8/8] dt-bindings: mmc: sdhci-pxa: add pxav1 Doug Brown
2023-01-11 12:44 ` Adrian Hunter [this message]
2023-01-12 2:20 ` Doug Brown
2023-01-11 12:43 ` [PATCH v3 0/8] mmc: sdhci-pxav2: Add support for PXA168 Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1acd4e02-93db-88bc-2230-e230214fe591@intel.com \
--to=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=doug@schmorgal.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).