From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30971746B for ; Fri, 6 Oct 2023 11:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RW21+Bcu" Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AE9AC2; Fri, 6 Oct 2023 04:55:37 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 396BtVdF071941; Fri, 6 Oct 2023 06:55:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1696593331; bh=bV7N1eMvMIbNRZkpg5EJivJIzf1bI9x51VJMvfYW/R0=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=RW21+BcuiPXthnTMkf60m3NJo1eqpcvE04U238hkITNWwXJDL4ZyfVi4LWHJdtPFt k262TwJPjAyQsjCJjuVvd6PaB+ORVkmD2G3U2sNnIVCpgSS42FgAyDk9/M8oh6t+p8 w1BaFsh1zMSGCAAY5nr53Khalk2JhG/VnlQxBYtA= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 396BtV5t024951 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Oct 2023 06:55:31 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 6 Oct 2023 06:55:30 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 6 Oct 2023 06:55:30 -0500 Received: from [10.249.131.134] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 396BtR4i009986; Fri, 6 Oct 2023 06:55:27 -0500 Message-ID: <1acde127-5141-45c0-aa58-5189e280bb7f@ti.com> Date: Fri, 6 Oct 2023 17:25:26 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 5/7] arm64: dts: ti: k3-j784s4-mcu: Add the mcu domain watchdog instances Content-Language: en-US To: Nishanth Menon CC: , , , , , , , , References: <20231006042901.6474-1-j-keerthy@ti.com> <20231006042901.6474-6-j-keerthy@ti.com> <20231006113410.tibvxxkeuujqnbv4@evolution> From: "J, KEERTHY" In-Reply-To: <20231006113410.tibvxxkeuujqnbv4@evolution> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 10/6/2023 5:04 PM, Nishanth Menon wrote: > On 09:58-20231006, Keerthy wrote: >> There are totally 2 instances of watchdog module in MCU domain. >> These instances are coupled with the MCU domain R5F instances. > >> Disabling them as they are not used by Linux. > Device tree is hardware description - not tied to how Linux uses it. > > Reason these wdts are disabled by default is because they are tightly > coupled with R5Fs. Okay. I will rephrase that. > >> >> Signed-off-by: Keerthy >> --- >> .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 24 +++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> index a7b5c4cb7d3e..809a0b1cf038 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> @@ -714,4 +714,28 @@ >> ti,esm-pins = <63>; >> bootph-pre-ram; >> }; >> + >> + /* >> + * The 2 RTI instances are couple with MCU R5Fs so keeping them >> + * disabled as these will be used by their respective firmware >> + */ >> + mcu_watchdog0: watchdog@40600000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x40600000 0x00 0x100>; >> + clocks = <&k3_clks 367 1>; >> + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 367 0>; >> + assigned-clock-parents = <&k3_clks 367 4>; >> + status = "disabled"; >> + }; >> + >> + mcu_watchdog1: watchdog@40610000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x40610000 0x00 0x100>; >> + clocks = <&k3_clks 368 1>; >> + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 368 0>; >> + assigned-clock-parents = <&k3_clks 368 4>; > > Please DONOT ignore the review comments - I did ask the documentation in > dts as well. reason being that this is what people will see rather than > dig up the commit log. it should be intutive when reading the dts why > nodes are disabled by default Vs the standard of leaving it enabled by > default. Given esp that these peripherals do not have anything to do > with board semantics (pinmux or something similar) to be complete. > >> + status = "disabled"; >> + }; >> }; >> -- >> 2.17.1 >> >