[PATCH 0/2] Add R8A77980/Condor eMMC support

[PATCH 0/2] Add R8A77980/Condor eMMC support

[Sergei Shtylyov]

Hello!

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20180412-v4.16' tag. We're adding the R8A77980 MMC (SDHI)
device nodes and then enable eMMC support on the Condor board. These patches
are atop of the recently posted PCIe/PFC R8A77980/Condor patches and they
depend on the R8A77980 SDHI driver support patch (not posted yet) in order
to work properly...

[1/2] arm64: dts: renesas: r8a77980: add MMC support
[2/2] arm64: dts: renesas: condor: add eMMC support

WBR, Sergei

[PATCH 0/2] Add R8A77980/Condor eMMC support

[Sergei Shtylyov]

Hello!

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20180810-v4.18-rc7' tag. We're adding the R8A77970 MMC0
(SDHI2) device nodes and then enable eMMC support on the V3M Starter Kit
board. The SDHI (w/internal DMA) driver patch white-listing the R8A77970
was posted last Saturday; the R8A77970 CPG/MSSR driver patch and the SDHI
bindings patch have been posted earlier today.

[1/2] arm64: dts: renesas: r8a77970: add MMC support
[2/2] arm64: dts: renesas: v3msk: add eMMC support

WBR, Sergei

[PATCH /2] arm64: dts: renesas: r8a77970: add MMC support

[Sergei Shtylyov]

Define the generic R8A77970 part of the MMC0 (SDHI2) device node.

Based on the original (and large) patches by Vladimir Barinov.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm64/boot/dts/renesas/r8a77970.dtsi |   12 ++++++++++++
 1 file changed, 12 insertions(+)

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -754,6 +754,18 @@
 			#iommu-cells = <1>;
 		};
 
+		mmc0: mmc@ee140000 {
+			compatible = "renesas,sdhi-r8a77970",
+				     "renesas,rcar-gen3-sdhi";
+			reg = <0 0xee140000 0 0x2000>;
+			interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 314>;
+			power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+			resets = <&cpg 314>;
+			max-frequency = <200000000>;
+			status = "disabled";
+		};
+
 		gic: interrupt-controller@f1010000 {
 			compatible = "arm,gic-400";
 			#interrupt-cells = <3>;

[PATCH 2/2] arm64: dts: renesas: v3msk: add eMMC support

[Sergei Shtylyov]

Add the eMMC chip support for the V3M Started Kit board.

Based on the original (and large) patches by Vladimir Barinov.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts |   26 +++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
@@ -51,6 +51,15 @@
 		regulator-always-on;
 	};
 
+	vcc_vddq_vin0: regulator-2 {
+		compatible = "regulator-fixed";
+		regulator-name = "VCC_VDDQ_VIN0";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
 	lvds-decoder {
 		compatible = "thine,thc63lvd1024";
 		vcc-supply = <&vcc_d3_3v>;
@@ -128,6 +137,12 @@
 		function = "i2c0";
 	};
 
+	mmc_pins: mmc_3_3v {
+		groups = "mmc_data8", "mmc_ctrl";
+		function = "mmc";
+		power-source = <3300>;
+	};
+
 	scif0_pins: scif0 {
 		groups = "scif0_data";
 		function = "scif0";
@@ -192,6 +207,17 @@
 	};
 };
 
+&mmc0 {
+	pinctrl-0 = <&mmc_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&vcc_d3_3v>;
+	vqmmc-supply = <&vcc_vddq_vin0>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
 &scif0 {
 	pinctrl-0 = <&scif0_pins>;
 	pinctrl-names = "default";

Re: [PATCH 2/2] arm64: dts: renesas: v3msk: add eMMC support

[Simon Horman]

On Tue, Aug 21, 2018 at 10:50:31PM +0300, Sergei Shtylyov wrote:
> Add the eMMC chip support for the V3M Started Kit board.
> 
> Based on the original (and large) patches by Vladimir Barinov.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

I am, however, curious to know about HS200.
Is it supported on the v3msk? If so, do you have any plans to enable it?

Re: [PATCH /2] arm64: dts: renesas: r8a77970: add MMC support

[Simon Horman]

On Tue, Aug 21, 2018 at 10:49:26PM +0300, Sergei Shtylyov wrote:
> Define the generic R8A77970 part of the MMC0 (SDHI2) device node.
> 
> Based on the original (and large) patches by Vladimir Barinov.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Re: [PATCH 2/2] arm64: dts: renesas: v3msk: add eMMC support

[Sergei Shtylyov]

On 08/22/2018 02:31 PM, Simon Horman wrote:

>> Add the eMMC chip support for the V3M Started Kit board.
>>
>> Based on the original (and large) patches by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
> 
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> 
> I am, however, curious to know about HS200.
> Is it supported on the v3msk? If so, do you have any plans to enable it?

   As I've already said, the eMMC chip only receives 3.3V on all its voltage inputs.

MBR, Sergei

Re: [PATCH /2] arm64: dts: renesas: r8a77970: add MMC support

[Simon Horman]

On Wed, Aug 22, 2018 at 01:31:19PM +0200, Simon Horman wrote:
> On Tue, Aug 21, 2018 at 10:49:26PM +0300, Sergei Shtylyov wrote:
> > Define the generic R8A77970 part of the MMC0 (SDHI2) device node.
> > 
> > Based on the original (and large) patches by Vladimir Barinov.
> > 
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
> 
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

I have now applied this for v4.20.

Re: [PATCH 2/2] arm64: dts: renesas: v3msk: add eMMC support

[Simon Horman]

On Wed, Aug 22, 2018 at 05:43:11PM +0300, Sergei Shtylyov wrote:
> On 08/22/2018 02:31 PM, Simon Horman wrote:
> 
> >> Add the eMMC chip support for the V3M Started Kit board.
> >>
> >> Based on the original (and large) patches by Vladimir Barinov.
> >>
> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > 
> > Thanks,
> > 
> > This looks fine to me but I will wait to see if there are other reviews
> > before applying.
> > 
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> > 
> > I am, however, curious to know about HS200.
> > Is it supported on the v3msk? If so, do you have any plans to enable it?
> 
>    As I've already said, the eMMC chip only receives 3.3V on all its voltage inputs.

Thanks Sergei, got it.

I have applied this for v4.20.