From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Michal Simek <michal.simek@amd.com>,
linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: soc: xilinx: Add support for K26 rev2 SOMs
Date: Wed, 20 Dec 2023 08:55:32 +0100 [thread overview]
Message-ID: <1afdcd25-d001-4523-be0d-2bf2c9e1d7a6@linaro.org> (raw)
In-Reply-To: <6673abb84e542c2841cece9336571f97b19882fe.1702995908.git.michal.simek@amd.com>
On 19/12/2023 15:25, Michal Simek wrote:
> Revision 2 is SW compatible with revision 1 but it is necessary to reflect
> it in model and compatible properties which are parsed by user space.
> Rev 2 has improved a power on boot reset and MIO34 shutdown glich
> improvement done via an additional filter in the GreenPak chip.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml b/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
> index d4c0fe1fe435..62617e1ea74f 100644
> --- a/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
> +++ b/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
> @@ -118,6 +118,7 @@ properties:
>
> - description: Xilinx Kria SOMs
> items:
> + - const: xlnx,zynqmp-sm-k26-rev2
> - const: xlnx,zynqmp-sm-k26-rev1
> - const: xlnx,zynqmp-sm-k26-revB
> - const: xlnx,zynqmp-sm-k26-revA
You are changing existing list of compatibles, so all devices with
"rev1" will fail the checks. Is it expected?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-20 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 14:25 [PATCH] dt-bindings: soc: xilinx: Add support for K26 rev2 SOMs Michal Simek
2023-12-20 7:55 ` Krzysztof Kozlowski [this message]
2023-12-20 8:01 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1afdcd25-d001-4523-be0d-2bf2c9e1d7a6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox