From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Alex Elder <elder@linaro.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Taniya Das <quic_tdas@quicinc.com>
Cc: Georgi Djakov <djakov@kernel.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
Johan Hovold <johan@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/9] interconnect: qcom: sc7180: drop IP0 remnants
Date: Fri, 6 Jan 2023 20:52:28 +0200 [thread overview]
Message-ID: <1b2e1431-1fe9-d70e-b45e-71824fe16547@linaro.org> (raw)
In-Reply-To: <eeb9631c-4494-fc76-5ad4-5fdbdaa8786a@linaro.org>
On 06/01/2023 15:44, Alex Elder wrote:
> On 1/6/23 1:33 AM, Dmitry Baryshkov wrote:
>> Drop two defines leftover from the commit 2f3724930eb4 ("interconnect:
>> qcom: sc7180: Drop IP0 interconnects"), which dropped handling of the
>> IP0 resource in favour of handling it in the clk-rpmh driver.
>>
>> Fixes: 2f3724930eb4 ("interconnect: qcom: sc7180: Drop IP0
>> interconnects")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> On this patch and the rest like it in this series, I suggest
> adding a comment that indicates why there's a gap in the simple
> numeric sequence.
Ok, sounds fair.
> Feel free to ignore this if you don't think
> this is a good idea. I'll give examples below, although I
> don't fully understand why there's a master and slave on the
> interconnect, but just a single clock for RPMH clock...
Well, interconnects is a about paths between nodes. So even if we have
to cast a vote on a single resource, there should be two nodes.
>
> -Alex
>
>> ---
>> drivers/interconnect/qcom/sc7180.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/interconnect/qcom/sc7180.h
>> b/drivers/interconnect/qcom/sc7180.h
>> index c6212a10c2f6..b691d97d56cf 100644
>> --- a/drivers/interconnect/qcom/sc7180.h
>> +++ b/drivers/interconnect/qcom/sc7180.h
>> @@ -11,7 +11,6 @@
>> #define SC7180_MASTER_APPSS_PROC 0
>> #define SC7180_MASTER_SYS_TCU 1
>> #define SC7180_MASTER_NPU_SYS 2
>> -#define SC7180_MASTER_IPA_CORE 3
> /* MASTER_IPA_CORE (4) is represented as an RPMH clock */
>> #define SC7180_MASTER_LLCC 4
>> #define SC7180_MASTER_A1NOC_CFG 5
>> #define SC7180_MASTER_A2NOC_CFG 6
>> @@ -58,7 +57,6 @@
>> #define SC7180_MASTER_USB3 47
>> #define SC7180_MASTER_EMMC 48
>> #define SC7180_SLAVE_EBI1 49
>> -#define SC7180_SLAVE_IPA_CORE 50
> /* SLAVE_IPA_CORE (50) is represented as an RPMH clock */
>> #define SC7180_SLAVE_A1NOC_CFG 51
>> #define SC7180_SLAVE_A2NOC_CFG 52
>> #define SC7180_SLAVE_AHB2PHY_SOUTH 53
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-01-06 18:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 1/9] clk: qcom: rpmh: define IPA clocks where required Dmitry Baryshkov
2023-01-06 13:39 ` Alex Elder
2023-01-06 18:33 ` Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 2/9] interconnect: qcom: sdx55: drop IP0 remnants Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 3/9] interconnect: qcom: sc7180: " Dmitry Baryshkov
2023-01-06 13:44 ` Alex Elder
2023-01-06 18:52 ` Dmitry Baryshkov [this message]
2023-01-06 7:33 ` [PATCH 4/9] interconnect: qcom: sm8150: Drop IP0 interconnects Dmitry Baryshkov
2023-01-06 13:47 ` Alex Elder
2023-01-06 7:33 ` [PATCH 5/9] interconnect: qcom: sm8250: " Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 6/9] interconnect: qcom: sc8180x: " Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 7/9] interconnect: qcom: sc8280xp: " Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 8/9] dt-bindings: interconnect: qcom: Remove sc7180/sdx55 ipa compatibles Dmitry Baryshkov
2023-01-06 11:09 ` Krzysztof Kozlowski
2023-01-06 7:33 ` [PATCH 9/9] dt-bindings: interconnect: qcom: drop IPA_CORE related defines Dmitry Baryshkov
2023-01-06 11:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b2e1431-1fe9-d70e-b45e-71824fe16547@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=elder@linaro.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=okukatla@codeaurora.org \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).