From: "Rafał Miłecki" <rafal@milecki.pl>
To: Markus Mayer <code@mmayer.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
Device Tree List <devicetree@vger.kernel.org>,
Doug Berger <opendmb@gmail.com>,
Markus Mayer <mmayer@broadcom.com>, Arnd Bergmann <arnd@arndb.de>,
Power Management List <linux-pm@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eduardo Valentin <edubezval@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
Olof Johansson <olof@lixom.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Brian Norris <computersforpeace@gmail.com>,
ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/4] thermal: add brcmstb AVS TMON driver
Date: Fri, 21 Jul 2017 22:04:42 +0200 [thread overview]
Message-ID: <1b44dcc1381fda8ab3f29c97718e9999@milecki.pl> (raw)
In-Reply-To: <20170721192735.6546-3-code@mmayer.net>
I'm far from being thermal expert, to me it looks OK, only 1 trivial
issue
noticed (see below).
On 2017-07-21 21:27, Markus Mayer wrote:
> +static void avs_tmon_trip_enable(struct brcmstb_thermal_priv *priv,
> + enum avs_tmon_trip_type type, int en)
> +{
> + struct avs_tmon_trip *trip = &avs_tmon_trips[type];
> + u32 val = __raw_readl(priv->tmon_base + trip->enable_offs);
> +
> + pr_debug("%sable trip, type %d\n", en ? "en" : "dis", type);
This probably could be dev_dbg?
> +static void avs_tmon_set_trip_temp(struct brcmstb_thermal_priv *priv,
> + enum avs_tmon_trip_type type,
> + int temp)
> +{
> + struct avs_tmon_trip *trip = &avs_tmon_trips[type];
> + u32 val, orig;
> +
> + pr_debug("set temp %d to %d\n", type, temp);
Same here.
> +static int brcmstb_set_trips(void *data, int low, int high)
> +{
> + struct brcmstb_thermal_priv *priv = data;
> +
> + pr_debug("set trips %d <--> %d\n", low, high);
And the last time here.
next prev parent reply other threads:[~2017-07-21 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 19:27 [PATCH v2 0/4] thermal: add brcmstb AVS TMON driver Markus Mayer
2017-07-21 19:27 ` [PATCH v2 1/4] Documentation: devicetree: add binding for Broadcom STB AVS TMON Markus Mayer
2017-07-21 19:27 ` [PATCH v2 2/4] thermal: add brcmstb AVS TMON driver Markus Mayer
2017-07-21 20:04 ` Rafał Miłecki [this message]
2017-07-21 20:12 ` Markus Mayer
2017-07-21 19:27 ` [PATCH v2 3/4] ARM: multi_v7_defconfig: add CONFIG_BRCMSTB_THERMAL Markus Mayer
2017-07-21 19:27 ` [PATCH v2 4/4] arm64: defconfig: " Markus Mayer
[not found] ` <20170721192735.6546-1-code-7CzEARzsJhSsTnJN9+BGXg@public.gmane.org>
2017-07-24 21:01 ` [PATCH v2 0/4] thermal: add brcmstb AVS TMON driver Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b44dcc1381fda8ab3f29c97718e9999@milecki.pl \
--to=rafal@milecki.pl \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=code@mmayer.net \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mmayer@broadcom.com \
--cc=olof@lixom.net \
--cc=opendmb@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).