From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C08CC46467 for ; Mon, 16 Jan 2023 09:15:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232609AbjAPJPJ (ORCPT ); Mon, 16 Jan 2023 04:15:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232202AbjAPJOj (ORCPT ); Mon, 16 Jan 2023 04:14:39 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F82B13D64 for ; Mon, 16 Jan 2023 01:14:37 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id s5so39811028edc.12 for ; Mon, 16 Jan 2023 01:14:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XD8R6KSRXSrAMFQ28g15vWx+7evq6kq5Ndl6EQERPMQ=; b=DTjCGii7ePDb7Y0xU20aar/RKW18t1mNHdNYR6RSFUVTYFb4OVYVLY/zTddNY2bHZm ucO+GDgjfA4n0l6EZUR3A+8e0mDfbhAI/gb4wqy+rcmAb3ChXMuO/3n6+7Iy0Zpp9OUy GWc+/j/q/6s+JjUMeB9nkl1KobAe6GhPTiWqQQqwzCcDVq+poYmX6210EJ3eK7/M2tL9 c0a1Y5oaSHsh2UgacLBSAgOwgIORkSnWtQEyuvPWvGjiOUX1Wx6n0Hz7fXO+fviUW/fZ zydmAJS7X9Yek9SJgPzn7Txx4vKuU/EOYkb1LGcIyeCXpXqs5HcmDhIGl0x9udOgC2vZ I5TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XD8R6KSRXSrAMFQ28g15vWx+7evq6kq5Ndl6EQERPMQ=; b=grCVvs1TsyOz26Lw0qz//fWwgnXlgk+xI/nqtDeGseUfq60jPyrNX3BnfD3sXIGP2Q zaSfdxPh3i4TdKidzP7kPNkiPDk/0jaxBQAQnr07utdQM9z9yKNBfyQR3R4muEdIhuky SE2+3L2pi+5GvQhFz3vWZGwZdK8wBwGKQox9Y506D1ENxvhoIVflCL9v7CX7QMHw1sVt cINLn6+NZYHT0NSu7w/Aj8PeiC9iquVYMMwA3LGPDh6e+cAjx1rAdjdEfsSWAXChh1mY gyOiK3sVDww3Ka80sZ+HIrZohb4SH3lc2N4L9E0s5RwhbErz0K0VFr+BH8Dxd3SXDQnt J+Dg== X-Gm-Message-State: AFqh2kowqlEX1lqEhfI7m2aKIfyXoOprY4C27tFN5cf8aDLKCUyoZMdH eI/kWRsGeI4QdKZvLCwofmgcmPvv5sKfe23f X-Google-Smtp-Source: AMrXdXvnbXFShYdOval9Ul8ytyMGsGof5b2hWy22b4i8Tr4ErSn0wcjrwogcCAfUdvSn7EylfMYVrA== X-Received: by 2002:a05:6402:390b:b0:465:f6a9:cb7b with SMTP id fe11-20020a056402390b00b00465f6a9cb7bmr80004456edb.12.1673860475810; Mon, 16 Jan 2023 01:14:35 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id v22-20020aa7d816000000b0049dd7eec977sm2452195edq.41.2023.01.16.01.14.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 01:14:35 -0800 (PST) Message-ID: <1b5613ad-6d0d-0979-ddd0-4677ade7beb9@linaro.org> Date: Mon, 16 Jan 2023 10:14:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] ARM: dts: imx6qdl: support child mfd cells for the reset controller Content-Language: en-US To: Ahmad Fatoum , Bastian Krause , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230113-syscon-child-mfd-v1-0-0dd31b7de373@pengutronix.de> <20230113-syscon-child-mfd-v1-2-0dd31b7de373@pengutronix.de> <392f6e9d-b7c2-37df-2067-f7d967a20f10@linaro.org> <12080bf5-2cc4-e215-555e-5438ed1bd851@pengutronix.de> From: Krzysztof Kozlowski In-Reply-To: <12080bf5-2cc4-e215-555e-5438ed1bd851@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/01/2023 09:27, Ahmad Fatoum wrote: > Hello Krzysztof, > > On 16.01.23 09:20, Krzysztof Kozlowski wrote: >> On 13/01/2023 18:32, Bastian Krause wrote: >>> The actual syscon-reboot-mode child node can be added by a board >>> device-tree or fixed up by the bootloader. For the child node to be >>> probed, the compatible needs to include simple-mfd. The binding now >>> specifies this, so have the SoC dtsi adhere to it. >>> >>> Suggested-by: Ahmad Fatoum >>> Signed-off-by: Bastian Krause >>> --- >>> arch/arm/boot/dts/imx6qdl.dtsi | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi >>> index ff1e0173b39be..b16be39458aa6 100644 >>> --- a/arch/arm/boot/dts/imx6qdl.dtsi >>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi >>> @@ -865,7 +865,8 @@ epit2: epit@20d4000 { /* EPIT2 */ >>> }; >>> >>> src: reset-controller@20d8000 { >>> - compatible = "fsl,imx6q-src", "fsl,imx51-src"; >>> + compatible = "fsl,imx6q-src", "fsl,imx51-src", >>> + "syscon", "simple-mfd"; >> >> You need children here. Otherwise simple-mfd does not make sense. If you >> expect something else to add children (I don't understand why, usually >> reboot capability is fixed per SoC and only sometimes extended with some >> other means), then this "else" will also change compatible. > > It's about syscon-reboot-mode, not syscon-reboot. Such modes are board- > not soc-specific. syscon-reboot-mode is also mostly SoC specific. What exactly would differ on different boards? Register offsets of SoC component? Register values used by SoC power management unit? Anyway, the binding is then not correct - it does not allow syscon-reboot-mode child. I'll comment there. Best regards, Krzysztof