From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "conor@kernel.org" <conor@kernel.org>, "afd@ti.com" <afd@ti.com>
Cc: "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"dmurphy@ti.com" <dmurphy@ti.com>,
"lee@kernel.org" <lee@kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"danielt@kernel.org" <danielt@kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x
Date: Fri, 6 Dec 2024 17:46:25 +0000 [thread overview]
Message-ID: <1b8648f10248a949508240785f5a99ed7c2c2037.camel@siemens.com> (raw)
In-Reply-To: <129a3e14-9c87-47c2-b4ed-49bbcf12ae7e@ti.com>
Hi Andrew,
On Fri, 2024-12-06 at 11:43 -0600, Andrew Davis wrote:
> > Are you sure this is a correct thing to do? The lp8860-q1 product link
> > cites it as being a 4-channel device. Even if the kernel only ever
> > supports it as a single-channel device, the binding should reflect what
> > it is capable of doing.
> >
>
> Agree, the driver today just checks the first child node, but it could
> be extended for all 4 supported LED channels, and we shouldn't have
> to change the binding for that new support.
but the channels are (in my understanding) for power-balancing only, there
are no separate controls for them. What do I miss?
--
Alexander Sverdlin
Siemens AG
www.siemens.com
next prev parent reply other threads:[~2024-12-06 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 17:07 [PATCH 0/2] leds: TI LP8864/LP8866 support A. Sverdlin
2024-12-06 17:07 ` [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x A. Sverdlin
2024-12-06 17:14 ` Conor Dooley
2024-12-06 17:43 ` Andrew Davis
2024-12-06 17:46 ` Sverdlin, Alexander [this message]
2024-12-06 18:02 ` Andrew Davis
2024-12-06 18:20 ` Sverdlin, Alexander
2024-12-06 18:39 ` Andrew Davis
2024-12-06 17:44 ` Sverdlin, Alexander
2024-12-16 20:08 ` Conor Dooley
2024-12-06 17:07 ` [PATCH 2/2] leds: lp8864: New driver A. Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b8648f10248a949508240785f5a99ed7c2c2037.camel@siemens.com \
--to=alexander.sverdlin@siemens.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=danielt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox