From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sam Protsenko <semen.protsenko@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Chanho Park <chanho61.park@samsung.com>,
David Virag <virag.david003@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: power: pd-samsung: Add Exynos850 support
Date: Thu, 9 Mar 2023 10:15:14 +0100 [thread overview]
Message-ID: <1b8bce82-a59d-f655-1277-3cc1110b818f@linaro.org> (raw)
In-Reply-To: <20230308230931.27261-2-semen.protsenko@linaro.org>
On 09/03/2023 00:09, Sam Protsenko wrote:
> Document the compatible string for Exynos850 power domains controller.
> Also add power domain indices which can be used in "samsung,pd-index"
There is no such property...
> property to specify a particular power domain in the device tree.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> .../devicetree/bindings/power/pd-samsung.yaml | 1 +
> MAINTAINERS | 1 +
> .../dt-bindings/power/samsung,exynos850-power.h | 17 +++++++++++++++++
> 3 files changed, 19 insertions(+)
> create mode 100644 include/dt-bindings/power/samsung,exynos850-power.h
>
> diff --git a/Documentation/devicetree/bindings/power/pd-samsung.yaml b/Documentation/devicetree/bindings/power/pd-samsung.yaml
> index 9c2c51133457..a353a705292c 100644
> --- a/Documentation/devicetree/bindings/power/pd-samsung.yaml
> +++ b/Documentation/devicetree/bindings/power/pd-samsung.yaml
> @@ -21,6 +21,7 @@ properties:
> enum:
> - samsung,exynos4210-pd
> - samsung,exynos5433-pd
> + - samsung,exynos850-pd
>
> reg:
> maxItems: 1
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8d5bc223f305..53e11e48639c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2720,6 +2720,7 @@ F: drivers/pwm/pwm-samsung.c
> F: drivers/soc/samsung/
> F: drivers/tty/serial/samsung*
> F: include/clocksource/samsung_pwm.h
> +F: include/dt-bindings/power/samsung,*
> F: include/linux/platform_data/*s3c*
> F: include/linux/serial_s3c.h
> F: include/linux/soc/samsung/
> diff --git a/include/dt-bindings/power/samsung,exynos850-power.h b/include/dt-bindings/power/samsung,exynos850-power.h
> new file mode 100644
> index 000000000000..a8d877b5515a
> --- /dev/null
> +++ b/include/dt-bindings/power/samsung,exynos850-power.h
Filename matching compatible, so samsung,exynos850-pd.h... but I
actually wonder why do we need it. How power domains are organized in
Exynos850?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-09 9:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230308230935eucas1p1e919f4d4b020e3386ce0eac8b4c8d299@eucas1p1.samsung.com>
2023-03-08 23:09 ` [PATCH 0/6] soc: samsung: pm_domains: Add Exynos850 support Sam Protsenko
2023-03-08 23:09 ` [PATCH 1/6] dt-bindings: power: pd-samsung: " Sam Protsenko
2023-03-09 9:15 ` Krzysztof Kozlowski [this message]
2023-03-08 23:09 ` [PATCH 2/6] dt-bindings: power: pd-samsung: Allow pd nodes to be children of PMU Sam Protsenko
2023-03-10 14:41 ` Krzysztof Kozlowski
2023-03-08 23:09 ` [PATCH 3/6] soc: samsung: pm_domains: Extract DT handling into a separate function Sam Protsenko
2023-03-08 23:09 ` [PATCH 4/6] soc: samsung: pm_domains: Implement proper I/O operations Sam Protsenko
2023-03-09 0:45 ` kernel test robot
2023-03-08 23:09 ` [PATCH 5/6] soc: samsung: pm_domains: Allow PD to be a child of PMU syscon Sam Protsenko
2023-03-08 23:09 ` [PATCH 6/6] soc: samsung: pm_domains: Add Exynos850 support Sam Protsenko
2023-03-09 10:12 ` [PATCH 0/6] " Marek Szyprowski
2023-03-10 14:41 ` Krzysztof Kozlowski
2023-03-20 17:57 ` Sam Protsenko
2023-03-22 18:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b8bce82-a59d-f655-1277-3cc1110b818f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=virag.david003@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).