From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD21EC636D3 for ; Wed, 1 Feb 2023 13:13:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232078AbjBANNz (ORCPT ); Wed, 1 Feb 2023 08:13:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231660AbjBANNy (ORCPT ); Wed, 1 Feb 2023 08:13:54 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F93838677 for ; Wed, 1 Feb 2023 05:13:51 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id n13so5631336wmr.4 for ; Wed, 01 Feb 2023 05:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NBVSqHRFtG/oRQBhwtv4eQUlLsJwKfgYGxR//a3EtVY=; b=CawsGJou9VXLSTLiSbX94s6GV0QPhhZLeRf5TV1XVsktftepDsXJYJblOBAdRuQB9o rmE+KByzfmAVrZctCx3YP7a2gNbfNWKpVs5EfjJoYQxQOJV/kkBP465DkNhH0cS9+73E /LOxy8+De01bfA5Vp+5bTC9yeqs24OTuY1iFUivKuSkQAc1gegbgJdwpvw3WeOCg65k0 DHUz+knydv1eaoUm0WZFLJYbpCwqQsq38571FXTWd86VI/y9fdgZBwCjX0kmTLzRLQeP ENbI4oAdMAh59CWpPwkevxfGUzsvMXRr5MSmwYRIh8EaUr1Lu55D4+SVdtLBa9K6ifTw XkTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NBVSqHRFtG/oRQBhwtv4eQUlLsJwKfgYGxR//a3EtVY=; b=gffGg8fgKbpbCFk2T94CLU7xd5Wq5sMj0aJNEMqQhWQ/0PXoIVgGxTgmFr7nva9J7h QII1rAlvbBqKiIned/yzqWt9A3RBeG8u/F6QmS8hnL/o+jQvoh8LI+8v5/rdDw/a+QlR W9Ms4hi75DLHbwTuNKEj9M/81mqCto2HtwVIjVAEvft5BpSwYJOc4GGfbdwxTnFNF2Ge jqRz8v2kZ0k/2wuZgi1Ob42VtLkWvGpnLYMNeSkgYwhouOgVNV9R6MMeW91XoVJSnL+f 9NdSFF5//U6E5FIW4U51vwmr0i+bqv7RqL7y/yG2EpjA0rhpMaMrUFFSKhsLZ0QdPFWZ nNHw== X-Gm-Message-State: AO0yUKXaip1N/2GoDKV+mgywTfBsQzEn4mGYSuPqToj7LDaIuao5Q9+p cYRB8BoQScuCHJfK9IvtHSUXCg== X-Google-Smtp-Source: AK7set+yf3Nsm5C9ZeM11L6U4K6PWqyZeCiqzJ6QeAuVfoj2t+QoDJCDauh2FgNVUvOi6P2O7Ttkww== X-Received: by 2002:a05:600c:1c9b:b0:3dc:5240:53b6 with SMTP id k27-20020a05600c1c9b00b003dc524053b6mr2211877wms.6.1675257229667; Wed, 01 Feb 2023 05:13:49 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o9-20020a05600c4fc900b003dc1300eab0sm1965656wmq.33.2023.02.01.05.13.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 05:13:49 -0800 (PST) Message-ID: <1bcd61d6-810f-1239-1b6e-367e0fe87370@linaro.org> Date: Wed, 1 Feb 2023 14:13:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] ASoC: dt-bindings: Drop broken irondevice,sma1303 binding Content-Language: en-US To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kiseok Jo References: <20230201131059.65527-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230201131059.65527-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/02/2023 14:10, Krzysztof Kozlowski wrote: > This reverts entire SMA1303 submission: > > 1. commit 1c24d12b68fa ("ASoC: dt-bindings: irondevice,sma1303.yaml: Fix about breaking the checks") > 2. commit dcf6d2ef0e82 ("ASoC: Modified the schema binding and added the vendor prefixes.") > 3. commit 5b28c049ff53 ("ASoC: SMA1303: Fix spelling mistake "Invald" -> "Invalid"") > 4. commit 68cd394efd0f ("ASoC: The Iron Device SMA1303 is a boosted Class-D audio amplifier.") > > Because the binding: > 1. Was never tested, > 2. Was never sent to Devicetree maintainers, > 3. Is entirely broken and wrong, so it would have to be almost rewritten > from scratch, > 4. It does not match the driver, IOW, the binding is fake. > > We cannot accept drivers with broken bindings and make it an ABI. > > Signed-off-by: Krzysztof Kozlowski > --- I understand that in general we tend to fix, not just to revert. But the poor quality of this binding and the next patch, which was suppose to fix it, plus complete lack of testing, means I do not believe the author will send correct binding. More over, fixing binding might require dropping incorrect properties, thus changing the driver. I am not willing to do that, I doubt that anyone has the time for it. It's the job of submitter to work on it. Best regards, Krzysztof