public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Prasad Sodagudi <quic_psodagud@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Eric Chanudet <echanude@redhat.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sa8775p: add symbols to dtb
Date: Mon, 13 Mar 2023 21:48:39 -0700	[thread overview]
Message-ID: <1bd61fa7-cd0e-e198-9cee-7485eacbe685@quicinc.com> (raw)
In-Reply-To: <43c11038-91d5-cbfd-7349-06fcd61a0661@linaro.org>



On 3/9/2023 3:47 PM, Konrad Dybcio wrote:
> 
> 
> On 10.03.2023 00:39, Eric Chanudet wrote:
>> ABL uses the __symbols__ section to process the DTB before passing it
>> forward. Without it, the bootstrap is interrupted.
>>
>> Signed-off-by: Eric Chanudet <echanude@redhat.com>
>> ---
> Fix your ABL.
Hi Konrad,

Apps boot-loader need __symbols__ for dynamic overlay operation. 
Qualcomm firmware passes an overlay file to apps boot-loader to overlay 
some of the nodes based on firmware configuration. Without __symbols__ 
apps boot-loader is not able to overlay.

Qualcomm hypervisor/gunyah would like to overlay arch timer node with 
always-on property, So adding __symbols__ helps boot-loader to overlay.

I think, commit text is misleading here and I will request Eric to fix 
the commit text.

-Thanks, Prasad

> 
> Konrad
>> Depends on initial sa8775p-ride.dts:
>> https://lore.kernel.org/all/20230214092713.211054-3-brgl@bgdev.pl/
>>
>>   arch/arm64/boot/dts/qcom/Makefile | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index b63cd1861e68..72e85ab31d74 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -1,4 +1,8 @@
>>   # SPDX-License-Identifier: GPL-2.0
>> +
>> +# Enable support for device-tree overlays required on sa8775p-ride.
>> +DTC_FLAGS_sa8775p-ride := -@
>> +
>>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
> 
> 

  reply	other threads:[~2023-03-14  4:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 23:39 [PATCH] arm64: dts: qcom: sa8775p: add symbols to dtb Eric Chanudet
2023-03-09 23:47 ` Konrad Dybcio
2023-03-14  4:48   ` Prasad Sodagudi [this message]
2023-03-14  9:59     ` Konrad Dybcio
2023-03-16  6:55     ` Krzysztof Kozlowski
2023-03-13 12:49 ` Bjorn Andersson
2023-03-14 15:14   ` Rob Herring
2023-03-22  2:55 ` Bjorn Andersson
2023-03-24 17:19   ` Eric Chanudet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bd61fa7-cd0e-e198-9cee-7485eacbe685@quicinc.com \
    --to=quic_psodagud@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=echanude@redhat.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox