From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH 8/9] s5p_cec: set the CEC_CAP_NEEDS_HPD flag if needed Date: Mon, 12 Jun 2017 14:41:16 +0200 Message-ID: <1bf6c49a-97e2-4a1c-9a05-41c55b56439e@samsung.com> References: <20170607144616.15247-1-hverkuil@xs4all.nl> <20170607144616.15247-9-hverkuil@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20170607144616.15247-9-hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> Content-language: en-GB Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hans Verkuil , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Hans Verkuil , Krzysztof Kozlowski , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 06/07/2017 04:46 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Use the needs-hpd DT property to determine if the CEC_CAP_NEEDS_HPD > should be set. > > Signed-off-by: Hans Verkuil Acked-by: Sylwester Nawrocki > --- > drivers/media/platform/s5p-cec/s5p_cec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/s5p-cec/s5p_cec.c b/drivers/media/platform/s5p-cec/s5p_cec.c > index 65a223e578ed..8e06071a7977 100644 > --- a/drivers/media/platform/s5p-cec/s5p_cec.c > +++ b/drivers/media/platform/s5p-cec/s5p_cec.c > @@ -173,6 +173,7 @@ static int s5p_cec_probe(struct platform_device *pdev) > struct platform_device *hdmi_dev; > struct resource *res; > struct s5p_cec_dev *cec; > + bool needs_hpd = of_property_read_bool(pdev->dev.of_node, "needs-hpd"); dev->of_node could also be used instead of pdev->dev.of_node. > int ret; > > np = of_parse_phandle(pdev->dev.of_node, "hdmi-phandle", 0); > @@ -221,7 +222,8 @@ static int s5p_cec_probe(struct platform_device *pdev) > cec->adap = cec_allocate_adapter(&s5p_cec_adap_ops, cec, > CEC_NAME, > CEC_CAP_LOG_ADDRS | CEC_CAP_TRANSMIT | > - CEC_CAP_PASSTHROUGH | CEC_CAP_RC, 1); > + CEC_CAP_PASSTHROUGH | CEC_CAP_RC | > + (needs_hpd ? CEC_CAP_NEEDS_HPD : 0), 1); > ret = PTR_ERR_OR_ZERO(cec->adap); > if (ret) > return ret; -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html