From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F8A5CA5534 for ; Wed, 13 Sep 2023 10:05:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233406AbjIMKFD (ORCPT ); Wed, 13 Sep 2023 06:05:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231367AbjIMKFC (ORCPT ); Wed, 13 Sep 2023 06:05:02 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD2931986 for ; Wed, 13 Sep 2023 03:04:58 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99c93638322so168397866b.1 for ; Wed, 13 Sep 2023 03:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694599497; x=1695204297; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+8jQ9kgZhteJCnTpLuHVvtEChJ/PBj7uSStHbbRkHBA=; b=YrQfz0yOwwzm0bPwSv+aSI8WYudEJ49vTMAbWwFPZ1q4zY7S8L07JOORvGKerzlMbS 4EUTk2DEefUBiMtSzkYsr+BkBRg+3YbFHddMf21vGxgVZWTd71EZiQsNplmpBiOXbTcv FTRHZtv+SsS+P8GgXWIDgcyobWJsmPtVnpjL2wu1yXkmy1K1iYS23O5f7PPeBnru/UKD /ElnTkLRTrD7fgc9wBmuYSPYlv3ANxj1qGhjUJKc3sjz5xWJnXE/TyUCAB50grI1YNqj 4DIr/bCs4lCJ5sMDrme3AsTrXH5PxE4UQEZABrnyXAUx2G2ilP61e6o0vV/0/a+3aEFg Pvpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694599497; x=1695204297; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+8jQ9kgZhteJCnTpLuHVvtEChJ/PBj7uSStHbbRkHBA=; b=FfxGT9SDwspJ0h8riG4eEA7vA8E4I2RrcqpRtBAA9pgp9BrcobM4skOGDgfJczBVPY upBcEhWCHs3MuvnNijrAU1UT4px+7eAya08MMW7W2j7HhU7FtMM00iDnDWa+HwB05qbF PDTxXIcfRqEl0hMt7EfMmcsm/Zyx9DKsrwjLjtRNUbcZjLSfKgtR99eYOxryUzUty+R/ AbbieUzruxn6ez4etZiNC+PWq3GrFpuSSUqI8zbxHSU4Lx8DD6myGVPXYlp5r7grVqOQ 2Ogwqp/794jTJRjMqCMrn6Iv94SNzkWVJ5gj2kc5ucI1xUtYsmupsa7VOfWXr0UD0CHC rQ3w== X-Gm-Message-State: AOJu0Yw57YGJ+AZo4JjX4vFd77asCN0v4mT864B7yXpsipTYTy661QBE 0b1KODZ48fF82ABEhRt6pPHmJg== X-Google-Smtp-Source: AGHT+IGcnHe8Cof2PTv779x4WyZcCCljCtks0CkDid6AVr83sjmocZ2x8ao7qjkkiXe0miEsy7Tcow== X-Received: by 2002:a17:907:9408:b0:96f:9cea:a34d with SMTP id dk8-20020a170907940800b0096f9ceaa34dmr7433807ejc.21.1694599496473; Wed, 13 Sep 2023 03:04:56 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id g21-20020a170906595500b009920a690cd9sm8012217ejr.59.2023.09.13.03.04.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Sep 2023 03:04:56 -0700 (PDT) Message-ID: <1bfdc230-e358-6aa4-7d60-03b5477a6be9@linaro.org> Date: Wed, 13 Sep 2023 12:04:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva CMC board Content-Language: en-US To: yangchen.openbmc@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: patrick@stwcx.xyz, Jerry.Lin@quantatw.com, Eddie.Chen@quantatw.com, EasonChen1@quantatw.com References: <20230912140532.3797736-1-yangchen.openbmc@gmail.com> <20230912140532.3797736-3-yangchen.openbmc@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230912140532.3797736-3-yangchen.openbmc@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/09/2023 16:05, yangchen.openbmc@gmail.com wrote: > From: Yang Chen > > Add linux device tree entry related to the Minerva Chassis Management > Controller (CMC) specific devices connected to the Aspeed SoC (AST2600). > > Signed-off-by: Yang Chen > --- > arch/arm/boot/dts/aspeed/Makefile | 1 + > .../aspeed-bmc-facebook-minerva-cmc.dts | 265 ++++++++++++++++++ > 2 files changed, 266 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva-cmc.dts > > diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/ > + > +&i2c15 { > + status = "okay"; > + > + eeprom@50 { > + compatible = "atmel,24c128"; > + reg = <0x50>; > + }; > +}; > + > +&adc0 { > + ref_voltage = <2500>; There is no such property in the bindings. > + status = "okay"; > + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default > + &pinctrl_adc2_default &pinctrl_adc3_default > + &pinctrl_adc4_default &pinctrl_adc5_default > + &pinctrl_adc6_default &pinctrl_adc7_default>; > +}; > + > +&adc1 { > + ref_voltage = <2500>; NAK, there is no such property. Best regards, Krzysztof