Re: [PATCH 2/2] arm64/dts/blaize: Enable Ethernet on CB2 board

[Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>]

On 11/07/2025 14:51, Krzysztof Kozlowski wrote:
> On 11/07/2025 15:36, Nikolaos Pasaloukos wrote:
>> Use the Synopsys gigabit Ethernet controller on the Blaize BLZP1600
>> SoC to provide Ethernet connectivity using the TI DP83867 PHY which is
>> available on the CB2 board via an RJ45 connector.
>>
>> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
>> ---
>>   arch/arm64/boot/dts/blaize/blaize-blzp1600-cb2.dts | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/blaize/blaize-blzp1600-cb2.dts b/arch/arm64/boot/dts/blaize/blaize-blzp1600-cb2.dts
>> index fb5415eb347a028fc65090027a4c4fc89c8280f5..cbe8f0930ad3741b0e770dd7d494931e3b939815 100644
>> --- a/arch/arm64/boot/dts/blaize/blaize-blzp1600-cb2.dts
>> +++ b/arch/arm64/boot/dts/blaize/blaize-blzp1600-cb2.dts
>> @@ -6,6 +6,7 @@
>>   /dts-v1/;
>>   
>>   #include "blaize-blzp1600-som.dtsi"
>> +#include <dt-bindings/net/ti-dp83867.h>
>>   
>>   / {
>>   	model = "Blaize BLZP1600 SoM1600P CB2 Development Board";
>> @@ -14,6 +15,7 @@ / {
>>   
>>   	aliases {
>>   		serial0 = &uart0;
>> +		ethernet = &gmac;
>>   	};
>>   
>>   	chosen {
>> @@ -117,3 +119,23 @@ &gpio0 {
>>   			  "BOARD_ID_1",		/* GPIO_30 */
>>   			  "BOARD_ID_2";		/* GPIO_31 */
>>   };
>> +
>> +&gmac {
> Are you sure you follow DTS coding style? Which sorting rule is used by
> Blaize?

Hi Krzysztof,

First of all, thank you for your fast review. Apologies that I missed
that I missed that one, it was meant to be alphabetical, so above the
gpio0 section. Thanks for catching that.

>
>> +	status = "okay";
>> +	snps,reset-delays-us = <0 10000 50000>;
>> +	snps,reset-gpio = <&gpio0 12 GPIO_ACTIVE_LOW>;
> Do not use deprecated properties. This is new code, not legacy.
>
>
> Best regards,
> Krzysztof

Thanks, I'll remove those.

Best regards,
Niko