From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D691C433EF for ; Sat, 2 Apr 2022 01:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232907AbiDBBjL (ORCPT ); Fri, 1 Apr 2022 21:39:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbiDBBjK (ORCPT ); Fri, 1 Apr 2022 21:39:10 -0400 Received: from mail-m17637.qiye.163.com (mail-m17637.qiye.163.com [59.111.176.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E12E21A8C0C for ; Fri, 1 Apr 2022 18:37:19 -0700 (PDT) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id DB99998029A; Sat, 2 Apr 2022 09:37:17 +0800 (CST) Message-ID: <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> Date: Sat, 2 Apr 2022 09:37:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer , Piotr Oniszczuk Cc: dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220401125205.GL4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRodS0JWTBpMH08dHx hMTUpMVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MhA6HAw5Pj5WQgNOHU8QOAtW ExkKFDxVSlVKTU9DQ01IT0hDT0pLVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBT0tOTDcG X-HM-Tid: 0a7fe7eb6580d992kuwsdb99998029a Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sacha: On 4/1/22 20:52, Sascha Hauer wrote: > -- > >From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001 > From: Sascha Hauer > Date: Fri, 1 Apr 2022 14:48:49 +0200 > Subject: [PATCH] fixup! drm: rockchip: Add VOP2 driver > > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index 7dba7b9b63dc6..1421bf2f133f1 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -2287,6 +2287,20 @@ static int vop2_create_crtc(struct vop2 *vop2) > } > } > > + if (vop2->data->soc_id == 3566) { > + /* > + * On RK3566 these windows don't have an independent > + * framebuffer. They share the framebuffer with smart0, > + * esmart0 and cluster0 respectively. > + */ > + switch (win->data->phys_id) { > + case ROCKCHIP_VOP2_SMART1: > + case ROCKCHIP_VOP2_ESMART1: > + case ROCKCHIP_VOP2_CLUSTER1: > + continue; > + } Think about this , there maybe other upcoming vop2 base soc, they may only have mirror window Smart1 Esmart1, or Smart1, Esmart1, Esmart2, Cluster1. I think this should add WIN_FEATURE at the platform description file rockchip_vop2_reg.c, then check the FEATURE to decide whether the driver should give this window a special treatment. this can make one code run for different soc with different platform description. or we should add the same code logic for different soc again and again. > + } > + > if (win->type == DRM_PLANE_TYPE_OVERLAY) > possible_crtcs = (1 << nvps) - 1; >