From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58F21188CCA; Mon, 25 Nov 2024 08:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732524896; cv=none; b=bPrYIpGFgG4op6ajMgzp2fhngDT3L1Cyk2tVrzqhjucm7p+5iV6pw3xsZM8CjmgETm7R3Yno/NpuYgYS5/u5NCWIlOMd5AD5WLL+Wzkr000unFRUUXhtUwosL8j7i9oesNEefYEGIysDjSgW1yxGMUEVmYq8T8F1Th1IQ9fIJzw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732524896; c=relaxed/simple; bh=iaNsWPWDjcGFwI1ZyeF+SqRDiyySO+8B77jMM1quNVw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=C/347GksjkHhlDESD3rx/cn8kRr3c/UHNwLL6h0uPeyE57MX61NJF+5a1HuEkhN3xOsaGm78FyH61urMBBoqzEQaSrOvFNXaERAfXATfAiC6ac3OIteRKStORzu1Yhswak/jLgWz2HL0kZqxgYbhPs7Qkjt8ZLYkGSwo8gyblH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TkAg04s8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TkAg04s8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE0F6C4CECE; Mon, 25 Nov 2024 08:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732524895; bh=iaNsWPWDjcGFwI1ZyeF+SqRDiyySO+8B77jMM1quNVw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=TkAg04s8jG1zM/3NgskqWuiq89y82n2+DnTv4Y5F8c6Tl0dvIHr5jd8saK0m7Vq/f 9pL33pp8aixuFfMf7XIGzkZdhNrtDid1cz8JqwWauZp+Q76qJBQRdy3wxWpI0pfRbu XeYzRkY3Npw1NSvv7LONKopwu9B5PYI2gt+EV86iMv+neiNNz/X9rEVSK+SjNNwDDh mQDJsAW7CUOimXKK4dwzB9H94U2DwFsBDa0LRQgvFBMT/iU9oQzTY6mssYkeLej8JZ tF1gAa7/OUwU3gq+lrK8FmNmGYHwo666FYOi9QKzdlTXKEFlA43B7Hg/wXJDQLvM2l V4S45yeIZXCKg== Message-ID: <1c1604b7-baf2-466d-a46c-4ed8d407ed9c@kernel.org> Date: Mon, 25 Nov 2024 09:54:48 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] dt-bindings: mfd: Add properties for thermal sensor cells From: Krzysztof Kozlowski To: Guenter Roeck , "Sung-Chi, Li" Cc: Conor Dooley , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benson Leung , Guenter Roeck , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Jean Delvare , devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org References: <20241111074904.1059268-1-lschyi@chromium.org> <20241113024000.3327161-1-lschyi@chromium.org> <20241113024000.3327161-2-lschyi@chromium.org> <4efe981f-f7ae-41c7-9c12-2aa3a5d2d046@roeck-us.net> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/11/2024 09:52, Krzysztof Kozlowski wrote: > On 13/11/2024 04:05, Guenter Roeck wrote: >> On 11/12/24 18:39, Sung-Chi, Li wrote: >>> The cros_ec supports reading thermal values from thermal sensors >>> connect to it. Add the property '#thermal-sensor-cells' bindings, such >>> that thermal framework can recognize cros_ec as a valid thermal device. >>> >>> Signed-off-by: Sung-Chi, Li >>> Acked-by: Conor Dooley >>> --- >>> Changes in v2: >>> - Add changes for DTS binding. >>> Changes in v3: >>> - Remove unneeded Change-Id tag in commit message. >>> --- >> >> I can't apply this one (not in hwmon space), so >> >> Acked-by: Guenter Roeck >> >> with the assumption that Lee will pick it up. > > This was merged, while I was AFK, so the ship has sailed, but let me > state here objection for any future discussions: > > NAK, this is not a thermal sensor. The commit msg explains what they > want to achieve, but that's not a valid reason to add property from > different class of devices. > > This is some hardware/temperature monitoring device or power supply, not > part of SoC, not integrated into any SoC thermal zone. Calling it > thermal sensor is huge stretch and inappropriate hardware description > leading to next patches like calling it a SoC cooling device, instead of > simple power supply (for which we have bindings!). Ah, wait, this was not merged, so I can actually NAK it. BTW, all your patches are incorrectly ordered - bindings are always before the users. You cannot merge user of a binding without or before the binding. Best regards, Krzysztof