From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28CB2C61DA4 for ; Mon, 30 Jan 2023 10:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236508AbjA3Kki (ORCPT ); Mon, 30 Jan 2023 05:40:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236406AbjA3Kkg (ORCPT ); Mon, 30 Jan 2023 05:40:36 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A007231E0A for ; Mon, 30 Jan 2023 02:40:31 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id ml19so6851844ejb.0 for ; Mon, 30 Jan 2023 02:40:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9kc6I1359RoE5LlagdMh40JI0vcHr0CmwGbe7Q8JXFM=; b=H0yZL3VYQZ83z33kQaKsKHYh7TtYbnJ7ePgHgj0UzD4P0evBaqxQ+qliIL2XRomygE 2NSHf6JUFZtkcsQ4q9YxVcyMCwrfyS9LRcDpCMNW7SRBSVCCDDlhfY0h2NOYG9ebm6uz 0j7P66yQcvOBXY1p0QjaXoiZcApljY5f1eU688G9mxNiT+j+YLUm0xCTtgFKNZcZuEdx J/7/4SFSWroKPtunTG4RiTK71VdBn50LvjSdxdBzw+tSJjCyVup/KGCHrys0LtxnC2s/ 6zNnhcmgwUIksQs/COIRIl8SuIjj7WXPr2eFYJlH2rwCRJQySC1aIzwIUpK00w1QsgUu qf2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9kc6I1359RoE5LlagdMh40JI0vcHr0CmwGbe7Q8JXFM=; b=HPfYRvNKThOKAktablgHggbSauHSXAzNi0dlVBiVwLziny4g5DroYJPE0Qf2s80h1k 5mXINALQOseZTZcwgiC6wJPbaV2wmbYeyoVsxoGxG66EMGo1fmOZBzReqNe0jAsZ9uQe aZGdifWYTF99kXAVvzgCD7S2ScDcg5ahUDh6gofEO4sAZDjA55lrqp4bUuUf/zYjEI6N /d47XzfHsbLlj/FKQ/XJj+RSrZgvcu+w44HNLPPYGsEA+mAxzA8nudxIJaAaziUE06Er lN9pFv1BG54g4hCZCSkxhGhr0TWhWQaQTgK5A8FT9IhtmMhzfOKwDPxVMk5/CjNlQ/b2 rITQ== X-Gm-Message-State: AO0yUKVuJj7BNax1V6m5f2XtNHYxk2u1PP5OEbDF20/sg8i6PkoROtMj mtaE8G8P1kJQ+vPons9Wx9faKA== X-Google-Smtp-Source: AK7set/AJuBGbDmv+sBY9HFIcNMeCDuQiJiiSkIPW1J59QfKA/JmFSiWxukLndseHdEZ2IauKfP4tw== X-Received: by 2002:a17:906:4dda:b0:888:bbb2:c726 with SMTP id f26-20020a1709064dda00b00888bbb2c726mr2768714ejw.33.1675075230160; Mon, 30 Jan 2023 02:40:30 -0800 (PST) Received: from [192.168.1.101] (abyl20.neoplus.adsl.tpnet.pl. [83.9.31.20]) by smtp.gmail.com with ESMTPSA id lb12-20020a170907784c00b008841aa86484sm3266144ejc.211.2023.01.30.02.40.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 02:40:29 -0800 (PST) Message-ID: <1c3fa66b-651f-c3c1-1751-af3f43c86c49@linaro.org> Date: Mon, 30 Jan 2023 11:40:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 5/7] arm64: dts: qcom: sm8450-hdk: add pmic glink node To: Neil Armstrong , Heikki Krogerus , Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-5-0b0acfad301e@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20230130-topic-sm8450-upstream-pmic-glink-v1-5-0b0acfad301e@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30.01.2023 10:54, Neil Armstrong wrote: > Add the pmic glink node linked with the DWC3 USB controller > switched to OTG mode and tagged with usb-role-switch. > > Signed-off-by: Neil Armstrong Missing commit message > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 34 ++++++++++++++++++++++++++++++++- > 1 file changed, 33 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > index 5bdc2c1159ae..5ab12c911bfe 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > @@ -87,6 +87,31 @@ lt9611_3v3: lt9611-3v3-regulator { > enable-active-high; > }; > > + pmic-glink { > + compatible = "qcom,sm8450-pmic-glink", "qcom,pmic-glink"; > + You could remove this newline > + #address-cells = <1>; > + #size-cells = <0>; > + > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + power-role = "dual"; > + data-role = "dual"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; And add one here > + port@0 { > + reg = <0>; And here > + pmic_glink_dwc3_in: endpoint { > + remote-endpoint = <&usb_1_dwc3_out>; > + }; > + }; > + }; > + }; > + }; > + > vph_pwr: vph-pwr-regulator { > compatible = "regulator-fixed"; > regulator-name = "vph_pwr"; > @@ -724,7 +749,14 @@ &usb_1 { > }; > > &usb_1_dwc3 { > - dr_mode = "peripheral"; > + dr_mode = "otg"; > + usb-role-switch; > + > + port { Hm, maybe this could be moved to 8450 dtsi? Konrad > + usb_1_dwc3_out: endpoint { > + remote-endpoint = <&pmic_glink_dwc3_in>; > + }; > + }; > }; > > &usb_1_hsphy { >