From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema
Date: Wed, 28 May 2025 10:02:44 +0200 [thread overview]
Message-ID: <1c7e9077-c213-40a9-92f4-07e813a3d151@kernel.org> (raw)
In-Reply-To: <20250523-davinci-mmc-v1-1-ceebd8352d9c@gmail.com>
On 23/05/2025 15:34, Charan Pedumuru wrote:
> Convert TI Highspeed MMC host controller binding to YAML format. Add
> 'clocks' property to resolve errors identified by 'dtb_check'.
>
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
> ---
> .../devicetree/bindings/mmc/davinci_mmc.txt | 32 -----------
> .../devicetree/bindings/mmc/ti,da830-mmc.yaml | 62 ++++++++++++++++++++++
> 2 files changed, 62 insertions(+), 32 deletions(-)
>
A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
"convert to DT Schema"
...
> +
> +allOf:
> + - $ref: mmc-controller.yaml
> +
> +maintainers:
> + - Rob Herring <robh@kernel.org>
No, I really doubt Rob cares about this hardware.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,da830-mmc
> + - ti,dm355-mmc
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 2
> +
This wasn't in original binding. You need to document this in the commit
msg. Also, list the items.
> + dmas:
> + maxItems: 2
> +
> + dma-names:
> + items:
> + - const: rx
> + - const: tx
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
why interrupts are required?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-28 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 13:34 [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema Charan Pedumuru
2025-05-23 15:44 ` Conor Dooley
2025-05-28 8:02 ` Krzysztof Kozlowski [this message]
2025-07-12 8:22 ` Charan Pedumuru
2025-07-12 8:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c7e9077-c213-40a9-92f4-07e813a3d151@kernel.org \
--to=krzk@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).