devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com,
	tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com,
	yijie.yang@oss.qualcomm.com, Qiang Yu <qiang.yu@oss.qualcomm.com>
Subject: Re: [PATCH 04/20] arm64: dts: qcom: kaanapali: Add support for PCIe0 on Kaanapali
Date: Thu, 25 Sep 2025 12:56:08 +0200	[thread overview]
Message-ID: <1c8ae43d-ceba-499d-abe9-8014dab5087d@oss.qualcomm.com> (raw)
In-Reply-To: <20250924-knp-dts-v1-4-3fdbc4b9e1b1@oss.qualcomm.com>

On 9/25/25 2:17 AM, Jingyi Wang wrote:
> From: Qiang Yu <qiang.yu@oss.qualcomm.com>
> 
> Describe PCIe0 controller and PHY. Also add required system resources like
> regulators, clocks, interrupts and registers configuration for PCIe0.
> 
> Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---

[...]

> +
> +			pcieport0: pcie@0 {

"pcie0_port0:"

> +				device_type = "pci";
> +				reg = <0x0 0x0 0x0 0x0 0x0>;
> +				bus-range = <0x01 0xff>;
> +
> +				#address-cells = <3>;
> +				#size-cells = <2>;
> +				ranges;
> +				phys = <&pcie0_phy>;

how about:

device_type = "pci";
reg = <0x0 0x0 0x0 0x0 0x0>;
bus-range = <0x01 0xff>;

phys = <&pcie0_phy>;

#address-cells = <3>;
#size-cells = <2>;
ranges;

with that:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  reply	other threads:[~2025-09-25 10:56 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25  0:17 [PATCH 00/20] arm64: dts: qcom: Introduce Kaanapali platform device tree Jingyi Wang
2025-09-25  0:17 ` [PATCH 01/20] dt-bindings: arm: qcom: Document Kaanapali SoC and its reference boards Jingyi Wang
2025-10-06  9:54   ` Krzysztof Kozlowski
2025-10-06 10:24     ` Krzysztof Kozlowski
2025-10-14  5:13       ` Jingyi Wang
2025-09-25  0:17 ` [PATCH 02/20] arm64: dts: qcom: Introduce Kaanapali SoC Jingyi Wang
2025-09-25  3:22   ` Dmitry Baryshkov
2025-10-14 16:43     ` Taniya Das
2025-10-14 11:46   ` Akhil P Oommen
2025-11-04  9:04     ` Jingyi Wang
2025-11-04 12:54       ` Konrad Dybcio
2025-11-05  7:30         ` Jingyi Wang
2025-11-05 10:13           ` Konrad Dybcio
2025-11-20  6:53   ` Komal Bajaj
2025-11-20  7:22     ` Jingyi Wang
2025-09-25  0:17 ` [PATCH 03/20] arm64: dts: qcom: kaanapali: Add base MTP board Jingyi Wang
2025-09-25  3:18   ` Dmitry Baryshkov
2025-09-25  7:17     ` Aiqun(Maria) Yu
2025-09-25  9:44   ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 04/20] arm64: dts: qcom: kaanapali: Add support for PCIe0 on Kaanapali Jingyi Wang
2025-09-25 10:56   ` Konrad Dybcio [this message]
2025-10-06 14:23   ` Krzysztof Kozlowski
2025-10-07  1:24     ` Dmitry Baryshkov
2025-10-07  1:46       ` Krzysztof Kozlowski
2025-10-08 19:04         ` Dmitry Baryshkov
2025-09-25  0:17 ` [PATCH 05/20] arm64: dts: qcom: kaanapali: Add SDC2 nodes for Kaanapali soc Jingyi Wang
2025-09-25  0:17 ` [PATCH 06/20] arm64: dts: qcom: kaanapali: Add USB support for Kaanapali SoC Jingyi Wang
2025-09-25  1:50   ` Krzysztof Kozłowski
2025-09-25  7:39     ` Aiqun(Maria) Yu
2025-09-25  8:24       ` Krzysztof Kozłowski
2025-09-25  8:32       ` Krzysztof Kozlowski
2025-09-25  9:01         ` Krzysztof Kozlowski
2025-09-25 16:49           ` Dmitry Baryshkov
2025-09-25 18:26       ` Trilok Soni
2025-09-26 13:04         ` Konrad Dybcio
2025-09-25 13:57     ` Bjorn Andersson
2025-09-25 14:12       ` Krzysztof Kozlowski
2025-09-25 21:31       ` Rob Herring
2025-09-26 13:21         ` Konrad Dybcio
2025-09-26 14:47           ` Rob Herring
2025-09-29  6:06             ` Aiqun(Maria) Yu
2025-09-29  7:19               ` Dmitry Baryshkov
2025-09-25  3:20   ` Dmitry Baryshkov
2025-09-25  7:49     ` Aiqun(Maria) Yu
2025-09-25  9:46       ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 07/20] arm64: dts: qcom: kaanapali: Add remoteprocs " Jingyi Wang
2025-09-30 17:24   ` Alexey Klimov
2025-11-04  8:59     ` Jingyi Wang
2025-11-04 10:01       ` Kumari Pallavi
2025-11-04 13:25         ` Alexey Klimov
2025-09-25  0:17 ` [PATCH 08/20] arm64: dts: qcom: Add PMK8850 pmic dtsi Jingyi Wang
2025-09-25 12:20   ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 09/20] arm64: dts: qcom: Add PMH0101 " Jingyi Wang
2025-09-25 12:20   ` Konrad Dybcio
2025-10-09 13:47     ` Jishnu Prakash
2025-09-25  0:17 ` [PATCH 10/20] arm64: dts: qcom: Add PMH0104 " Jingyi Wang
2025-09-25  7:59   ` Krzysztof Kozlowski
2025-09-25 12:21     ` Konrad Dybcio
2025-09-29  6:51       ` Aiqun(Maria) Yu
2025-09-25  0:17 ` [PATCH 11/20] arm64: dts: qcom: Add PMH0110 " Jingyi Wang
2025-09-25  0:17 ` [PATCH 12/20] arm64: dts: qcom: kaanapali: Add misc features Jingyi Wang
2025-09-25  0:17 ` [PATCH 13/20] arm64: dts: qcom: kaanapali: Add QUPv3 configuration for serial engines Jingyi Wang
2025-09-25 12:28   ` Konrad Dybcio
2025-09-25 13:19     ` Krzysztof Kozlowski
2025-09-29  3:05       ` Jingyi Wang
2025-09-29  5:42     ` Jingyi Wang
2025-09-29  6:41     ` Aiqun(Maria) Yu
2025-09-29 13:11       ` Konstantin Ryabitsev
2025-09-30  2:14         ` Aiqun(Maria) Yu
2025-09-25  0:17 ` [PATCH 14/20] arm64: dts: qcom: kaanapali-mtp: Enable more features Jingyi Wang
2025-09-25  2:09   ` Dmitry Baryshkov
2025-09-25  9:48     ` Konrad Dybcio
2025-09-26  9:11     ` Ronak Raheja
2025-09-26 11:44       ` Konrad Dybcio
2025-09-26 13:46       ` Dmitry Baryshkov
2025-09-29  3:24     ` Jingyi Wang
2025-09-25  8:03   ` Eugen Hristev
2025-10-09 13:54     ` Jishnu Prakash
2025-10-09 14:58       ` Eugen Hristev
2025-10-09 16:28         ` Dmitry Baryshkov
2025-10-10 10:54           ` Jishnu Prakash
2025-10-10 14:02             ` Eugen Hristev
2025-10-13 16:21               ` Kamal Wadhwa
2025-09-25  0:17 ` [PATCH 15/20] arm64: dts: qcom: kaanapali-mtp: Enable modem Jingyi Wang
2025-09-25  2:10   ` Dmitry Baryshkov
2025-09-29  3:28     ` Jingyi Wang
2025-09-25 14:06   ` Bjorn Andersson
2025-09-29  3:29     ` Jingyi Wang
2025-09-25  0:17 ` [PATCH 16/20] arm64: dts: qcom: kaanapali: Add QRD board Jingyi Wang
2025-09-25  2:15   ` Dmitry Baryshkov
2025-09-29  3:29     ` Jingyi Wang
2025-09-25  0:17 ` [PATCH 17/20] arm64: dts: qcom: kaanapali: Add support for audio Jingyi Wang
2025-09-25 12:30   ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 18/20] arm64: dts: qcom: kaanapali-mtp: Add audio support (WSA8845, WCD9395, DMIC) Jingyi Wang
2025-09-25 12:30   ` Konrad Dybcio
2025-09-25 13:26   ` Krzysztof Kozlowski
2025-09-30 12:06     ` Prasad Kumpatla
2025-10-06  8:48       ` Krzysztof Kozlowski
2025-10-08 10:20         ` Konrad Dybcio
2025-10-08 10:51           ` Krzysztof Kozlowski
2025-10-08 11:30             ` Konrad Dybcio
2025-10-08 23:50               ` Krzysztof Kozlowski
2025-10-27  9:39                 ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 19/20] arm64: dts: qcom: kaanapali: Add support for camss Jingyi Wang
2025-09-25  0:17 ` [PATCH 20/20] arm64: dts: qcom: kaanapali: Add iris video node Jingyi Wang
2025-10-07  2:17   ` Krzysztof Kozlowski
2025-10-08  8:30   ` Konrad Dybcio
2025-09-25 14:12 ` [PATCH 00/20] arm64: dts: qcom: Introduce Kaanapali platform device tree Rob Herring (Arm)
2025-09-25 16:51   ` Dmitry Baryshkov
2025-09-30 17:48 ` Alexey Klimov
2025-10-03  9:09   ` Prasad Kumpatla
2025-10-03 16:35     ` Alexey Klimov
2025-10-14  6:09       ` Jingyi Wang
2025-12-02 18:21 ` Pavel Machek
2025-12-02 18:33   ` Konrad Dybcio
2025-12-02 20:56     ` Pavel Machek
2025-12-03 10:34       ` Konrad Dybcio
2025-12-03 16:17         ` Pavel Machek
2025-12-03 17:31   ` Krzysztof Kozlowski
2025-12-03 18:10     ` Pavel Machek
2025-12-03 18:40       ` Krzysztof Kozlowski
2025-12-03 18:41         ` Krzysztof Kozlowski
2025-12-04  9:09           ` Pavel Machek
2025-12-04 10:41             ` Krzysztof Kozlowski
2025-12-04 11:42               ` Pavel Machek
2025-12-04 12:10                 ` Krzysztof Kozlowski
2025-12-04 12:26                   ` Pavel Machek
2025-12-04  9:14         ` Pavel Machek
2025-12-04 10:42           ` Krzysztof Kozlowski
2025-12-04 11:44             ` Pavel Machek
2025-12-04 12:07               ` Krzysztof Kozlowski
2025-12-04  2:41   ` Jingyi Wang
2025-12-04  8:56     ` Pavel Machek
2025-12-04  9:01       ` Krzysztof Kozlowski
2025-12-04  9:06         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c8ae43d-ceba-499d-abe9-8014dab5087d@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=aiqun.yu@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qiang.yu@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=trilok.soni@oss.qualcomm.com \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).