From: Frank Binns <Frank.Binns@imgtec.com>
To: "conor@kernel.org" <conor@kernel.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
Sarah Walker <Sarah.Walker@imgtec.com>
Cc: "luben.tuikov@amd.com" <luben.tuikov@amd.com>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"mripard@kernel.org" <mripard@kernel.org>,
"hns@goldelico.com" <hns@goldelico.com>,
"afd@ti.com" <afd@ti.com>, "daniel@ffwll.ch" <daniel@ffwll.ch>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"boris.brezillon@collabora.com" <boris.brezillon@collabora.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dakr@redhat.com" <dakr@redhat.com>,
"matthew.brost@intel.com" <matthew.brost@intel.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
Donald Robson <Donald.Robson@imgtec.com>,
"faith.ekstrand@collabora.com" <faith.ekstrand@collabora.com>
Subject: Re: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU
Date: Tue, 18 Jul 2023 11:36:03 +0000 [thread overview]
Message-ID: <1cb4f6b57f0826377f0aef85a8abcf0b5f51c07c.camel@imgtec.com> (raw)
In-Reply-To: <4131759e-9474-48f6-cc05-67b6d4b6559b@linaro.org>
Hi Krzysztof,
On Tue, 2023-07-18 at 13:10 +0200, Krzysztof Kozlowski wrote:
> On 18/07/2023 13:08, Frank Binns wrote:
> > > And this
> > > items:
> > > - const: gpu
> > > can just be
> > > const: gpu
> > >
> > > Although, if there is only one interrupt this is probably not
> > > particularly helpful. Are there other implementations of this IP that
> > > have more interrupts?
> >
> > No, all our current GPUs just have a single interrupt. I assume it's more future
> > proof to keep the name in case that ever changes?
>
> Why do you need name in the first place? If there is single entry, the
> name is pointless, especially if it repeats the name of the IP block.
>
> > As in, by having the name now
> > we can make it a required property, which I guess we won't be able to do at some
> > later point.
>
> Why even making it required?
It seems nicer to look up a resource in the driver based on a name rather than
an index. Happy to drop it though.
Thanks
Frank
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-07-18 11:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 14:25 [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU Sarah Walker
2023-07-15 10:40 ` Conor Dooley
2023-07-18 11:08 ` Frank Binns
2023-07-18 11:10 ` Krzysztof Kozlowski
2023-07-18 11:24 ` mripard
2023-07-18 11:36 ` Frank Binns [this message]
2023-07-18 11:52 ` Krzysztof Kozlowski
2023-07-17 7:29 ` Krzysztof Kozlowski
2023-07-18 11:32 ` Frank Binns
2023-07-18 13:06 ` Krzysztof Kozlowski
2023-07-18 6:20 ` Krzysztof Kozlowski
2023-07-18 11:47 ` Frank Binns
2023-07-18 11:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cb4f6b57f0826377f0aef85a8abcf0b5f51c07c.camel@imgtec.com \
--to=frank.binns@imgtec.com \
--cc=Donald.Robson@imgtec.com \
--cc=Sarah.Walker@imgtec.com \
--cc=afd@ti.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=hns@goldelico.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luben.tuikov@amd.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).