From: Randy Dunlap <rdunlap@infradead.org>
To: "LH.Kuo" <lhjeff911@gmail.com>,
ulf.hansson@linaro.org, p.zabel@pengutronix.de,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org
Cc: dvorkin@tibbo.com, qinjian@cqplus1.com, wells.lu@sunplus.com,
"LH.Kuo" <lh.kuo@sunplus.com>
Subject: Re: [PATCH 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021
Date: Fri, 29 Oct 2021 17:00:33 -0700 [thread overview]
Message-ID: <1cb5c303-5cba-cd3a-e73d-9e5535e3ab83@infradead.org> (raw)
In-Reply-To: <1635487055-18494-2-git-send-email-lh.kuo@sunplus.com>
On 10/28/21 10:57 PM, LH.Kuo wrote:
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 95b3511..6f8bcd6 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -14,6 +14,16 @@ config MMC_DEBUG
> added host drivers please don't invent their private macro for
> debugging.
>
> +config SP_SDV2
> + tristate "Sunplus SP7021 SD/SDIO Controller"
> + depends on SOC_SP7021
> + default m
> + help
> + This selects the Sunplus SP7021 SD/SDIO controller.
> + If you have a controller with this interface, say Y or M here..
> +
> + If unsure, say N.
Hi,
Does SOC_SP7021 require this driver to be built in order
to boot?
If not, please remove the "default m" line.
Also, several of your patches seem to have lots of line
changes to the MAINTAINERS file, but it looks like they
should not be part of your patch submission.
thanks.
--
~Randy
next prev parent reply other threads:[~2021-10-30 0:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 5:57 [PATCH 0/2] Add SD/SDIO control driver for Sunplus SP7021 SoC LH.Kuo
2021-10-29 5:57 ` [PATCH 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021 LH.Kuo
2021-10-30 0:00 ` Randy Dunlap [this message]
2021-11-02 14:34 ` Philipp Zabel
2021-10-29 5:57 ` [PATCH 2/2] devicetree bindings mmc Add bindings doc " LH.Kuo
2021-11-09 7:58 ` [PATCH v2 0/2] Add SD/SDIO control driver for Sunplus SP7021 SoC LH.Kuo
2021-11-09 7:58 ` [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021 LH.Kuo
2021-11-10 2:33 ` Randy Dunlap
[not found] ` <d25f2bff024b40fd9691960221c0bebe@sphcmbx02.sunplus.com.tw>
2021-11-10 5:44 ` Randy Dunlap
2021-11-09 7:58 ` [PATCH v2 2/2] devicetree bindings mmc Add bindings doc " LH.Kuo
2021-11-29 1:37 ` Rob Herring
[not found] ` <f5607fa7ad9c49a7bfcce02eac834838@sphcmbx02.sunplus.com.tw>
2021-11-29 16:29 ` Rob Herring
[not found] ` <1eb97e1aca9c4c8d8f1e17c51f2792ac@sphcmbx02.sunplus.com.tw>
2022-01-04 20:31 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cb5c303-5cba-cd3a-e73d-9e5535e3ab83@infradead.org \
--to=rdunlap@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=dvorkin@tibbo.com \
--cc=lh.kuo@sunplus.com \
--cc=lhjeff911@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).