From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
James Hogan <jhogan@kernel.org>,
Paul Burton <paul.burton@mips.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Allan Nielsen <allan.nielsen@microsemi.com>
Subject: Re: [PATCH v2 1/6] i2c: designware: use generic table matching
Date: Tue, 31 Jul 2018 17:53:17 +0300 [thread overview]
Message-ID: <1cbe4c184a0a6db1fc5401dbd8bd3a9f6bf22527.camel@linux.intel.com> (raw)
In-Reply-To: <20180731143059.GV28585@piout.net>
On Tue, 2018-07-31 at 16:30 +0200, Alexandre Belloni wrote:
> On 31/07/2018 17:23:04+0300, Andy Shevchenko wrote:
> > On Tue, 2018-07-31 at 17:02 +0300, Andy Shevchenko wrote:
> > > On Tue, 2018-07-31 at 15:47 +0200, Alexandre Belloni wrote:
> > > > + dev->flags |= (u32)device_get_match_data(&pdev->dev);
> > > > +
> >
> > And since it would be changed anyway, can you actually move this
> > line
> > closet to if (has_acpi_companion()) one ?
> >
>
> I need that value to be set before calling of_configure though.
AFAICS, you added those lines later, so, it would be something like
dev->flags |= ...
if (of_node)
of_configure()
if (has_acpi_companion())
acpi_configure()
Would it work for you?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-07-31 14:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 13:47 [PATCH v2 0/6] Add support for MSCC Ocelot i2c Alexandre Belloni
2018-07-31 13:47 ` [PATCH v2 1/6] i2c: designware: use generic table matching Alexandre Belloni
2018-07-31 14:02 ` Andy Shevchenko
2018-07-31 14:23 ` Andy Shevchenko
2018-07-31 14:30 ` Alexandre Belloni
2018-07-31 14:53 ` Andy Shevchenko [this message]
2018-07-31 18:44 ` Alexandre Belloni
2018-07-31 20:41 ` Alexandre Belloni
2018-07-31 13:47 ` [PATCH v2 2/6] i2c: designware: move #ifdef CONFIG_OF to the top Alexandre Belloni
2018-07-31 14:04 ` Andy Shevchenko
2018-07-31 13:47 ` [PATCH v2 3/6] i2c: designware: allow IP specific sda_hold_time Alexandre Belloni
2018-07-31 13:47 ` [PATCH v2 4/6] i2c: designware: add MSCC Ocelot support Alexandre Belloni
2018-07-31 14:13 ` Andy Shevchenko
2018-07-31 13:47 ` [PATCH v2 5/6] mips: dts: mscc: Add i2c on ocelot Alexandre Belloni
2018-07-31 13:47 ` [PATCH v2 6/6] mips: dts: mscc: enable i2c on ocelot_pcb123 Alexandre Belloni
2018-07-31 14:17 ` [PATCH v2 0/6] Add support for MSCC Ocelot i2c Andy Shevchenko
2018-07-31 14:29 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cbe4c184a0a6db1fc5401dbd8bd3a9f6bf22527.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microsemi.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jhogan@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mika.westerberg@linux.intel.com \
--cc=paul.burton@mips.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).