From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0888C77B73 for ; Tue, 30 May 2023 14:04:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231966AbjE3OEK (ORCPT ); Tue, 30 May 2023 10:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232813AbjE3OEJ (ORCPT ); Tue, 30 May 2023 10:04:09 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90CC2C5 for ; Tue, 30 May 2023 07:04:07 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-96ff9c0a103so652215666b.0 for ; Tue, 30 May 2023 07:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685455446; x=1688047446; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kAaRAHBvmn5TiFi21og9H3c8Ufuxifop3fwjLkOCVes=; b=Aek8BtY/hryhXWGyso4A1d8LRPMyM1i6oQXslgfxRZnF8cAliqg5ePF4ytNdN3E+o6 WmS0KpTrdb3r9/kUbqLGU09/wzgYaICG31s/pkSXtBRptvvmnm0O3TN+lcBEOJfNyQJw Jyo2qk66nTv4MIvWjps71q6cdC0XZ5627vivMGlIpQg4f2iwaUCKoZOPqxJSEA+cUqme 7SLaLmXWpBAVoIJTMzfnNHlWJ7YVzvolgK82JIQUgFSaHUaikPkTgbkYT3r1izuzCR9C 75Yr1WaVTrV4AvNAMD1ft0m7sL8mFg0r8vukhZyV6EL86xe1Oxzd2StmJY2OC4/ZSeUv gjig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685455446; x=1688047446; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kAaRAHBvmn5TiFi21og9H3c8Ufuxifop3fwjLkOCVes=; b=iAA1gi1T6e7kxCoRRDuiAayMFiyntfYAIC5TviWmY+V2sLB2+dROXNll5XHN6vInFE nBSGKsQFn/mFUTotDoVycQKkTcbXDbkfa7E1Hvmw7Y2a3GugdyCN2zQce4ABUxOJ51Ap ekrzblAK7rNR2+wlFsEYmlH3ZPMNsQ3Abj+s+QCGzQyTjg+/GgrHI1IW6AqNG1A3ICoR 25Hs8l3WlHAcsG+bH8o+pHCHwfHHUeDinLXDRFGmY6N4pWewNVmz4kQ5TFxvLluqsyOs p7gjnQ1gkK2V/UcxNhJHF2SFC5x8ivA4eCtgt94SPIq+bfdvtFDaxAfPKVRwaNU8KkLC KBkQ== X-Gm-Message-State: AC+VfDx6g9q/kOwVAW7SwEp0/mAXUh//YVaZJ2XzI+q2Qhy5wXoEmW25 XGkNtsO+2B9y3vLlJ1VTxCPYNw== X-Google-Smtp-Source: ACHHUZ5eqKSA0S3xLv0PuDvXBu0UeK4GkplmqjpmtXOP8+/T/kVFZMGqkpaNHjXSCThrWsX2lB2TYQ== X-Received: by 2002:a17:907:724b:b0:958:4c75:705e with SMTP id ds11-20020a170907724b00b009584c75705emr2423155ejc.17.1685455446007; Tue, 30 May 2023 07:04:06 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id x15-20020a170906148f00b00969f13d886fsm7439467ejc.71.2023.05.30.07.04.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 07:04:05 -0700 (PDT) Message-ID: <1cce5a11-f182-04b0-0aa3-ed27614a564d@linaro.org> Date: Tue, 30 May 2023 16:04:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/3] dt-bindings: net: pse-pd: Update regex pattern for ethernet-pse nodes To: Oleksij Rempel , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org References: <20230530083713.2527380-1-o.rempel@pengutronix.de> <20230530083713.2527380-2-o.rempel@pengutronix.de> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230530083713.2527380-2-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/05/2023 10:37, Oleksij Rempel wrote: > This patch modifies the regex pattern for the $nodename property in the Please do not use "This commit/patch", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > device tree bindings documentation for PSE-PD controllers. The updated > pattern allows for additional node names, including those with a hyphen > followed by a hexadecimal digit. > > Before this change, the pattern ^ethernet-pse(@.*)?$ only allowed for > node names like "ethernet-pse" or "ethernet-pse@1". With the new pattern > node names like "ethernet-pse-1" are now also valid. This part is duplicating first paragraph. What you should have here is answer to why we need it. > > Signed-off-by: Oleksij Rempel > --- > .../devicetree/bindings/net/pse-pd/pse-controller.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > index b110abb42597..3548efc2191c 100644 > --- a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > +++ b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > @@ -16,7 +16,7 @@ maintainers: > > properties: > $nodename: > - pattern: "^ethernet-pse(@.*)?$" > + pattern: "^ethernet-pse(@[0-9a-f]+|-([0-9a-f]+))?$" No need for inner () Let's make -N suffix only decimal, as discussed here: https://lore.kernel.org/all/20221123024153.GB1026269-robh@kernel.org/ I will send a patch for other files. > > "#pse-cells": > description: Best regards, Krzysztof