From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCB9C1FBC9B for ; Tue, 4 Mar 2025 07:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741073986; cv=none; b=Lunrt2ai4CPahQdE9OQRr6Ga+INczVvn8JVCvTddfkRewb4MupxttGcspRcKnuWNdrNvlzeKgQ4w31E3KWFeN1JfU8yljEXwyDwqYqS7mZr58fsqcA3ESQ+mSv0b2wb70co15qexjUioehUNmwloOEUD/NXIF9THIjFIZwDTMvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741073986; c=relaxed/simple; bh=gwio5MTnaYoam1IIk8pX9jHyBQVnXqLBGb6yWNDUuls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=X9DC2bad+dH4vGuhwslqCgbihRSfSWzsbXPFtucRTCaJH1HkBdQQj60gHehEN72KcHWxHT1MGHpZWHhC+M5qkTGrU7pl8ta7PBEt1ux7vCQU89WvfySOtuxc96A4SXBPzJzc7v9EqycPh3MRizTQ3o553Cs0AgUqTcAAEWwlLrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=dr5y9w9+; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="dr5y9w9+" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20250304073942euoutp018f7d5b1c70bd8c33ce6039b24a1dac83~piY-zSpyD1810918109euoutp01s for ; Tue, 4 Mar 2025 07:39:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20250304073942euoutp018f7d5b1c70bd8c33ce6039b24a1dac83~piY-zSpyD1810918109euoutp01s DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1741073982; bh=GzMSkEVNv/dhBMxoGFis/biKw7gJZhHvQ1umQcESUMQ=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=dr5y9w9+82Nl7Hl74dx08/pElMvB532QfxZZLrj00qiy/QJS8BRGGGmR1hfdhh3x9 axWUrXWOb8kYqwtbLlt/0x6o3LYjliCnA7tgftsemGbuhLm0T0R+SRlZ+9DpXv+zIZ lCR1E5ek1Oh2Vv9fB7QwymKhk77CgS7ZrqY50B7I= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20250304073941eucas1p1a0cc9b675ced23b32e9c54b705896540~piY-XZA9s2201122011eucas1p1Y; Tue, 4 Mar 2025 07:39:41 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 86.99.20397.D3EA6C76; Tue, 4 Mar 2025 07:39:41 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20250304073941eucas1p2e24f6e10f30d12dd1b12e9b8cff5af62~piY_43N8o0881608816eucas1p2z; Tue, 4 Mar 2025 07:39:41 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250304073941eusmtrp14add939fc3c09839217ed8b74f91543d~piY_38e312919029190eusmtrp1C; Tue, 4 Mar 2025 07:39:41 +0000 (GMT) X-AuditID: cbfec7f5-ed1d670000004fad-c7-67c6ae3db0b9 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 40.43.19654.D3EA6C76; Tue, 4 Mar 2025 07:39:41 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250304073940eusmtip1b08d76bfb85500f4eed21209f94ac1f0~piY98_S7P2723627236eusmtip1S; Tue, 4 Mar 2025 07:39:40 +0000 (GMT) Message-ID: <1cd2f07d-14a1-4a25-8a81-b815f405018e@samsung.com> Date: Tue, 4 Mar 2025 08:39:40 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] dt-bindings: clock: thead: Add TH1520 VO clock controller To: Krzysztof Kozlowski , mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, drew@pdp7.com, guoren@kernel.org, wefu@redhat.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, jszhang@kernel.org, p.zabel@pengutronix.de, m.szyprowski@samsung.com Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Content-Language: en-US From: Michal Wilczynski In-Reply-To: Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNKsWRmVeSWpSXmKPExsWy7djP87q2646lG0xo0rV4ducrq8XW37PY LdbsPcdkMf/IOVaLe5e2MFm82NvIYtF8bD2bxctZ99gszp/fwG7xseceq8XlXXPYLLZ9bmGz WHvkLrvFxVOuFnfvnWCxeHm5h9mibRa/xf89O9gt/l3byGLRsn8Ki4OIx/sbreweb16+ZPE4 3PGF3ePeiWmsHptWdbJ5bF5S79Gy9hiTR/9fA4/3+66yefRtWcXocan5OrvH501yATxRXDYp qTmZZalF+nYJXBnN59QL2vgrlj9Ib2BczNPFyMkhIWAisXv6GaYuRi4OIYEVjBJ/p81ngXC+ MEq8vP6dGcL5zChx8+oF1i5GDrCWrq16EPHljBL97aegit4ySpw5epMNZC6vgJ3Et5PbmEBs FgEVianNc5gh4oISJ2c+YQGxRQXkJe7fmsEOYgsLhEucfbEC7A4RgcdMEm8PfwdrYBaokthx /wY7hC0ucevJfLChbAJGEg+Wz2cFsTmBlv19OY0RokZeYvvbOWAXSQi84pQ48OgcM8SnLhL7 2leyQ9jCEq+Ob4GyZSROT+5hgbDzJR5s/QRVXyOxs+c4lG0tcefcLzaQ95kFNCXW79KHCDtK 7D09iQkSKnwSN94KQpzAJzFp23RmiDCvREebEES1msTUnl64pedWbGOawKg0CylUZiF5chaS Z2Yh7F3AyLKKUTy1tDg3PbXYOC+1XK84Mbe4NC9dLzk/dxMjMH2e/nf86w7GFa8+6h1iZOJg PMQowcGsJMJ7q/1ouhBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHeRftb04UE0hNLUrNTUwtSi2Cy TBycUg1Mm9s0tgpVbpvyyvrCiukFHxK1F9wPSZV/wRgS/i38Mt/D6cY2B7Un3/sZEvjz0COW 1+8+Sb9cNK3o0c+Vh683K8w0PC+23PdQDMup8hdvp7Jzb9hf/2nLRq1D3adDuw0usxVO/nt1 duqrJWdnceW0Jat5Hq1hm/5VYuKZ1+8+umTP/f3xWQP3xO8TjkuvCTnXsdUyduJ8kazyh6vz fM/JTFp2iIFVLGOO1dza/lJD/V61a05vz8285f11Vv4jLb/1TMWJKkZn4g/3BpyYsiClsDBN 9wFD3/EcBcHU5xuCv6lpr0lJLhDd5xBv8nfXhP5j1z0qIiumLfruE3hM+ZWO3VGP4Mo5hzc2 Ga71nXQpd5kSS3FGoqEWc1FxIgDuYVMcDgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e/4XV3bdcfSDeZe5bF4ducrq8XW37PY LdbsPcdkMf/IOVaLe5e2MFm82NvIYtF8bD2bxctZ99gszp/fwG7xseceq8XlXXPYLLZ9bmGz WHvkLrvFxVOuFnfvnWCxeHm5h9mibRa/xf89O9gt/l3byGLRsn8Ki4OIx/sbreweb16+ZPE4 3PGF3ePeiWmsHptWdbJ5bF5S79Gy9hiTR/9fA4/3+66yefRtWcXocan5OrvH501yATxRejZF +aUlqQoZ+cUltkrRhhZGeoaWFnpGJpZ6hsbmsVZGpkr6djYpqTmZZalF+nYJehnN59QL2vgr lj9Ib2BczNPFyMEhIWAi0bVVr4uRi0NIYCmjxL8N+1m6GDmB4jIS17pfQtnCEn+udbFBFL1m lHi56yQ7SIJXwE7i28ltTCA2i4CKxNTmOcwQcUGJkzOfgDWLCshL3L81A6xeWCBc4uyLFUwg g0QEHjNJtBy/wAiSYBaokji/9worxIb1TBJ7p7azQSTEJW49mQ+2gU3ASOLB8vmsIDYn0Oa/ L6cxgrzALKAusX6eEES5vMT2t3OYJzAKzUJyxywkk2YhdMxC0rGAkWUVo0hqaXFuem6xkV5x Ym5xaV66XnJ+7iZGYLrYduznlh2MK1991DvEyMTBeIhRgoNZSYT3VvvRdCHelMTKqtSi/Pii 0pzU4kOMpsCwmMgsJZqcD0xYeSXxhmYGpoYmZpYGppZmxkrivGxXzqcJCaQnlqRmp6YWpBbB 9DFxcEo1MHFFS5x5we8tW+R6kq1f0eFsvWIyg7jCfPX1k/hmGrh83r/3Zlpfz9yPohf//dn1 WCE0pdPd6b/m1ZwJjSzLTz0Vy/ZaXuOnNVlaR+3Wbd66nw8OrjDJjlEP3a/1cHVLeq6svo3T p+2tU5+JH/2TmZSYp3CmaO5tsYysib/jX95k+3+6xfnQyq1d3PF/FY9qW///WPjr3cG7UUVL pIPyBe1eeJq/WmKoHn5KLvaPoGlFqJuo6aalLg8kz/aX+XE8EUx78/Zu98eO7zznPt/L+Lbm 8IepWut2dDSKTnHX6Rb6x3/il/K8B6ff6oRMur2mudFrf5xFb1tjMuvsmQeCvG9/1HZ7IfzJ 52LN74lOAkosxRmJhlrMRcWJANktjvegAwAA X-CMS-MailID: 20250304073941eucas1p2e24f6e10f30d12dd1b12e9b8cff5af62 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250303143635eucas1p1dbcd26d4906b962e07cbde7f5ef704bf X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20250303143635eucas1p1dbcd26d4906b962e07cbde7f5ef704bf References: <20250303143629.400583-1-m.wilczynski@samsung.com> <20250303143629.400583-2-m.wilczynski@samsung.com> On 3/3/25 18:46, Krzysztof Kozlowski wrote: > On 03/03/2025 18:41, Krzysztof Kozlowski wrote: >> On 03/03/2025 15:36, Michal Wilczynski wrote: >>> Add device tree bindings for the TH1520 Video Output (VO) subsystem >>> clock controller. The VO sub-system manages clock gates for multimedia >>> components including HDMI, MIPI, and GPU. >>> >>> Document the VIDEO_PLL requirements for the VO clock controller, which >>> receives its input from the AP clock controller. The VIDEO_PLL is a >>> Silicon Creations Sigma-Delta (integer) PLL typically running at 792 MHz >>> with maximum FOUTVCO of 2376 MHz. >>> >>> Add a mandatory reset property for the TH1520 VO clock controller that >>> handles the GPU clocks. This reset line controls the GPU CLKGEN reset, >>> which is required for proper GPU clock operation. >>> >>> The reset property is only required for the "thead,th1520-clk-vo" >>> compatible, as it specifically handles the GPU-related clocks. >>> >>> This binding complements the existing AP sub-system clock controller >>> which manages CPU, DPU, GMAC and TEE PLLs. >>> >>> Signed-off-by: Michal Wilczynski >>> --- >>> .../bindings/clock/thead,th1520-clk-ap.yaml | 33 ++++++++++++++++-- >>> .../dt-bindings/clock/thead,th1520-clk-ap.h | 34 +++++++++++++++++++ >>> 2 files changed, 64 insertions(+), 3 deletions(-) >> >> >> Where is the changelog? Why is this v1? There was extensive discussion >> for many versions, so does it mean all of it was ignored? > > > Plus this was reviewed so it is even more confusing. Where is the review > tag? If tag was dropped, you must explain this - see submitting patches, > which asks for that. There was a tag, but later in v5 I've added another part to this dt-binding - reset, which I wasn't sure whether you would approve of, so I've removed the Reviewed-by. > > Best regards, > Krzysztof >