From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Georgi Djakov <quic_c_gdjako@quicinc.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, will@kernel.org, robin.murphy@arm.com,
joro@8bytes.org
Cc: devicetree@vger.kernel.org, andersson@kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
quic_cgoldswo@quicinc.com, quic_sukadev@quicinc.com,
quic_pdaly@quicinc.com, quic_sudaraja@quicinc.com,
djakov@kernel.org
Subject: Re: [PATCH 2/6] iommu/arm-smmu-qcom: Add support for TBUs
Date: Thu, 19 Oct 2023 13:13:34 +0200 [thread overview]
Message-ID: <1cdc2a68-a1e8-4cf2-8a1a-899d14f8db80@linaro.org> (raw)
In-Reply-To: <20231019021923.13939-3-quic_c_gdjako@quicinc.com>
On 10/19/23 04:19, Georgi Djakov wrote:
> The ARM MMU-500 implements a Translation Buffer Unit (TBU) for each
> connected master besides a single TCU which controls and manages the
> address translations.
>
> Allow the Qualcomm SMMU driver to probe for any TBU devices that can
> provide additional debug features like triggering transactions, logging
> outstanding transactions, snapshot capture etc. The most basic use-case
> would be to get information from the TBUs and print it during a context
> fault.
>
> Signed-off-by: Georgi Djakov <quic_c_gdjako@quicinc.com>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 12 ++++++++++++
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.h | 4 +++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> index 7f52ac67495f..655c7f50ca84 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> @@ -1,12 +1,14 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> * Copyright (c) 2019, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved
> */
>
> #include <linux/acpi.h>
> #include <linux/adreno-smmu-priv.h>
> #include <linux/delay.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/firmware/qcom/qcom_scm.h>
>
> #include "arm-smmu.h"
> @@ -466,6 +468,16 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu,
> qsmmu->smmu.impl = impl;
> qsmmu->cfg = data->cfg;
>
> + /* Populate TBU devices if such are present in DT */
> + if (np && of_device_is_compatible(np, "arm,mmu-500")) {
I'd say this can be unconditional.
> + int ret;
> +
> + INIT_LIST_HEAD(&qsmmu->tbu_list);
This list is unused.
Konrad
next prev parent reply other threads:[~2023-10-19 11:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 2:19 [PATCH 0/6] Add support for Translation Buffer Units Georgi Djakov
2023-10-19 2:19 ` [PATCH 1/6] dt-bindings: iommu: Add Translation Buffer Unit bindings Georgi Djakov
2023-10-19 11:12 ` Konrad Dybcio
2023-10-24 18:42 ` Rob Herring
2023-10-24 22:26 ` Robin Murphy
2023-10-26 17:58 ` Georgi Djakov
2023-10-19 2:19 ` [PATCH 2/6] iommu/arm-smmu-qcom: Add support for TBUs Georgi Djakov
2023-10-19 11:13 ` Konrad Dybcio [this message]
2023-10-19 2:19 ` [PATCH 3/6] iommu/arm-smmu-qcom: Add Qualcomm TBU driver Georgi Djakov
2023-10-21 21:05 ` Bjorn Andersson
2023-11-18 2:26 ` Georgi Djakov
2023-10-26 15:25 ` kernel test robot
2023-10-19 2:19 ` [PATCH 4/6] iommu/arm-smmu: Allow using a threaded handler for context interrupts Georgi Djakov
2023-10-19 2:19 ` [PATCH 5/6] iommu/arm-smmu-qcom: Use a custom context fault handler for sdm845 Georgi Djakov
2023-10-19 2:19 ` [PATCH 6/6] arm64: dts: qcom: sdm845: Add DT nodes for the TBUs Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cdc2a68-a1e8-4cf2-8a1a-899d14f8db80@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_gdjako@quicinc.com \
--cc=quic_cgoldswo@quicinc.com \
--cc=quic_pdaly@quicinc.com \
--cc=quic_sudaraja@quicinc.com \
--cc=quic_sukadev@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).